From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FEED322B73 for ; Mon, 22 Dec 2025 14:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766414744; cv=none; b=cdUfSxva7K2M8NHKa93q1nJp1/+ZqPkh2pjBGA5u/hUj1hLLT24mYOSnxpx9h6E7GlDslNbccBvgGfyijdNeb34aWLrwPzm6rTHdYh+z1Hl08HHHqRKJnQcFaN466TQj5RJ0jWwifaf4HfxrVaw/YFP1Kl1GAAznQEiz5XZIqww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766414744; c=relaxed/simple; bh=mq3Lq8sxs3JAWF9439sUZ282BxN/eqYUPbbBpwwlj3E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=F4WRiibTVAajL1GgN5WK0MYobgUilJPQ8Humm6j4HxEz8rmvg3sbQotrDBo9o+uPF5h2Z7CQ9MxwpFerz7wp77UcXgr5sfDlkvMrZ5EB3iLzGThERMfIudstE+TIe94J+kLWUoI83smfFHFlq3n88rIP0Pc6cSlhtsNE1OVW/ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A5X4YqvM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JajRNByG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A5X4YqvM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JajRNByG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766414741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mq3Lq8sxs3JAWF9439sUZ282BxN/eqYUPbbBpwwlj3E=; b=A5X4YqvM1wEts8weIEqxf7pPBcFxP0Ha5vXu9hh6N9/4cUuF8xNGGSDw4TEZH89t+Pmgr9 2HXJkxRwcOUpE/gatPu87wpVDfLCU4vjxwNO5WW3GN5bF440uVoIy1Sc/2G9T5kLYfucvX 2XZzlFj45y419Cse/3u3qvYWYMY6Ccs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-4ni6HsHzNzGjpn64C4aNZg-1; Mon, 22 Dec 2025 09:45:39 -0500 X-MC-Unique: 4ni6HsHzNzGjpn64C4aNZg-1 X-Mimecast-MFC-AGG-ID: 4ni6HsHzNzGjpn64C4aNZg_1766414739 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-430fc83f58dso2310944f8f.2 for ; Mon, 22 Dec 2025 06:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766414738; x=1767019538; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=mq3Lq8sxs3JAWF9439sUZ282BxN/eqYUPbbBpwwlj3E=; b=JajRNByGa4JMt/kaHbZRJD+Cbsx0TxtupzyU47/1Kk0ZWrKFqXH72kKirCkeoO45QK CNUTBSbzSlXBBnCMzILRq63g5tmw1YOFeOfqpLUYC9uV7vCOi4IhSN9Dr99V2V8INwHp 6o1vVddB6p4Pi0vag6MHQCwr1fODP4BZKr5kaMXSCYO2T+TCMB9twtJ9m1bopp6w70qo oqBeqy2QyAUYX0nlKN1mWhbc+Ri+x0Wwxw+b+9BaWAa6/oQGUFIkQ0pjgNG07bF6DL77 Ud2Tkt50OmcQqrYlTSKBNsU6n4X5ppw/9PROBEAZQS3WS5B/TvgTtKmJFzQSw43LhN0h Wrzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766414738; x=1767019538; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mq3Lq8sxs3JAWF9439sUZ282BxN/eqYUPbbBpwwlj3E=; b=qV/ja+4hmtJWikZFxkuSZyuYGKERr9AH3oPSn05V73L2zwLlUtyi1M/ooJTCj32/3W lZ1l8QwCRIZ34HEADY7DFYlYXmEEmTqOjxnSniW3hAiNb5jFfDTqyxavH9Ia5zXIv5/a ADOaoM2dcZr7QL6bEMf6xNie5pFlk8wehKI8EvJGFLYQTa4nLWDKQ3iEwoWADiJGoalt F2/oFtGtMcD4Unu6bUUSC+H2/K87v8Mh9T27vZx1n8QoBQWYHt+zkomNR5lMz831YEmg KSZkKYxm8FZ3+5WTdeq7JHCs8tDN/PAzvFHvC3KuT3nB/BoByI6XVum6EK128elwCCQX /YPA== X-Forwarded-Encrypted: i=1; AJvYcCU+2/f8trJ942LFAwpBYXUNvK/t/EApwbw7h/zqT68Rr6Y7KPaKTiisiLENOZmc40BokcXcYq7kCI+mERo=@vger.kernel.org X-Gm-Message-State: AOJu0YwzgxDFUZvrCiUzkocaBj/eUlOhHAWihINDuv5HuCGp8oexdsog h/+96p5YC6IuoeP+0p+Z1h1U3H7OOZDKDyoXM0eP50bsn3h945uS1WqsbJW/bR52SOkFinmGBav T/0mTAE8ByHz/2MkvB7kx0ce/9Kc2C37pqmc+4XcS4Ymc2DzVBBYY3W9zlIbrJTacUA== X-Gm-Gg: AY/fxX6NSrnckZLOTr4MYo+SPJkgglLTFsbcDQDv3rEAAxsQ8RXrMvZa0y/q3GwwN2k NStTVC/1I6ciftTzggvgPIbKjpYT0eTOAq9oN3aaahbbn4NKLRIekoQmwy3OUwtzMlNs+sbexPy BPHlmVT9CjFnLaX5CKQxhnj6Y85lSbJgv48fawjG9rbtnzdh0u7icm7pixAwKef0SWwVvWV5ftX n9oy/tSxCJAnurg1sBjgRvFGbw2xnwftk3D1nREBjjhfuQQ3jB0Uwj2NbCbX7KFCggL11yY7THj zthRcHprY3EasFRCNPzuSkmTVkiOh8YuDlwKpx0BXAvvzCSA+c5SKhGWNqfnxgDc/vZ2tkANLcl 0fDrJ+Yf9Z+s71QdEyQq+R6MkwnJ87wcHcfPvmXLj3ITjpcqUCbarR3/YKINib+kaWeWVkO+duR dh7EC1zMeR X-Received: by 2002:a05:6000:1970:b0:432:5b81:48b with SMTP id ffacd0b85a97d-4325b8109e2mr5619129f8f.61.1766414738609; Mon, 22 Dec 2025 06:45:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbLHw0fD46qNSTX57uR+znJQOS0DV63sf9w/x+8+0Lv2iDhD5E7JuxXcEwrDZcNmKVaq16ig== X-Received: by 2002:a05:6000:1970:b0:432:5b81:48b with SMTP id ffacd0b85a97d-4325b8109e2mr5619112f8f.61.1766414738236; Mon, 22 Dec 2025 06:45:38 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm22620468f8f.20.2025.12.22.06.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 06:45:37 -0800 (PST) Message-ID: <1c86695dc26202d2cfafdb636d32c47a8c3d6b15.camel@redhat.com> Subject: Re: [PATCH v3 01/13] rv: Unify DA event handling functions across monitor types From: Gabriele Monaco To: Nam Cao , linux-kernel@vger.kernel.org, Steven Rostedt , linux-trace-kernel@vger.kernel.org Cc: Tomas Glozar , Juri Lelli , Clark Williams , John Kacur Date: Mon, 22 Dec 2025 15:45:36 +0100 In-Reply-To: <871pksk3cg.fsf@yellow.woof> References: <20251205131621.135513-1-gmonaco@redhat.com> <20251205131621.135513-2-gmonaco@redhat.com> <871pksk3cg.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-12-18 at 08:04 +0700, Nam Cao wrote: > I think this overexplains. I would just explain the "WHY", then the > general idea how the patch solves the problem. Let the diff speaks for > the rest. >=20 > Perhaps something like: >=20 > =C2=A0=C2=A0=C2=A0 The DA event handling functions are mostly duplicated = for > =C2=A0=C2=A0=C2=A0 differerent monitor types, because per-task monitors' = functions > =C2=A0=C2=A0=C2=A0 require a task_struct parameter while the others do no= t. >=20 > =C2=A0=C2=A0=C2=A0 Unify the functions, handle the difference by always p= assing a > =C2=A0=C2=A0=C2=A0 da_id_type which is the task's pid for per-task monito= r but is > =C2=A0=C2=A0=C2=A0 ignored for the other types. >=20 Good point, I'll squeeze it. Thanks, Gabriele > Regardless: >=20 > Reviewed-by: Nam Cao >=20 > Nam