From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854E4405C4C for ; Sat, 16 May 2026 11:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778929457; cv=none; b=DIFpHS/vd530NNwug0S1/DR5UG6QWIMoFWxrO8vJzYm1lG4Q7CBZ1GZm5Bo0FT8aofrL/oFt5f3RX+NVe9TKmv5YgrwVoW023Vu9XX+wCJktfb1G4vKec03USWMuLmOdkcYW2XSnSqVGnLWVjDKEE60hrLwwWIjGnevKr+JeoeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778929457; c=relaxed/simple; bh=ShHzOwIepnoht6KiDhIktqWbm/o3Vwx6B0RA+PQohtk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ZYHkZzMCMnHfGXvGLSmsgtR7fFf0OJ0KMdW0Gtc7XulkYs+oS8uACTrZgJrz5y5H2TiVnKQhf9UCzU81PrKytJ+4vrvc8+9fDGGDPY/HDUdp5wU2VFt/rmANZIEbW07qH1qZIH14yi7R5+y2pTe+B1mL2UXTY0z/nDPqqmVNTvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j+mFIQlP; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j+mFIQlP" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so7208445e9.0 for ; Sat, 16 May 2026 04:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778929455; x=1779534255; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=CgxlGI2RJ/TxMcYutFk4DspmNHfrDImny4KkfuqlQkY=; b=j+mFIQlPjbDUsoKMXfrIPw3rfrTLcemNHCR5pMWsg8vw3Epj2Dio35PmXLJyQtcFGz k5Jcubu9xlpQYA11z/3VsJ+qrnjMge8PcWQGkMt5HLd0YfrDx/cSl2l7naQccrmCIVTY JekHtuhGsGDSwBvm5ugISJHfvLN7kI6GXqAlqPrlbD3VingLmN8zFfPMxHOHgbNySUx6 9w5jig0yEYIFD/3U1ENAcCk+o5ZWbak3+ME8tUxbTov06CZPTi+wyEKSCtvHNWk8WrSs VDkq1joh9KdP7QZUMkUbBHpDLOwsDRrv/FyValVdU/YiIhu0gY7S5q1tmTxpwILQnlPX f+zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778929455; x=1779534255; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CgxlGI2RJ/TxMcYutFk4DspmNHfrDImny4KkfuqlQkY=; b=RXjxj8SlpaGZpQT+E2uz/4c+6Or0csQAxyQvoWF64J9qcRmi/CqXt3LcLOYXgcI04Z S+gnBFA9/lO+a8L1yd4br7Ulp6V1DVC2fBiyIMGH2nMVvwDOhl0Q+I3bmSs98+AtON/6 LCj8Z+KZD6F/YBn7598GivC7z05WiMnU2af00dfouWxCywC33DurDPBJM2ydC0P5fr1l ZVVK+cKgWy6LtfV1GZIhEflyxDYMuMKdTzJuJ/kJ836amx2AP1nCX8ME/auV3vxy+RCd UHxDFE34/0aG69ltI14CRF55apePex/ZozrqFQF7/9UCb2cQRIxNDFgb6l2n8N3HHJ88 fT4w== X-Forwarded-Encrypted: i=1; AFNElJ8ouDmubYXPiDl85+gPfCkj0TgFyC5D707KYmX3oWZ0q2WNbq+7JYUU2D1kJbPkBjHe0RmienKIM09HMgg=@vger.kernel.org X-Gm-Message-State: AOJu0YwBNny6CpKL3WYpp2VDb6sETppG247mFz0nut/V23TQcirdlVkt wicxxrXt3gNPfBVKQQZit1l/tP30wJYD+q+hlC2AQnCtyw1jB0Gp6+zH X-Gm-Gg: Acq92OGbrpf8/Xo0im7y2pSY4Non7Zxkdg5ztJza6BS09fNOcLYOndek72w0jlP8/DV XEgbiGFwRG0emioARfb8xIzcxRaDJPwpK6EAPhr/g6JwVMc4jA2ktVVUvn+rs9n2jEledo0pRai SmCmw2o7dNeDjCQdcgiJWCxBk6e9VkizTOix8/h0ywogQU3Ul6SLnDWCQQQ1laF3mqJ/9Erf/w1 Gw/m0pRN99p6dKU0f6yXyPw5k4Uj8coHu7wqOnnL5cK9hXvJbGIKPU8/Qys5rM/t8AxQsl9sZHX BFh+gQ77edJxeFdGEy71RJ45sTFtUC+hQlJ2WAtzJzAqJG8t8rqtQAsKzV/YrbhDWG61CcX9Ofd PvMCmFOAeSx065zFLVEocAEkWX90138PwcRW0523/Z9i3dzjIoLkzu8aQizMvGvnWDsqRmjS97t jzs0JioHPIct6vlNVuCww9mpL7+flMIGnU5a9q2nV1ct5putFsrGL9k6H725dF7M+c7aTCj74= X-Received: by 2002:a05:600c:35cc:b0:48f:fe2a:107b with SMTP id 5b1f17b1804b1-48ffe2a1125mr5855755e9.7.1778929454853; Sat, 16 May 2026 04:04:14 -0700 (PDT) Received: from ?IPV6:2a01:e11:5402:d840:f1ee:c5d:74e4:6e19? ([2a01:e11:5402:d840:f1ee:c5d:74e4:6e19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19a0csm21338399f8f.20.2026.05.16.04.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 04:04:14 -0700 (PDT) Message-ID: <1c87362a-bba8-45b8-a836-153f468815c4@gmail.com> Date: Sat, 16 May 2026 13:04:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Aldo Conte Subject: Re: [PATCH v2 5/5] iio: light: tcs3472: move standalone return to default case To: Jonathan Cameron , Andy Shevchenko Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, shuah@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev References: <20260512223215.25596-1-aldocontelk@gmail.com> <20260512223215.25596-6-aldocontelk@gmail.com> <36ed59a7-8af7-4458-9e90-70ea251b389e@gmail.com> <20260515190517.70bb0ba5@jic23-huawei> Content-Language: en-US In-Reply-To: <20260515190517.70bb0ba5@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/05/26 20:05, Jonathan Cameron wrote: > On Wed, 13 May 2026 20:58:40 +0300 > Andy Shevchenko wrote: ... > > I would add for this that, to reduce churn it's fine to add the > struct device *dev = ... bit and use it in new devm calls. Just do the > remainder in the follow on commit. > >> >> > Hi Jonathan, Andy and all! Thanks for your reviews! they’re teaching me so much! If I understand correctly, I need to wait a week before submitting version v3 such that other reviewers can comment right? I’d like to take this opportunity to suggest two alternative lists of what version v3 might look like in terms of patch order: First option does not consider the "== NULL with !" patch and so: 1. iio: tcs3472: power down chip on probe failure (NEW precursor, bug fix) 2. iio: tcs3472: sort headers alphabetically (same) 3. iio: tcs3472: convert several functions to use guard(mutex)() (modified) 4. iio: tcs3472: use devm for resource management (slimmed down) 5. iio: tcs3472: use locale struct device * for remaining cases (NEW) 6. iio: tcs3472: implement wait time and sampling frequency (revised) 7. iio: tcs3472: move standalone return to default case (same as v2) Second version will consider it: 1. iio: tcs3472: power down chip on probe failure (NEW precursor, bug fix) 2. iio: tcs3472: sort headers alphabetically (same as v2) 3. iio: tcs3472: convert several functions to use guard(mutex)() (modified) 4. iio: tcs3472: replace == NULL with ! (NEW, optional) 5. iio: tcs3472: use devm for resource management (slimmed down) 6. iio: tcs3472: use locale struct device * for remaining cases (NEW) 7. iio: tcs3472: implement wait time and sampling frequency (revised) 8. iio: tcs3472: move standalone return to default case (same as v2) What do you think? Thanks, Aldo