From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: clear cold data flag if IO is not counted
Date: Wed, 17 Oct 2018 10:50:48 +0800 [thread overview]
Message-ID: <1c88d521-c36d-91d5-b863-d3fae6be4737@huawei.com> (raw)
In-Reply-To: <20181017023404.GB77619@jaegeuk-macbookpro.roam.corp.google.com>
On 2018/10/17 10:34, Jaegeuk Kim wrote:
> This reverts commit 66110abc4c931f879d70e83e1281f891699364bf.
>
> If we clear the cold data flag out of the writeback flow, we can miscount
> -1 by end_io.
>
> Balancing F2FS Async:
> - IO (CP: 1, Data: -1, Flush: ( 0 0 1), Discard: ( ...
>
> GC thread: IRQ
> - move_data_page()
> - set_page_dirty()
> - clear_cold_data()
> - f2fs_write_end_io()
> - type = WB_DATA_TYPE(page);
> here, we get wrong type
> - dec_page_count(sbi, type);
> - f2fs_wait_on_page_writeback()
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
prev parent reply other threads:[~2018-10-17 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 21:22 [PATCH] " Jaegeuk Kim
2018-10-15 12:38 ` [f2fs-dev] " Chao Yu
2018-10-15 23:08 ` Jaegeuk Kim
2018-10-16 1:31 ` Chao Yu
2018-10-16 3:10 ` Jaegeuk Kim
2018-10-17 1:30 ` Chao Yu
2018-10-17 2:43 ` Jaegeuk Kim
2018-10-17 2:34 ` [PATCH v2] " Jaegeuk Kim
2018-10-17 2:50 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c88d521-c36d-91d5-b863-d3fae6be4737@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®