From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 832D31A76DA for ; Mon, 30 Dec 2024 13:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735564771; cv=none; b=G+que4zkgbxVGoqi2cUqbeV+er7lf9rPiq5uJWAfyVYP8TtEOo4tft7C8JJWBxbjkkd3e4Xmqqa0ROvLSVscED867L0M3OjO4OBtoh+lQx3zxFwQP36inO5TBxvBJ1u4RtyaZOlYZblBHjfXACkV9/JFviu+4KrJ1PyGxFaP0Ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735564771; c=relaxed/simple; bh=P9V8RyAYeY/QXqKaIdNRYhKNZu3ImQwwZHC7Gns+eTY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KRmvpeFbaR2IgrcyVqBMlGvS3ZXYSqCb/tXLe3Q2TnLgUcYt1jgtVQLi7yAzYCK7Yn04nhcNkg7HATqQ+q/dXLO9Ws6yRT7J3KIspSnLCmn+6R3AvM7HUQc++kGCbgMobVBhhmjw22dp1Vi0m8pt1KnK2tQ6yFnMi/D3K7JFR0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h/v3kOJR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h/v3kOJR" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BU9KvDJ024520 for ; Mon, 30 Dec 2024 13:19:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NHFq+0HhJPokWAUjbZS/ExdVRM0xjW7ODn4JeKNX9PE=; b=h/v3kOJR94e1dZIo MB2EkEWlxdtROK7mHo50oMuOWq2Hj1bOJ3Igo4RYoA+IPf6B76FjjwgVn2AqRWey EKe/qWEptOV6ZMF6tmy6iqHKEhdWoFprmO/xLesrRmoLvF7eRPRFwMvdmXU9ybRM wvzAym53W77BXhogEzN0I5x8H+tJZsdQdygGEomHpIpFoH5rfquHjsmHEXF7qNFV CkGN4JUHHgixfWWx3elJUv1aZn4eXYri6JubA5mllWRtNkYrH9fhQIEVSVQdycKX czNzrMFkCcF6aKccytQfkrCx4wIk5Ysd3Qi+pICw/c1dXS0vmjU7PUAOjSmsGGuv lA1/bA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43urt88fr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Dec 2024 13:19:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-467a97dec51so6188881cf.0 for ; Mon, 30 Dec 2024 05:19:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735564766; x=1736169566; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NHFq+0HhJPokWAUjbZS/ExdVRM0xjW7ODn4JeKNX9PE=; b=pEJZb9YaVot4lDsOuOepYxIdZ9HrCBxf5gJEzaCs0VFxGqnntPaGt+EUh3ehPf5USJ iTBDwDxr8ziqrZ/5hLDF6sfLPh/x/UzMzUUJ4ytVybl3JTqIfuJaVp3irMAoNiomvYFy JE7Z4hTE/YWcBwxk+qpAuQfw3X9C9hEaHtEi8o3mgsBCAocGvvi5ATbbUtX5BbeYC6mK D8qJy71rF4oCcrJoBuTgdHy2E2oprf2JmllQ81iN34bdf6bxyN6g/xvMjylkkfWRXBvw l1HGavkiOz5mCJ7TbAMBMTJIMHdONuoAYYB4SIvRqzcHzsG9G3+8KEiJ/0rQC2Ozv8Ev mSPA== X-Forwarded-Encrypted: i=1; AJvYcCXP3HHCj3AOiq3123ooeAQy+2425ul0dVr0upcXQDy8ZyiPTUh/aWMtLc7kgxN0H4MSLe7l8WSoBOt63z4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7R5jZhB2s9d6xWQ6FyAptpJLsiWLKNBm7TMhqDdN5P7jaitJO VgnR3qzNw9NNKmxc4qW/Vsfa+0AGXRusj1N1Hk5TrVdLHWbEXrchtKIytrn1HRvpqJgoNr6HTkl vF0H3U7so3xktyFmPmfSUlzsKMXrlMq9gZCAL/iP+1jw9VXCPXRAiaP4lOQkWe/U= X-Gm-Gg: ASbGncu+qjjn0KiloDTeBg1tZ8xzVAamIcJm0Q51Vd0bI9fu7e3HfMw7/8Vk88+nxSF vVs/6T45MHSYNPocvrJ9aN7Pskri0XjyyyWMUuxTdxFQTetQ/PERtULth0jA5yjvSvNCIBZcqXb jDAAf1vlaKPpyMr9NwC6ch11oh1rdeSiB8UVzlPsxoqGdfXCo0wdS+2v43yr7rKX82N9rUwno7X ptSgjeBFO5CNOmjIPQUQLrakjU3TPVTLxJg1taoIgfPjLShcgHKmmubV3j0rHydrVMPpx5JVhhV PUuFRarwky5CS+2I3X4iHJCdrOx4ysRnOag= X-Received: by 2002:ac8:5a4d:0:b0:467:6983:fe85 with SMTP id d75a77b69052e-46a4a8f0323mr198286991cf.9.1735564766191; Mon, 30 Dec 2024 05:19:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvR6snFKsFaKyNqqe/Bt2HRaIn7T6BMuLgYLvbOr2C+FMHreEnXg5ipnU3OzTrvzzea0LKWA== X-Received: by 2002:ac8:5a4d:0:b0:467:6983:fe85 with SMTP id d75a77b69052e-46a4a8f0323mr198286861cf.9.1735564765857; Mon, 30 Dec 2024 05:19:25 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80676f192sm15132682a12.35.2024.12.30.05.19.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 05:19:25 -0800 (PST) Message-ID: <1c8af731-c551-4d72-84a0-f14d57bec4ec@oss.qualcomm.com> Date: Mon, 30 Dec 2024 14:19:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu To: Pratyush Brahma , andersson@kernel.org Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241227110024.30203-1-quic_pbrahma@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241227110024.30203-1-quic_pbrahma@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: V2HubVO0yxp2Z9cPAxLvSbK9rHYBVZSN X-Proofpoint-ORIG-GUID: V2HubVO0yxp2Z9cPAxLvSbK9rHYBVZSN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412300115 On 27.12.2024 12:00 PM, Pratyush Brahma wrote: > Add the device node for gfx smmu that is required for gpu > specific address translations. > > This patch depends on the patch series [1] posted by Imran Shaik > adding the clock support for gpu. > > [1] https://lore.kernel.org/all/802d32f1-ff7e-4d61-83f1-f804ee1750ed@oss.qualcomm.com/ > > Signed-off-by: Pratyush Brahma > --- > arch/arm64/boot/dts/qcom/qcs8300.dtsi | 37 +++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi > index 80226992a65d..8eb688e2df0a 100644 > --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi > @@ -816,6 +816,43 @@ > #power-domain-cells = <1>; > }; > > + adreno_smmu: iommu@3da0000 { > + compatible = "qcom,qcs8300-smmu-500", "qcom,adreno-smmu", > + "qcom,smmu-500", "arm,mmu-500"; > + reg = <0x0 0x3da0000 0x0 0x20000>; > + #iommu-cells = <2>; > + #global-interrupts = <2>; > + dma-coherent; > + > + power-domains = <&gpucc GPU_CC_CX_GDSC>; > + clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>, > + <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>, > + <&gpucc GPU_CC_AHB_CLK>, > + <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>, > + <&gpucc GPU_CC_CX_GMU_CLK>, > + <&gpucc GPU_CC_HUB_CX_INT_CLK>, > + <&gpucc GPU_CC_HUB_AON_CLK>; > + clock-names = "gcc_gpu_memnoc_gfx_clk", > + "gcc_gpu_snoc_dvm_gfx_clk", > + "gpu_cc_ahb_clk", > + "gpu_cc_hlos1_vote_gpu_smmu_clk", > + "gpu_cc_cx_gmu_clk", > + "gpu_cc_hub_cx_int_clk", > + "gpu_cc_hub_aon_clk"; Most of these entries look totally bogus, please make sure you only reference the ones actually required Konrad