From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FBA318BBB for ; Thu, 12 Feb 2026 20:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770928903; cv=none; b=szgwlygtOp7TVU+XfrRapEtLbhjqYTrBk3Rf61JMhZ0Qw1E8GJw+1sGVFbEvzDTjzfJph6J7eKMLamR/40slac7RwvJi3kM6LlczpSOVSOa6J08pBbVI/nblmY5vfujHDTp25ql2psegNr5pL0ykU5bTeNp1rhvrFUGRP93Vn4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770928903; c=relaxed/simple; bh=puqpSLgYp5+DLUc+CMOLCPUjPfxEiDGdChhYjSYQkl8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d94h6Qyw7Mvqe8uU4DtoYl7jNGyVKMFRyff7JHsDYROJwd0Ao/kNDzujoV4c0L3Dp6ENAn2/WTDx6rcZknucUDPM9zVOcoBBkFhiqwHkANPioN1znYvdvWB+4o9iZVztw5Kdym0HRx2SgBEQWzNsHhzDgSfJnOvlc+wy667rtXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U6xc+6Sg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hyEjWtcM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U6xc+6Sg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hyEjWtcM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CIlILK455012 for ; Thu, 12 Feb 2026 20:41:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NgywEGgLe59qtrAUSuFO9PtFp926hXyT4OPCp7SP2Jk=; b=U6xc+6Sgk3ScJ+36 5Z+JAh6ouasi/SObFaZVJfzkfLzXx3GnBIFcaQVRSar0/7lpNlqNzSI+RvK6usmE 1mcJbjgshgq7g+/QqJPFLYjkre7/BF/JBnu8F3ERA3JxHB4RxYq1RAR7YgC8EQPx 6Vqyf49KQqQi9I8a0PQR23V9W6/amU0CfxCuXAa6855KxK5qzMloFJ34Q/Hq8Efc pa48ZnYjNsYJsDOaxSU5k21MRh+adi0CWZeyk4aqPdMdkVq1pfOp1lbp5R3eZVT4 iiGHZ8178TFDQJoElOLhJhz3TzCd1r1neo32fbhPUxdAH9c14JPZTHqTxlEKkuA0 QK2Zgg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9mev0c5k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 20:41:40 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a7d7b87977so2289145ad.0 for ; Thu, 12 Feb 2026 12:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770928900; x=1771533700; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NgywEGgLe59qtrAUSuFO9PtFp926hXyT4OPCp7SP2Jk=; b=hyEjWtcM9Op7ueXkO6SPtoNO5Ey7a1G+EnSfL6e/dF3/Tk08LcAfP6f9x7K444EH5p I2z2Q7rAWGU4NJMFwvrQD4ZTpHNvyPFp8sGt5oRohk2fTQoRWaDnTaAzxeOcNMb+t/HK awnEonEHH0ospzzv979OLivAN3xf2495b6pEdE7zU4OInARH3n/scZXzQNzIVphxy+Gw LQS8cDGH1k1EkSQ91J4jOeBHN2ufF5refFMw1MDbIH6TD5i7T4PaesJrIAgQiYEdI6Fq 3u3xVGxCyphGRww4RI+RWozKUXTk5OpV8HAjOnm2Fr6Gcm/K1Ez7nydPgo4PyFoYXan5 sQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770928900; x=1771533700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NgywEGgLe59qtrAUSuFO9PtFp926hXyT4OPCp7SP2Jk=; b=akFQeW5GHVZo/N2nJ6JvbqL81aYkHxJOsYk1+ZtzhGkeSQsQXFkSmWn5KH9gkwPEC5 XvdkcKbcJmR6pgIR0b/klkjpqRe1Qwk8uVYK158HXbIe1H0hiu3rn25S+UGt7bwvYqZc 1vBzVZbHnLT3hUVmHxu/1DQYA/uaakVcJ57LLPPgAn7TQD0hvx2PXlaII5Ol84rnDrCg gowWHU84tmhSaHVAJcvRi8oiyD3sX7Ylc5kYpL0ToY7wyxZ42delqgb+zHW4Ihn6Q9oz ZWgMt7E2wIwa/XIMtKh3xJr1ux8PlZV1IKKPKutJ8nuwPPwIWrb1nmQbBG8InPT6VOif oF/g== X-Forwarded-Encrypted: i=1; AJvYcCXq/6ZLPyt+9cgkSSvnhvX0Y4B4OaRrR4fZulAP177Kjgx3scBDDinKfrov4O9YM8Zz4adsecYAsgi/eAU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9o5P5FDx7U1qPGofJsoomMI0nDUZUL9uU+dyIFISa9dwi14fF w8da/JADNyIBV3os0oJV8j0310MRfRx0I1BSoiTBFUn5YkpExftoVYZkGopsZRQATiZBYak44Yf N7+n0e2Vp4E0d834GWWnCC6S3OHSHN78XVRXI1guF4HGRcIuu/doLDdlcvECiyaEIq3c= X-Gm-Gg: AZuq6aJ/8BaFFg2558prO1ltLqPEnGvY++6hwivLrTZuOUKSLekDjNSw+VhcwCJCbIm OZkgg//Uj2D+r/Ld5ycDTQTe4qViCuh6csoGLsQjpUhhDeCmkpapyPSzamKrU7ypfZP33nCXZXT vMZ8n2+T6YGp+ERxbAtVXJrcmHKyZsm8gsFPnxoFUy0vC6r53Q6zWtkG63FqEcSQPDS33z+MJLy itN0OBZyTwxLFOz3MMTAzDMqJvT1i1lGCcFondvEhskOu2tglGQImN00niXFHxpYQUAI8NYXkBo FKBcoyNtlqdsnvqUf5XruWD7VP9wHiXIfah60MQZDl6ILZ3MlRQEaUx6slX7CiIJG6c3eozdQ8t s2TpTt1nvin4H0whHByoX2FwiwAIh+rfJambYaMqx7QqhaMIcOw8KpWY= X-Received: by 2002:a17:903:46cd:b0:2a0:bb05:df55 with SMTP id d9443c01a7336-2ab4cf42abfmr3012645ad.21.1770928899899; Thu, 12 Feb 2026 12:41:39 -0800 (PST) X-Received: by 2002:a17:903:46cd:b0:2a0:bb05:df55 with SMTP id d9443c01a7336-2ab4cf42abfmr3012365ad.21.1770928899280; Thu, 12 Feb 2026 12:41:39 -0800 (PST) Received: from [192.168.2.5] ([49.204.20.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab2984ab0esm59142485ad.9.2026.02.12.12.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 12:41:38 -0800 (PST) Message-ID: <1c92466d-20b9-46e3-831a-ae058cb23c5d@oss.qualcomm.com> Date: Fri, 13 Feb 2026 02:11:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: hwmon: Add qcom,bcl-hwmon yaml bindings To: Dmitry Baryshkov Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , amit.kucheria@oss.qualcomm.com, Daniel Lezcano , Gaurav Kohli , linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260206-qcom-bcl-hwmon-v1-0-7b426f0b77a1@oss.qualcomm.com> <20260206-qcom-bcl-hwmon-v1-1-7b426f0b77a1@oss.qualcomm.com> Content-Language: en-US From: Manaf Meethalavalappu Pallikunhi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Zq7g6t7G c=1 sm=1 tr=0 ts=698e3b04 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=vFtg0H/HDnVpo/8TLRRAnA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=GuN8W3Bbd2OushFT6gEA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: ELkF0xxHrAz3KnOADHYrPYZuJO0WbRnY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDE2MCBTYWx0ZWRfXx2gtYJYb4kbm YjW/bMJdEjGfKvFhPP2cRjzHFqeXlnsQ/cQFUEGbpu0tIYhiJ3xzQfbkdtlynSneBvBDcCCRkCz GU673eWYByoH4L5K9mkqBDzgeYgf8WS6QND+sxbXP34gu9E2SJ48gUYmhPBl0YsvNKUyqF5Yzx5 RfWQnuI47qnKgu3ubHdBLGwQMAle9BKRY5ru8Sj5t5OeP+iRYsY6Q0SHaTW1DygXUI1mYQ81/f9 i0zd/EzMm7Clp+rV71BcbJqEQrW42OgpbgguBwrI1/dNX70FL8vVn5g3X6lLVfkyIt9XwimWf3m RWBS12wKGykane7V0Q+8jgLrwHCf5Jf45UrCLj7aNveSFyqAWvy7c3gi8/kM1WtKJnnzDUBBl7j fRU9ZWKFktLwJohXhP4xxQ30TPJPL6UO/EbEVu/p263oMnYokaP8UZx+jo9KfyIFwxdHM7hwf7W nKANu0x5HMSYclBMvKg== X-Proofpoint-GUID: ELkF0xxHrAz3KnOADHYrPYZuJO0WbRnY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120160 Hi Dimitry, On 2/6/2026 2:38 PM, Dmitry Baryshkov wrote: > On Fri, Feb 06, 2026 at 02:44:05AM +0530, Manaf Meethalavalappu Pallikunhi wrote: >> Add devicetree binding documentation for Qualcomm PMIC Battery Current >> Limiting (BCL) hardware monitor. The BCL hardware provides monitoring >> and alarm functionality for battery overcurrent and battery/system >> under voltage conditions. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> --- >> .../devicetree/bindings/hwmon/qcom,bcl-hwmon.yaml | 128 +++++++++++++++++++++ >> 1 file changed, 128 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/qcom,bcl-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/qcom,bcl-hwmon.yaml >> new file mode 100644 >> index 000000000000..a0e8eaf13eec >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/qcom,bcl-hwmon.yaml >> @@ -0,0 +1,128 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/qcom,bcl-hwmon.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm SPMI PMIC Battery Current Limiting (BCL) Hardware Monitor >> + >> +maintainers: >> + - Manaf Meethalavalappu Pallikunhi >> + >> +description: | >> + SPMI PMIC Battery Current Limiting (BCL) hardware provides monitoring and >> + alarm functionality for battery overcurrent and battery or system under >> + voltage conditions. It monitors battery voltage and current, and >> + can trigger interrupts when configurable thresholds are exceeded. >> + >> +properties: >> + compatible: >> + oneOf: >> + - description: v1 based BCL >> + items: >> + - enum: >> + - qcom,pm7250b-bcl >> + - qcom,pm8250b-bcl >> + - const: qcom,bcl-v1 >> + >> + - description: v2 based BCL >> + items: >> + - enum: >> + - qcom,pm8350b-bcl >> + - qcom,pm8350c-bcl >> + - const: qcom,bcl-v2 >> + >> + - description: v3 bmx based BCL > You need to explain your abbreviations. What is BMX? What is WB (and > yep, they should be capital letters). What is the difference between all > three of them? ACK, Will update in next revision > >> + items: >> + - enum: >> + - qcom,pm8550b-bcl >> + - qcom,pm7550ba-bcl >> + - const: qcom,bcl-v3-bmx >> + >> + - description: v3 core based BCL >> + items: >> + - enum: >> + - qcom,pm8550-bc0l >> + - qcom,pm7550-bcl >> + - const: qcom,bcl-v3-core >> + >> + - description: v3 wb based BCL >> + items: >> + - enum: >> + - qcom,pmw5100-bcl >> + - const: qcom,bcl-v3-wb >> + >> + - description: v4 bmx based BCL >> + items: >> + - enum: >> + - qcom,pmih010-bcl >> + - const: qcom,bcl-v4-bmx >> + >> + - description: v4 bmx with different scale based BCL >> + items: >> + - enum: >> + - qcom,pmv010-bcl >> + - const: qcom,bcl-v4-pmv010 >> + >> + - description: v4 core based BCL >> + items: >> + - enum: >> + - qcom,pmh010-bcl >> + - const: qcom,bcl-v4-core >> + >> + - description: v4 wb based BCL >> + items: >> + - enum: >> + - qcom,pmw6100-bcl >> + - const: qcom,bcl-v4-wb >> + >> + reg: >> + maxItems: 1 >> + description: BCL base address in the SPMI PMIC register map >> + >> + interrupts: >> + minItems: 2 >> + maxItems: 2 >> + description: >> + BCL alarm interrupts for different threshold levels >> + >> + interrupt-names: >> + items: >> + - const: bcl-max-min >> + - const: bcl-critical >> + >> + overcurrent-thresholds-milliamp: >> + description: >> + Current thresholds in milliamperes for the two configurable current >> + alarm levels (max and critical). These values are used to override >> + default thresholds if a platform has different battery ocp specification. >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 2 >> + maxItems: 2 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + pmic { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + bcl@1d00 { >> + compatible = "qcom,pm7250b-bcl", "qcom,bcl-v1"; >> + reg = <0x1d00>; >> + interrupts = <0x2 0x1d 0x0 IRQ_TYPE_EDGE_RISING>, >> + <0x2 0x1d 0x1 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "bcl-max-min", >> + "bcl-critical"; >> + overcurrent-thresholds-milliamp = <5500 6000>; > How is going to be used by the power supply subsystem? There is no any interaction with power supply subsystem for bcl alarms Thanks, Manaf > >> + }; >> + }; >> >> -- >> 2.43.0 >>