From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 960ADC4321E for ; Thu, 1 Dec 2022 11:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbiLALhJ (ORCPT ); Thu, 1 Dec 2022 06:37:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbiLALg7 (ORCPT ); Thu, 1 Dec 2022 06:36:59 -0500 Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC38A22BF1 for ; Thu, 1 Dec 2022 03:36:58 -0800 (PST) Received: from atl1wswcm04.websitewelcome.com (unknown [50.6.129.165]) by atl3wswob05.websitewelcome.com (Postfix) with ESMTP id 450F1F816 for ; Thu, 1 Dec 2022 11:36:58 +0000 (UTC) Received: from md-in-79.webhostbox.net ([43.225.55.182]) by cmsmtp with ESMTP id 0hs7phXThgEOM0hs9piqKB; Thu, 01 Dec 2022 11:36:58 +0000 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linumiz.com ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kkbqgxk/YMTTr4GHrSnoqsTFSBqsgm0vcdYl9c4cfVM=; b=cHqwZipTJvf7mo34V7k1JJ/oF3 Q+Cbi/iDPx2RAi0MV2UuWRZFTJ4yDmOX7Y9MoufE5BQTM6vKI6tXN2vcUXRl4SVtn5HYV+tuKTzm4 mdzRGlGHYHYtqi7Yvuj1MnjPMwOnNvHJsToCD+OyoU5ufhqmhEhkwCEi975lekG8O4it19c27xeLU UPynG/XUCLvIT9gojkYohQBHU+ajExN5/jrXjtrjcOLQgvpzJDCl5wdkbNp4AnPK9mNzVp6UiLf0G N+XqENu/t3S+pBgV8JcuUBUiX985x50JaihfZePxljLN/xqLIA0U04885omD8uFjCOXfF/McHN6lz 3bXdVrtQ==; Received: from [223.187.121.253] (port=48632 helo=[192.168.221.42]) by md-in-79.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0hs6-000SeA-HR; Thu, 01 Dec 2022 11:36:54 +0000 Message-ID: <1c989c0a-e66d-9c57-5932-0fa5599ef8ad@linumiz.com> Date: Thu, 1 Dec 2022 12:36:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/4] hwmon: (pmbus/mpq7932) Add a support for mpq7932 Power Management IC Content-Language: en-US To: Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, linux@roeck-us.net, jdelvare@suse.com, linux-kernel@vger.kernel.org, marten.lindahl@axis.com References: <20221201044643.1150870-1-saravanan@linumiz.com> <20221201044643.1150870-4-saravanan@linumiz.com> From: Saravanan Sekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - md-in-79.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - linumiz.com X-BWhitelist: no X-Source-IP: 223.187.121.253 X-Source-L: No X-Exim-ID: 1p0hs6-000SeA-HR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.221.42]) [223.187.121.253]:48632 X-Source-Auth: saravanan@linumiz.com X-Email-Count: 11 X-Source-Cap: bGludW1jbWM7aG9zdGdhdG9yO21kLWluLTc5LndlYmhvc3Rib3gubmV0 X-Local-Domain: yes X-CMAE-Envelope: MS4xfDORlRsMZXuJ4pMF8BhNN6cZbCbzTG/mojvPzQ26nBSrsOkE0ugCW3AflGcT8XIH+EzFZ8aNcISzRMphUBTeo8isKlnzIM19hdt3So70k7jMgSZwPfL+ uNDEiaOPT3PYingYX3aNHLfUSFftqwm7T39JV/MAMef5haG+QF73U+MuLBDG/KUzjJdrk+eg1IJWj0dyDbyyTzTmVX+gZy1O/mE= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/22 11:26, Krzysztof Kozlowski wrote: > On 01/12/2022 05:46, Saravanan Sekar wrote: >> The MPQ7932 is a power management IC designed to operate from 5V buses to >> power a variety of Advanced driver-assistance system SOCs. Six integrated >> buck converters with hardware monitoring capability powers a variety of >> target rails configurable over PMBus interface. >> >> Signed-off-by: Saravanan Sekar >> --- >> drivers/hwmon/pmbus/Kconfig | 10 +++ >> drivers/hwmon/pmbus/Makefile | 1 + >> drivers/hwmon/pmbus/mpq7932.c | 144 ++++++++++++++++++++++++++++++++++ >> 3 files changed, 155 insertions(+) >> create mode 100644 drivers/hwmon/pmbus/mpq7932.c > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > Thank you again for your time for review. I saw two comments from you on V1 which I believe addressed on V2 1. Missing maybe_unused, so drop of_match_ptr. ".of_match_table = of_match_ptr(mpq7932_of_match)" dropped of_match_ptr. 2. It's a regulator, not hwmon. "config SENSORS_MPQ7932_REGULATOR tristate "MPS MPQ7932 buck regulator" " It is PMIC chip with hwmon support access over PMBUS. Please help if anything I missed > Thank you. > > Best regards, > Krzysztof >