From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA393E573 for ; Wed, 10 Dec 2025 21:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403170; cv=none; b=B+1Q6zbmHk06OcLPFD384rYGVa4+fcF82IgPTy6nVyMHqVyV0Rfis/gXezH6ABWaM1xE3lKfcHdprzZMg24t+Jd7e8xi3gYcqxRGwwqnAwunkofzvG5h2802ykTnDS2ngYN53s50Cq56hOL14Vuf1RngRRH+Nl69YcsiyQ7bRG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403170; c=relaxed/simple; bh=QrsoN2azNxIpAh5CaG0o7xMKjiSA2W1NIXcLmJY6M5A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E8kK0WZXniuTkgk1Y3Qw8VAUkFpl4IaVVzBp+PFadpZ+GsF1YvppsIC30GCtaYCx4Q7V1Eds5qWsfkyku109yPRVCEUtxbVjB09xwYSNFB3JnI3mI/CelwkMj+On30OT7Io43QowIs6fb7IrHSSIL8+L8hWWDZE/uDWUKhIPBfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mroN9O/G; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mroN9O/G" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-297e264528aso3724495ad.2 for ; Wed, 10 Dec 2025 13:46:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765403168; x=1766007968; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XvjbXstxZws0JCVxSCuOJ6i73/Kz7IsJRWNMQucF0cQ=; b=mroN9O/G+RcHOtq0+V1rYowM28vsLJdF+PReuq4D4hoX4WzUak4w8o9GVuaa4KLZWf GPJyQtWFJpWm32/AwZrW1G9chQZ9ucBvueO5gGEYbAgdU18Rx9ldNzxYg2B/QIZ7AcAM yEvBQDBM+qHwkGD5qRw7kbh+sKDqtmKV9LuVhddq8/Ygd8pvL5UngLFQnE7orrxcWzvY tw9HuUWlMDwHkGyCGnBNoELMy5muImjrv+OiBy8bBqatn61xOfHAGRZC6xeUW4ZGsxGN /y/1Ph/r+CLrEpH27aY6PMSrK/OxJyKkthjV2Tk37LIJc6aSrp5lBtdQk7ry//DDh7p2 4HGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765403168; x=1766007968; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XvjbXstxZws0JCVxSCuOJ6i73/Kz7IsJRWNMQucF0cQ=; b=rascyGrUQehNNQHnn8FKDE7+nFV8t6HzqJzoIj0MmdtMJEZ2vRl3Kekh9XYMjKidcP Pl0rm6RH+w3Hp4u775xbGbPDet6FfvertXbERAIFLXvAewYuOcN+N/h8BF1qroobFibm PhoQw9DgkXNkAeQ/yU1cQHyRwroeFSf9I5sfaziNNPExUffivKNanSB/gnL4XCzBEeP1 SuqtCzVLi7cFonrvDJefN93GEsyzr4VQpgQV3VoLJ1rpWPqqBwG+JwDLuxRJhQCxd3Kp WIHfXYl9/39Z69h4Qmukl3SnqvkTkxoEokXRHqOMRRfzxyPA/F01PwEBgn4CqJ7F/Sn6 LsoA== X-Forwarded-Encrypted: i=1; AJvYcCXKncGEUJvD1zK8i53m5KZIkmTSsXyYTBFYSuLvFtiB4S+5YyYIr20IKrYryUrs/g9axQjDe8xbDqIPeAg=@vger.kernel.org X-Gm-Message-State: AOJu0YzLeO7fyEaJIVQQc4J/GIvSNaA6NlR/8ENxvefUrZ1/S64L3+26 KgwdOxutbvlPsIuT09rlWwHvacidY/+i7mJoNqHuqhdTXTBz5AGx00olD7+48qxX4Ew= X-Gm-Gg: AY/fxX7fIEeFr4gRHYdD6afpl0ckEZGVbLG9QqamT68tzTRi0ZBuEiY3dlcxZ5Z2Ct3 s+0wEPeYadOrFQ6MKmht4Iw56RL6iyOhmu+ARIug7lh1eEY6/mEraShuX9lAcP11qnDo7xMIRAO ZJE7NQasAPMeE1oOE772ye3ihytwNJ0QlTUMrnsK1RYeAszyMvR4a5ff25Tlga2jrf9kmAibNRt h8aRru+miLfmi77sUrv732FaBdYNvCQ/HetFWKnnGWAXjFIDyiFklZH5TsfhrPo4jo6AMCSBZsz rasjHZ6dEHn3mWkm5vHR3FYE0LnFlE6A1Z3kDanOjcC/WvM4T9fe2fPnb0KeobkQVBpV6fb4pLu +y3avKF6HBjGhr4IbzCwbg3e+BLewjmRh5Dj49zx3qdKFANF6J3nOVd+sTgOhi7y8eCn3lwi/EE SNazxfP5owMJPoAKJp/CI4onIghPMejmQikll1UPhs2LbNm6rp6vdKyepaP5c= X-Google-Smtp-Source: AGHT+IGexHXYQjFit2gnkEqUInFK9e7lZ5vay6JMROzUucD6dZ/qQ1CLM5Fdd3WZfFFSf98HL7pgCw== X-Received: by 2002:a17:902:ce09:b0:29e:38de:6140 with SMTP id d9443c01a7336-29ec22fadffmr36116815ad.13.1765403168033; Wed, 10 Dec 2025 13:46:08 -0800 (PST) Received: from [10.237.118.45] (M106185144161.v4.enabler.ne.jp. [106.185.144.161]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a8f6e5af0sm267766a91.9.2025.12.10.13.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 13:46:07 -0800 (PST) Message-ID: <1c9db550-677e-4fdc-8929-89c21deecf17@linaro.org> Date: Wed, 10 Dec 2025 21:45:56 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/5] media: dt-bindings: Add CAMSS device for Kaanapali To: Vijay Kumar Tumati , Dmitry Baryshkov Cc: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski References: <20251208-add-support-for-camss-on-kaanapali-v9-0-3fcd31258415@oss.qualcomm.com> <20251208-add-support-for-camss-on-kaanapali-v9-1-3fcd31258415@oss.qualcomm.com> <458a7841-e422-4cad-83de-f5b5c1b683a6@oss.qualcomm.com> <2e38b9f3-8a35-4a27-82d3-c1d4996a1684@oss.qualcomm.com> <9ecf4783-e1a2-430b-a889-997689bafe45@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/12/2025 19:36, Vijay Kumar Tumati wrote: > > On 12/10/2025 11:25 AM, Dmitry Baryshkov wrote: >> On Wed, Dec 10, 2025 at 09:50:51AM -0800, Vijay Kumar Tumati wrote: >>> On 12/8/2025 3:21 PM, Vijay Kumar Tumati wrote: >>>> On 12/8/2025 2:48 PM, Dmitry Baryshkov wrote: >>>>> On Mon, Dec 08, 2025 at 01:03:06PM -0800, Vijay Kumar Tumati wrote: >>>>>> On 12/8/2025 11:53 AM, Dmitry Baryshkov wrote: >>>>>>>> +  interconnects: >>>>>>>> +    maxItems: 4 >>>>>>>> + >>>>>>>> +  interconnect-names: >>>>>>>> +    items: >>>>>>>> +      - const: ahb >>>>>>>> +      - const: hf_mnoc >>>>>>>> +      - const: sf_icp_mnoc >>>>>>>> +      - const: sf_mnoc >>>>>>> You know... Failure to look around is a sin. What are the names of >>>>>>> interconnects used by other devices? What do they actually describe? >>>>>>> >>>>>>> This is an absolute NAK. >>>>>> Please feel free to correct me here but, a couple things. >>>>>> >>>>>> 1. This is consistent with >>>>>> Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml. no? >>>>> I see that nobody noticed an issue with Agatti, Lemans and Monaco >>>>> bindings (Krzysztof?) >>>>> >>>>> Usually interconnect names describe the blocks that are connected. >>>>> Here >>>>> are the top results of a quick git grep of interconnect names through >>>>> arch/arm64/dts/qcom: >>>>> >>>>>       729 "qup-core", >>>>>       717 "qup-config", >>>>>       457 "qup-memory", >>>>>        41 "usb-ddr", >>>>>        41 "apps-usb", >>>>>        39 "pcie-mem", >>>>>        39 "cpu-pcie", >>>>>        28 "sdhc-ddr", >>>>>        28 "cpu-sdhc", >>>>>        28 "cpu-cfg", >>>>>        24 "mdp0-mem", >>>>>        17 "memory", >>>>>        14 "ufs-ddr", >>>>>        14 "mdp1-mem", >>>>>        14 "cpu-ufs", >>>>>        13 "video-mem", >>>>>        13 "gfx-mem", >>>>> >>>>> I hope this gives you a pointer on how to name the interconnects. >>>>> >>>>>> 2. If you are referring to some other targets that use, "cam_" >>>>>> prefix, we >>>>>> may not need that , isn't it? If we look at these interconnects >>>>>> from camera >>>>>> side, as you advised for other things like this? >>>>> See above. >>>> I see, so the names cam-cfg, cam-hf-mem, cam-sf-mem, cam-sf-icp-mem >>>> should be ok? >>>> >>>> Or the other option, go exactly like >>>> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml. >>>> >>>> What would you advise? >>>> >>> To keep it consistent with the previous generations and still >>> represent the >>> block name, we will go ahead with the style in qcom,sc8280xp- >>> camss.yaml. If >>> anyone has any concerns, please do let us know. >> Krzysztof, Bryan, your opinion? My preference would be to start using >> sensible names, but I wouldn't enforce that. >> >>>>>>>> + >>>>>>>> +  iommus: >>>>>>>> +    items: >>>>>>>> +      - description: VFE non-protected stream >>>>>>>> +      - description: ICP0 shared stream >>>>>>>> +      - description: ICP1 shared stream >>>>>>>> +      - description: IPE CDM non-protected stream >>>>>>>> +      - description: IPE non-protected stream >>>>>>>> +      - description: JPEG non-protected stream >>>>>>>> +      - description: OFE CDM non-protected stream >>>>>>>> +      - description: OFE non-protected stream >>>>>>>> +      - description: VFE / VFE Lite CDM non-protected stream >>>>>>> This will map all IOMMUs to the same domain. Are you sure that >>>>>>> this is >>>>>>> what we want? Or do we wait for iommu-maps to be fixed? >>> Yes, when it is available, we can start using iommu-maps to create >>> separate >>> context banks. >> It would be necessary to justify removing items from the list. Wouldn't >> it be better to map only necessary SIDs now and add other later once we >> have iommu-maps? > I will let Bryan take the call on this. He was the one who wanted all > the SIDs in the bindings. Hi @Bryan, if you can kindly share your > thoughts on this and the interconnect naming, we will go ahead and push > rev 10 for this. I believe we have taken care of other things. Thank you. >> Since when are we delaying patches for future patches that may land never ? I'm fine with whatever clock name changes you can agree with Krzysztof but it seems a bit ironic to me to be given feedback to "align with previous dts" to then have the result be further change. I'd like a bit of stability and consistency TBH. --- bod