From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF8A33CE84 for ; Fri, 21 Nov 2025 13:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763730555; cv=none; b=PMld+mfxbwcMscWzMJrJPafT3pUYburcxRYpC9nPqDqLk4qKqW2InSMZVIHp4pm78+xQoxy61Ce0berbzssZ/bSdiKgoaCMyXeVTl6ASxEH3w2XduENlJOBwxprKxzmtQd9h4rvVhajH46kvZllHUc1fCiK8WDgE5W/IGeAkt8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763730555; c=relaxed/simple; bh=1kNZgnokdRlI7YTTKd52iZEubsDvhWy0QKNmrWwpJ0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uUih/67X/EZEQVpWPYvTggGc+1y/cnsbOVH/sgQNKEjxalUeEi3CD77KvnX9PUwqxro7o8XKsy4SZ1ETKcvhvr/vU3+kV3eq9lbT8+0951yR79zxVkr+C8Aa/A8OuKMkbMfQuN3sBDEJ/3gq7eR1yIEmn8PZ+Hest2ug+4GGDD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PKjI11Lb; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PKjI11Lb" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47795f6f5c0so13372825e9.1 for ; Fri, 21 Nov 2025 05:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763730550; x=1764335350; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hFMlwqCTPV6LgIow9qjui4+mkS7CwcvLdBw7Wz/wxII=; b=PKjI11Lbrao9/q+EcF7/R7iUe8qWdbKJNnC/ybSwz5qdmI+RvwYrhqZAoeIhPfiiMF ENImnchXnLvtvMP2iKHnD56l+rnFYcZfbF2b6IiGxUWdNHFeOSlyF2Yz8Sn7IMHw0dIA KCsZNpSlkX/W0BO8CFQ/QYTSOuman4vCRJMheQbhqMPpiSp1/S5N9FdtHXvE5ADz1tUi QjikZZeFyHrvx2t5DIDt4wM9dOqdhWV5VH7FftJqhEXu3ArwIwwX8sO+c/98rk54G2vC 4nY/bRaBNcNLPLgwzbioUacR6sSArROqJZWMaxnqmg/Tb9xMo+rJjFnsARCvkf9m1WKs 8VAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763730550; x=1764335350; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hFMlwqCTPV6LgIow9qjui4+mkS7CwcvLdBw7Wz/wxII=; b=c7WTBiDy1/UH67B/QKWbEaUJfFKTWesJmDhFNLja3ME/XZtT+U9dhs1LEwX6xS6uwt KyHz21TbLp/Kf5tlqtZmn+d3RR72A+G5Lkpg0B1JnVK4pGpE2udzb5RFM2DzjaNqEg4s LCxoDPc5a1kCyPuONg48umkyHBxhJQ21YnNxWoS2TyBUbD13Tdossv+USMGJw5gxEemg 1U9Aif43iaPr+3eET8dt8oBaiQJOAc8LasUK11CA4rpUkLJp4fNUADtBH9cnsXivUYn3 DdG8O3FT2bcjrMFgDhMUjJjoAzwxlFe08KhnzTF2J+BTcx4sYjSEeSJWjkf3a5oIXePq 6R4w== X-Forwarded-Encrypted: i=1; AJvYcCWuuWKZW+56iZ2id+FVtuax+PVGFNIeQPXp5kKLHDUuap4/0YJ4YTtrojpm3h2jXBjm3lPFQgweIYAO/Zk=@vger.kernel.org X-Gm-Message-State: AOJu0YyPa5lYSHB2edu+BibZlKMkpxmu4w6XnmTPgYgE+0AhVm6zWEQL coNlSVWSOGSUya76sV+b8JG3sFcYos0+ollk5HnnGatANuUCGCyJn2z/ X-Gm-Gg: ASbGnctZOPCEMCOJ1YvltiNcs/t5Cc+OokNFYgfqi0Hi8bdQnOaEvKBvnGLelJonYYc R3RpapujuwHo8xQeB3STrnFd44WpvjpTPYvUqN+0yJNM4qJEdj2YrYP757t2JQuDoaLIqR1furE pKT8b2ta3WkbgHtv86DS9UN1oP2+U5kbXotL/PoFLerBff/0V7cla8tiaxfDNWTgA5eUnHJjIkL f4qHXbVaeKtADkd2oWtmzrx4OmaBVuKAcBHWtPaCLHGvIyJDDCEAr7Sidi0++RsVNfvjLe78UOx I3Mh8n3yLhvE3PZjXVMbTbesB6myfdLr8gIwUNyQNiQXrz+0nAMfYC29wUGC+dQAtuQ2Kc9w2Vg XkO2d5JuImHS+Aq0ayQwzJ6bWkyXchRcAkkaCfMcNxMW/Csqc4mwTjZJOpjHk3weNubaW6eNb/s 8Y9GIiw+WRZO3C9R7Zi9HlwBnkYaD43UEXfYHHFrtJIfK5OUfHcD+6vk4kTClBMNGuuItr0rhQQ xW0JlA07/A2G6IXx1aitBHzsVPla4Vl4Gmwyrg2sYfp6O/ad3EANMtVb5UlbHKe X-Google-Smtp-Source: AGHT+IHoItNRpoCOBTJdnxOZ5STshksMTUe0MQdPOU8mrz4QGa20rK1RibgJCBzaf5gs5Q0f4HIW/w== X-Received: by 2002:a05:600c:1994:b0:477:5aaa:57a6 with SMTP id 5b1f17b1804b1-477c016e402mr21494025e9.10.1763730550006; Fri, 21 Nov 2025 05:09:10 -0800 (PST) Received: from ?IPV6:2003:ea:8f20:6900:2d1a:1f47:fba3:71e8? (p200300ea8f2069002d1a1f47fba371e8.dip0.t-ipconnect.de. [2003:ea:8f20:6900:2d1a:1f47:fba3:71e8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3aef57sm40152705e9.11.2025.11.21.05.09.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 05:09:09 -0800 (PST) Message-ID: <1ca0e3ed-faab-4203-be4e-9998d6d2b7ad@gmail.com> Date: Fri, 21 Nov 2025 14:09:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] r8169: add support for RTL8127ATF To: Fabio Baltieri Cc: Michael Zimmermann , Andrew Lunn , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <89298d49-d85f-4dfd-954c-f8ca9b47f386@lunn.ch> <22b15123-b134-467c-835c-c9e0f1e19e29@gmail.com> Content-Language: en-US From: Heiner Kallweit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/21/2025 1:09 PM, Fabio Baltieri wrote: > On Fri, Nov 21, 2025 at 12:17:33AM +0100, Heiner Kallweit wrote: >> Could you please test whether the following fixes the chip hang on suspend / shutdown? >> >> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c >> index de304d1eb..97dbe8f89 100644 >> --- a/drivers/net/ethernet/realtek/r8169_main.c >> +++ b/drivers/net/ethernet/realtek/r8169_main.c >> @@ -1517,11 +1517,20 @@ static enum rtl_dash_type rtl_get_dash_type(struct rtl8169_private *tp) >> >> static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable) >> { >> - if (tp->mac_version >= RTL_GIGA_MAC_VER_25 && >> - tp->mac_version != RTL_GIGA_MAC_VER_28 && >> - tp->mac_version != RTL_GIGA_MAC_VER_31 && >> - tp->mac_version != RTL_GIGA_MAC_VER_38) >> - r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, !enable); >> + switch (tp->mac_version) { >> + case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_24: >> + case RTL_GIGA_MAC_VER_28: >> + case RTL_GIGA_MAC_VER_31: >> + case RTL_GIGA_MAC_VER_38: >> + break; >> + case RTL_GIGA_MAC_VER_80: >> + r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, true); >> + break; >> + default: >> + r8169_mod_reg8_cond(tp, PMCH, D3HOT_NO_PLL_DOWN, true); >> + r8169_mod_reg8_cond(tp, PMCH, D3COLD_NO_PLL_DOWN, !enable); >> + break; >> + } >> } >> >> static void rtl_reset_packet_filter(struct rtl8169_private *tp) > > Yes, patched it in and tested on both suspend and reboot without > touching the wol flags, seems to be working correctly. > Great, thanks for the feedback! > Thanks!