From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAE216132A for ; Wed, 11 Mar 2026 13:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234233; cv=none; b=myreIJ5MBKGj3TxFPdZcEy4NwZSg3yxS8oGiH9RGo2VsfmxDEpjBQiTE0IT8r3trF+JVqeDOzkZKAeBaIVp2JzOFVZrvx/IoC47h+ADHqTAYvJKKtZ0HJjuHJuiChqPLGcYIUOJcmWb/YhTFqohEEGqFlxHgzM/nyxOL73mqc4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234233; c=relaxed/simple; bh=5+J5TqAqGh8ioSYxiauKGxtDEKPjcO3n849+lga00bo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V7lwKa0kb9UOYGJO91Tg7Sp2W66hqarBH8ITakQwOV0IIlgC93U0zjkJ23Pq/hN89R+uN5pjZxu/g6hw2pyw9Jo/dXp5O8v91MS9N+LHD/FHqYOwdgcvf6qXRZ9xzjEwkN8NfkHxfED4hir5Qw6/IFk0zHzuChlbr6uuD4Ph9LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=erU2gEXV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dfSDM6aT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="erU2gEXV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dfSDM6aT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BAvEiA2622228 for ; Wed, 11 Mar 2026 13:03:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d4VhR4c9gk4ZiGswHq6GTZO8dxybDlutZ+rs5ZkA/LE=; b=erU2gEXVebghbm+o 2GZccEX2u8Xd+E01hdidrZUuxAaH1uY63xkyHo82CZ97lHfDsKlxneBid2PUBik3 o1TJTdTA+S1oJGAHR7BHq6XrH6dQQuLOLeK1deIYeoLbPlHjbdUcTjtbNBS3plFX kru2dm+0IKJa89gVM7IuNasdPaKKo0FbKB+fS7SDUbnnsNYvlnLgLU71vtRIqaEG +hctJroMVOeqCUUSi0tnxA8566PjsvE8drEHktiljxb9f20LYs4MDy/Cv92+W0q1 uFhOZP4wOZgOKzcv8HMxyQBgQHj6d7rlWOYm8Po2Q3pIrZRtBBA4XdtvVfuo2l6O 7fukUA== Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu73h0d0t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 13:03:52 +0000 (GMT) Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-417014a1276so4494126fac.2 for ; Wed, 11 Mar 2026 06:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773234231; x=1773839031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d4VhR4c9gk4ZiGswHq6GTZO8dxybDlutZ+rs5ZkA/LE=; b=dfSDM6aTDjDV30MY1vJUTbE1t9x6K8aO3Vc625mWfqcD9M38AqbUQ6/YjubvmAM+uv jb3NAw9WGh5To9W16TfQBDJ9QmmKRGdFANNINUXRv4CK3QhoBK7JlsHEekkqJFaKvP+k OoxPINjLZ8nFcZCYdgWWe7VQk9VMPK021xgcUEbAW+OUV7JHAysqnMfFzYm4iotdl5/R fNREX3pxeClM3Yl+A+TJfK7mg9Gspz1/khBbAXmmDBw5a8y0klbJCpY4pqe1VGCkR/fI fNqvWOc/7OTZslURvAXrMtcTTH6ZVJwmIjegfz+8yRFBvqJ60iwiNPRyGKAkPK9JaPKY dRNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773234231; x=1773839031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d4VhR4c9gk4ZiGswHq6GTZO8dxybDlutZ+rs5ZkA/LE=; b=dKI+EovVHg/ZBZL8eR4A5M+7ELFrxOCOFS/FDdI6W2AxwHdhW2xOQRbEeAj/EdmNgo DcIYTDLclVy1tAqG2HUG7TI3gf5cRK8TnRP+84Awxfoa3b+qxNi9iSPQAQYex5DYWbGy gSqL+YiMNadvnL9OpblgWixsEbNpbL1ZRDAQ+ZTQIhfInN73bDatgKllQ34wmB3hB1J5 b3OIhhRFyK36v4ss0YuRfm3TW1xNSoxsClzKsm2YLU9HroZzWjE7vIYN311QFR9xdcmm n8BjKSB2Yy4RgbhGVMHAozQuHoNtkUZL5lfZLPOmL5CRYSF2o6s7UJY6ba7yokWSq4LL kHSg== X-Forwarded-Encrypted: i=1; AJvYcCWzF8OrVDFCO0x5CczCt9l/cUNeZqwzVgDSVmmr5krJGDJ9g4xBh+ZrdTNa1dMmCSzRdio+4tRpDdbEua0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3iTJ3resCSW7IsZptkmzTXF1EvPSkcWouh/vOxua1v6dc4KE/ XJhTk54mkvm5npCjgiHuTxI97uUtNRZMn+oe6CgOPUxse23KT4WhPZwnWCwlPp4xh1LVLvSrMnw Qw5HZSoJv1/C2yFfPvMxZDu0rKjV/aSlHdksJbZKy11gqT60fuolaTkY9QDt/WES6OGQ= X-Gm-Gg: ATEYQzzP7xVgwN4SV/50/3clrhSFAhI6xA+/vNGilWCG/OQjEw4kMdU7c1unfGj8pnK kXV7B20kojN4J190bucYgCmmpvx2o/NUAleLcPqFIW3KJwAdVgHwYnd1dA9T+E3277ok9307uct afw2gSqcFzGsxUgRqvMv/ChYG2PCcD1j6ue5z49AL4WCCvdMale+pK1T3MwnSg4WaZ0wT6oQslZ CyDBqDVAY8o834QqWDUQe40RtVlsNhQ7c4lMYKxvLR/sinJYOm+SbJ5NxPIG5nf9tVZ5PiViICo yKteH/INnfnLVmlJaNsuxkuoRBLgpCQ8tAKwyIjMrYmZ8PND2WQd1JbYGZ7ESd8sAfPNP/RLHgv KXhLSwxr6YSgkMgZ0RQG9m4peoinL9Hah296vAxJq/caZD9y/K8Y6MJaFMws5+WLZWskVftKJS1 wQ+Ns= X-Received: by 2002:a05:6870:678d:b0:414:b05f:1ce2 with SMTP id 586e51a60fabf-4177c9a7bb6mr1147767fac.5.1773234230707; Wed, 11 Mar 2026 06:03:50 -0700 (PDT) X-Received: by 2002:a05:6870:678d:b0:414:b05f:1ce2 with SMTP id 586e51a60fabf-4177c9a7bb6mr1147705fac.5.1773234229627; Wed, 11 Mar 2026 06:03:49 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b972de5684bsm54177566b.23.2026.03.11.06.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 06:03:48 -0700 (PDT) Message-ID: <1ca4cdaf-d8f7-43c5-9087-b0394036c461@oss.qualcomm.com> Date: Wed, 11 Mar 2026 14:03:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen To: cristian_ci Cc: Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-5-aa2c330572c0@protonmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: pfUweH4eaFCxVWT2plLTnww95wcZXmjc X-Authority-Analysis: v=2.4 cv=T7uBjvKQ c=1 sm=1 tr=0 ts=69b16838 cx=c_pps a=Z3eh007fzM5o9awBa1HkYQ==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=sfOm8-O8AAAA:8 a=ZEhHOJAMJ-b77FbnAkkA:9 a=QEXdDO2ut3YA:10 a=eBU8X_Hb5SQ8N-bgNfv4:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-GUID: pfUweH4eaFCxVWT2plLTnww95wcZXmjc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDExMCBTYWx0ZWRfX8hIyS8ROj3lg BfASHnKg7yR2SNtreeX09FYu+/v+b4Jd6O7+F+uFcGKKgCtUrb35E8QvlRZBJBBfA6i45LU4IWA 6S2PKnzcBLuRoB4ifvTwMvSNnzQTkqMkn2QSOtkjLRHPIJ9N+rA/2V8I4awgVR3WbGjC6fh1A99 d06bT3RVspJliLmbKPJvAhnPmFsa6VEUeFS87Ddur0O7/Cjn1PsEY9OjE6WpNUHmJoUQ2e4Xjhl j9MzqqFZqUcGb/oFkObIyGdBghHyYBJ8HkutGvkW2w/vhcnHWNoLuBKvOWh+Dfv2cJUYX6NgCOF 3Iuc5V2ZWNgEwM9IUrCpbVP3syj7kWMkobQs1R0VpFPWqL9F0E4s9YPlHA2iSaVG7rCdwZM1t01 ipmLfOm8l7LgPkUO7CdyojvRPA6L8FlR+xHj6udV2lpFSpipVElPsI91DXF8qbkxkoJkcEU1D4s ychKAOfA1z4G+QT8bGQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110110 On 3/10/26 5:20 PM, cristian_ci wrote: > > > > > Cristian > > Sent with Proton Mail secure email. > > On Tuesday, March 10th, 2026 at 14:08, Konrad Dybcio wrote: > >> On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: >>> From: Cristian Cozzolino >>> >>> This device uses a Goodix GT5688 touch controller, connected to i2c_3. >>> Add it to the device tree. >>> >>> Signed-off-by: Cristian Cozzolino >>> --- >>> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> index 7b2849405462..709ea6fc9fbb 100644 >>> --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> @@ -94,6 +94,31 @@ &hsusb_phy { >>> status = "okay"; >>> }; >>> >>> +&i2c_3 { >>> + status = "okay"; >>> + >>> + touchscreen@5d { >>> + compatible = "goodix,gt5688"; >>> + reg = <0x5d>; >>> + >>> + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; >> >> interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't >> even consume the former. Trying to read through some of that, I think >> it's on purpose since the IRQ GPIO is repurposed for setting the I2C addr >> (which nota bene doesn't match between the comment in that driver and this >> submission - perhaps that's just a SKU difference) during the reset >> sequence >> >> i.e., does the touch work any different if you drop the above? > > Apparently, not. That works as expected. > >> does /proc/interrupts differ? > > When interrupts-extended is defined: > > ... > 50: 318 0 0 0 0 0 0 0 msmgpio 65 Edge gt5688 > ... > 54: 3141 0 0 0 0 0 0 0 GIC-0 65 Level gpu-irq > ... > > Instead, when interrupts-extended is removed/commented out, I see just: > > ... > 53: 2404 0 0 0 0 0 0 0 GIC-0 65 Level gpu-irq > ... Hm, that's odd - I don't see the irq handler being registered anywhere, or anything requesting that name. Do you have out-of-tree changes to that driver? Konrad