From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893CB218ADE for ; Fri, 25 Apr 2025 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745595805; cv=none; b=XVFRBx5kmbsA0SK3SIcE2/gOlWX3y2CTQfQprb14adPXH4cJaB3SElBpy6ypXhnXc9ytV3u5SQ5aTkZdg/RFV9mukl/dDAUKrMy3SqfG2oCUMpVukO7ukStbGLLHku947UVSEBesX/yoy9MGFvPcmgeFft8F7/XGeXFv4Eyy8Jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745595805; c=relaxed/simple; bh=QE61Ro96QLMT2qJnDn34ofb5m722rFs5Cd7Vq0A5ElU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DtiiOshkBNmjxCpPc9AgcOIK1Mq0xmBFZdWMwB/7H25s6BLhubcCeqQS+rxV9vJuLdxIv3/JgMRoV3wGUcAYSPm1gB3GTMLKXam57i/qGs7NdrjeEC1YHsWKZGXUvUh+l+HMeaofrSmySXaApEhoGVbSLH1f+vtuLrFLEk3WiTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=U5vAHlb8; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="U5vAHlb8" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-604ad0347f5so616537eaf.2 for ; Fri, 25 Apr 2025 08:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745595802; x=1746200602; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u9pUe4E3ZeR1aU2CkECeBsvEMz+lXgJJoqB01YM8ajs=; b=U5vAHlb84BgCSpvy98UeQlFZtN9QgGg1xFTFYC0u4sY9hi9qwE45pGVrpgjl+f3vQW xPoJiRQNM6T/s3zwanahtIIXQal0mKPH3QsDVx4J/3RWbOkz8CLGMNX3/zUjnUteVYTu Rk6b9gxepK/kjH5zPfjLJoDMFDYLb8fQ7WKDgIoBAmd654lJKWGDw1+vJ2bruWgKI1lX yK03i9q5W+YFGbel/kZ4+dUNZoWiW7rBUp6ZBJ/dDx31nLNgrq/kF0iBWXco561CZOD9 55zTL316NyEXaIwPnPX4Isj0v1MAjKSrH0hXELgGTVxZnbrgIWHNxKT/lfnrdT+s292c UVqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745595802; x=1746200602; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u9pUe4E3ZeR1aU2CkECeBsvEMz+lXgJJoqB01YM8ajs=; b=kH65BC3UWDEXBZUF+wvkreq5qlxJ4Rjt0ZRhJN8O3wb0Cq4TDtmzG3DXOh2x3PYRPR so4QI3R089E7SGiwPSdrI3U+hri14m276LFGyW50PG/yj3ZCFzgvih4heTZudV2zNIPC HP5C2tF7TTk6WRdcbtzKyyYHCSxArp5Hysm04IB8Dib4JI+9NNGbQ1EeCYUHYWp8peVh /iSZ/D2U2YQcWiQ+mifK8TJIqn9nhnHXhiUKmXzivQAex1qlf/Zui/71jgrp9IrOJvLL udyiXkQB0YyDiTT5mZBjOQAA7qq//QtMwy2Qkt0q60JZmhnCmNCmp0Gguxekgj+fz91/ B6UA== X-Forwarded-Encrypted: i=1; AJvYcCUoZAuWF8TbiU61f9UUdhlX9W9xyyM2ySvlVOV+L5NVWb8lNf4CmikdmHKCKWaARnTqFpexucVTS0nk/Fw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyg2sR1Sis01X0YBfKDC3vyv1s9AYGY4kqVoZM0G7XX1NacKirP JSKiJK4JA6YSZKJ1YlAWPxbbKa7q4WVKw2aFke9vcZPXLCAcAoiug16NdB7XHLo= X-Gm-Gg: ASbGncsMsA/GCQd2HTE5rJEZ2ii9/PLbWm3+4wMmU1jLz6fNST/ZgBikP7OaFCPhiIB PkDH65V1EwzWnFGz5mffHrmgtdXW/45o/H/NL1Abtx5kd8J1pXM1fUBP5PcrnJKJU69mJ8A5DcV sk6QduGuUbufUbk0xwkHcLH1NAoAnomLHvVV8GPjufvgBCUPZKzyGykGhghxnaEAcPQWjgSQ0aT 6biuPwpIIjEtbQzpMK2ZhhLoiymRDO5nGVZPeKYl6i9ZT9gDF6Dn1CqfhIWgrYrxHix/lNe6eaq bnxyC5TNVnZ14EmlSuUcw9t5DO+x/3WoEnkYVr4FfEb+L8NN71khankPG4R/RiVz/u8ow2KWs5L LPqeqJlABp1TkdQA6G0mZbTM= X-Google-Smtp-Source: AGHT+IG/OtumwHC5swR6H2CFdXfQSy0Vcju9xSNeHVTBb4FxeQPAdHgsFE9XEjfhMfsokIExnHiTUw== X-Received: by 2002:a05:6820:2007:b0:603:fada:ac53 with SMTP id 006d021491bc7-60652bb3eb1mr1259572eaf.2.1745595802424; Fri, 25 Apr 2025 08:43:22 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:96a3:e28:3f6:dbac? ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-60646882771sm776192eaf.14.2025.04.25.08.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 08:43:21 -0700 (PDT) Message-ID: <1ca81b41-f3a2-49a0-ae91-72fb068bb0d5@baylibre.com> Date: Fri, 25 Apr 2025 10:43:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/1] iio: adc: ad7192: Refactor filter config To: Alisa-Dariana Roman , Jonathan Cameron , Alisa-Dariana Roman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko References: <20250425132051.6154-1-alisa.roman@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250425132051.6154-1-alisa.roman@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/25/25 8:20 AM, Alisa-Dariana Roman wrote: > Dear maintainers, > > Here is a pretty voluminous patch improving the filter setup for AD7192 > and similar chips. > > I removed the write options for two attributes and I know that is > questionable. I am sending this version just in case it is still viable > since I think the driver is a lot cleaner like this. If you can make the case that no one is using them, e.g. because the function didn't work correctly, then it could be OK. But best not to break userspace if we can help it. For IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY, it seems easy enough to keep ad7192_set_3db_filter_freq() and just modify it a bit to call the new ad7192_set_filter_mode() with the 4 previously supported filter types. And IIO_CHAN_INFO_OVERSAMPLING_RATIO seems like it could be preserved too, but will take a bit more work. I'll comment more in the patch. > > I also modified the size of the 3db filter low pass available attribute > since AD7193/AD7194 have 16 filter modes, unlike the other chips that > have 4. > > Note that I moved a few of the functions around to be able to use them > where needed. > > Have a great weekend! > > Kind regards, > Alisa-Dariana Roman. >