From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB9FC41514 for ; Mon, 2 Sep 2019 14:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E7F21744 for ; Mon, 2 Sep 2019 14:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731363AbfIBOWl (ORCPT ); Mon, 2 Sep 2019 10:22:41 -0400 Received: from foss.arm.com ([217.140.110.172]:55554 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbfIBOWk (ORCPT ); Mon, 2 Sep 2019 10:22:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F1B4E337; Mon, 2 Sep 2019 07:22:39 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79FF43F59C; Mon, 2 Sep 2019 07:22:37 -0700 (PDT) Subject: Re: [PATCH 2/2] iommu: dma: Use of_iommu_get_resv_regions() To: Thierry Reding , Joerg Roedel Cc: Rob Herring , Frank Rowand , Will Deacon , iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190829111407.17191-1-thierry.reding@gmail.com> <20190829111407.17191-3-thierry.reding@gmail.com> From: Robin Murphy Message-ID: <1caeaaa0-c5aa-b630-6d42-055b26764f40@arm.com> Date: Mon, 2 Sep 2019 15:22:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190829111407.17191-3-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/08/2019 12:14, Thierry Reding wrote: > From: Thierry Reding > > For device tree nodes, use the standard of_iommu_get_resv_regions() > implementation to obtain the reserved memory regions associated with a > device. This covers the window between iommu_probe_device() setting up a default domain and the device's driver finally probing and taking control, but iommu_probe_device() represents the point that the IOMMU driver first knows about this device - there's still a window from whenever the IOMMU driver itself probed up to here where the "unidentified" traffic may have already been disrupted. Some IOMMU drivers have no option but to make the necessary configuration during their own probe routine, at which point a struct device for the display/etc. endpoint may not even exist yet. Robin. > Cc: Rob Herring > Cc: Frank Rowand > Cc: devicetree@vger.kernel.org > Signed-off-by: Thierry Reding > --- > drivers/iommu/dma-iommu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > index de68b4a02aea..31d48e55ab55 100644 > --- a/drivers/iommu/dma-iommu.c > +++ b/drivers/iommu/dma-iommu.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -164,6 +165,8 @@ void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list) > if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode)) > iort_iommu_msi_get_resv_regions(dev, list); > > + if (dev->of_node) > + of_iommu_get_resv_regions(dev, list); > } > EXPORT_SYMBOL(iommu_dma_get_resv_regions); > >