From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: Myeonghun Pak <mhun512@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] bus: mhi: host: Shut down the health check timer on removal
Date: Fri, 30 Oct 2026 10:24:24 -0600 [thread overview]
Message-ID: <1cb4d497-73b7-4148-ae40-259c57bbda4b@oss.qualcomm.com> (raw)
In-Reply-To: <20261011185134.1759331-1-mhun512@gmail.com>
On 10/11/2026 12:51 PM, Myeonghun Pak wrote:
> The recovery worker rearms health_check_timer after a successful device
> recovery. Deleting the timer before cancel_work_sync() does not prevent
> an already running recovery worker from adding it again while removal
> waits for that worker. The timer can then run after the controller and
> the managed mhi_pci_device have been released.
>
> Use timer_shutdown_sync() before cancelling recovery_work. This waits for
> the timer callback and rejects subsequent rearming, including rearming
> by the worker being cancelled. Keep the reversible timer deletion used
> by suspend and reset paths.
>
> This issue was found by static analysis.
>
> Fixes: 8562d4fe34a3 ("mhi: pci_generic: Add health-check")
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
prev parent reply other threads:[~2026-10-30 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 18:51 Myeonghun Pak
2026-10-30 16:24 ` Jeff Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb4d497-73b7-4148-ae40-259c57bbda4b@oss.qualcomm.com \
--to=jeff.hugo@oss.qualcomm.com \
--cc=ae878000@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=mhun512@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®