From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E46B01E2310 for ; Mon, 20 Jan 2025 13:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381423; cv=none; b=YyPecG7GgRcvaSvSomfqkorm7Ex6pZdcUvbGILUZcoADVQfMNB5Y2Fz6c3Dd4orrPbgJkSCDLbjVtgL8RZO3+swfwzWmmqL2l2Hok6XJ7VWiUesKgcbnLjRQwVcANcEZEWVSAyxGBNOhrZNcs7ONdJ7i4P9NdWFmR5IZnbdLxFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381423; c=relaxed/simple; bh=0CSPqYQeU/YoY9UYAveHkKIK93lbpHcFP9huHOUCHNs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ldSC2rdMeBb7sMiBHkA3pmzKhtmL+vUrpsOMWXWXfSDN5P8mLTDpfkmHUiUWdWZa5FIH/+3ol6F/yWPl1Lqd3pHRrz0UueWjnzmmS29OG82aldYyNFC/T+OrPMZMEZTXgoCEoa/Do8A6OlJIolBR+OGx8uF81MWnPxZwNss+p5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YzrJaScC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YzrJaScC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737381420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcyithpCUM94o5b1nFPf/poYAlKB7Tn/nU0i8Lo+l7s=; b=YzrJaScC3EIB5G+ltmhgrACG6oVOJ4UrP3uEALrVmao/D8viJP3iHlbrKX1lb3z4L5lV+t D6o+UIebL/bnYgKbIwlYdi2xrh/tt7dyHxi5fFL9EWsDExO2x/ZMgpSUMr/9EhuVrN8qJA TOq0u4rUQQZh36RjGstY5X7VY4MZTt4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-NKennvMCPqmL8BihY4o7Jg-1; Mon, 20 Jan 2025 08:56:59 -0500 X-MC-Unique: NKennvMCPqmL8BihY4o7Jg-1 X-Mimecast-MFC-AGG-ID: NKennvMCPqmL8BihY4o7Jg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361f371908so34423725e9.0 for ; Mon, 20 Jan 2025 05:56:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737381418; x=1737986218; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qcyithpCUM94o5b1nFPf/poYAlKB7Tn/nU0i8Lo+l7s=; b=c5NNtSxzLLLY7u0LTa+6wytUrARaCIbjtwNcV8GE0CM+qWxfjzcqjc4kFK+ZJu7F0s NxQwNQk85aH7AA+PJiXaahV8tMkwbAviqUEeWhKXWnf4hXFFXW4+FrSYbvGeAMRJTwdw zEV+c8ZqNZcHjS0EG8SWn9VInpUMeQ1TuqWZ4TCRQ7k3uBXFdaIsuLm7chVxsXB1EW/+ PNUMcBK7iPNEshGnH+7USanZRoaDPHz2BVMtM4tqVtPfRjqTUGjrA06SMlcPg+4aHnXZ yWibMSYwz9k0wCsDqEhNNliY94dftO8EmmRwTNJNZ6btPc6st3qAkSTapdLZnSSw0ziZ Y54g== X-Forwarded-Encrypted: i=1; AJvYcCXtR+dTNP/urVZ7coV9HYrpmD4G8ciwzrSC9+wPoeN7HhvTGGJ7YqZXLmCQJ6sLJ4Qe9EWUE8KUDgUcHFM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+7TYjccvFqdYg35YT+72D0N8CPdGkY5JnujyRske8uwQC0DXU ZqvxbCZwzfYsoEH747jY4LvapwLZyjb0YICFDLYrKQVwF700SksOlUfHqFPeBXVU+mUk6Y2GRb9 3/s8cXAy0HEH71VRPFphehaAI8ljWF4+2X/GB8c3a2tcUXGn3SUHGUj1A75Rpcw== X-Gm-Gg: ASbGncuUBz8v0ogezMPdlPaZfvH1QEzguJa20DJ7+PcCFw0L/v1jIAYQrOIhTNzsLWW GCDXuHdwMDfoUMxKvAop+MTtOAYyGPZTjxztiSvfsCHP9+uuFwjLkx+7Y9bWJVL/rf/iVz8B0NA tBV2GU5PzkH2XEoqJj7jWfE5Kp1oPNHCmzIS7vCRuJnmJLAGwGQJBhpsItmH/5rAuXysajzPQS7 eBWqKjL5sSYb0/8Ac27OO9dJ1RUi0387YHgw6uRyggLwQ1wNFuj0dTWxSo5A9VVE4JdO/Q86c7f E5+OZmwiTwVqPwkMFcy8HGv5VgJKjxunTG+8oyrAXotxVpkd0qv/jJTq4TIzjGWt5tweOBNxw3u KP9Ygq8oFN/7AWOUDKSsNew== X-Received: by 2002:a05:600c:ccc:b0:434:e9ee:c3d with SMTP id 5b1f17b1804b1-4389141c1e5mr105763745e9.20.1737381418384; Mon, 20 Jan 2025 05:56:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEk02cCvArGo1Q4FqvnvoIJ+fAu74VhEDW/L5RQpOBRXRb8y7p/q+2lGXTdU8pdc5rpappM2w== X-Received: by 2002:a05:600c:ccc:b0:434:e9ee:c3d with SMTP id 5b1f17b1804b1-4389141c1e5mr105763545e9.20.1737381418046; Mon, 20 Jan 2025 05:56:58 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b5asm10378195f8f.21.2025.01.20.05.56.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 05:56:56 -0800 (PST) Message-ID: <1cbd3b3d-48b7-42b0-88e1-a9316e4acc53@redhat.com> Date: Mon, 20 Jan 2025 14:56:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/1] mm/madvise: fail MADV_PAGEOUT on VM_DROPPABLE VMA To: Lance Yang , Lorenzo Stoakes Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang References: <20250120013038.6657-1-ioworker0@gmail.com> <04d81e18-c206-40f3-b469-5ea588d4bf8e@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20.01.25 14:47, Lance Yang wrote: > Hi Barry, David and Lorenzo, > > Thanks a lot for taking time to review! > > On Mon, Jan 20, 2025 at 6:45 PM Lorenzo Stoakes > wrote: >> >> Sorry but NACK again on this :( >> >> On Mon, Jan 20, 2025 at 09:30:38AM +0800, Lance Yang wrote: >>> MADV_PAGEOUT should fail on VMAs with the VM_DROPPABLE flag. While >>> MADV_PAGEOUT is intended to move anonymous pages to swap, VM_DROPPABLE >>> should not be swapped out. >>> >>> There is an issue where using MADV_PAGEOUT on a VMA with the VM_DROPPABLE >>> flag behaves like MADV_DONTNEED, causing the pages to be dropped. This >>> could break the semantics of MADV_PAGEOUT, IMO. >>> >>> So, let's add a check to detect the VM_DROPPABLE flag before doing >>> MADV_PAGEOUT and returns -EINVAL. >> >> No, let's not. > > I think I completely got it wrong. Learning so much from your patient responses! Maybe you can make the documentation (man pages?) clearer in that regard? Thanks! -- Cheers, David / dhildenb