From: Mingyou Chen <qby140326@gmail.com>
To: Nika Krasnova <nika@nikableh.moe>
Cc: "Armin Wolf" <W_Armin@gmx.de>,
"Gladyshev Ilya" <foxido@foxido.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver
Date: Fri, 10 Jul 2026 11:41:24 +0800 [thread overview]
Message-ID: <1cc103de-6646-4203-b7ec-c55094c01f1e@gmail.com> (raw)
In-Reply-To: <20260709160749.3178278-1-nika@nikableh.moe>
On 7/10/26 12:07 AM, Nika Krasnova wrote:
> WMI_EVENT_FN_4 is missing from this ignore block (the old keymap had
> it). FN_4 events on Bitland will now fall through to the "Unknown WMI
> hotkey" path instead of being ignored. Looks like an accidental drop in
> the reformat.
My device never report the FN_* events
But them exist in the C# userspace driver. (Might for other bitland devices)
> This remap runs on every machine, not just Redmi. If the firmware emits
> a CPU fan-speed event of 0 (e.g. the fan spinning down), it gets misread
> as KEY_REFRESH_RATE_TOGGLE. Could it be gated on DMI rather than on
> value == 0?
My device never report the fan speed events.
In the current driver, the hwmon status is implemented in a pull model
(laptop_hwmon_read) by wmi calls
So I think the unnecessary events could be removed.
--
Mingyou Chen
next prev parent reply other threads:[~2026-07-10 3:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:23 [PATCH v1 0/4] Merge redmi-wmi into bitland-mifs-wmi Mingyou Chen
2026-07-09 12:23 ` [PATCH v1 1/4] platform/x86: redmi-wmi: Drop redmi-wmi driver Mingyou Chen
2026-07-10 10:24 ` Ilpo Järvinen
2026-07-09 12:23 ` [PATCH v1 2/4] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver Mingyou Chen
2026-07-09 16:07 ` Nika Krasnova
2026-07-10 3:41 ` Mingyou Chen [this message]
2026-07-09 16:21 ` Nika Krasnova
2026-07-10 10:20 ` Ilpo Järvinen
2026-07-09 12:23 ` [PATCH v1 3/4] MAINTAINERS: Add maintainer entry of bitland-mifs-wmi driver Mingyou Chen
2026-07-10 10:25 ` Ilpo Järvinen
2026-07-09 12:23 ` [PATCH v1 4/4] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries Mingyou Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc103de-6646-4203-b7ec-c55094c01f1e@gmail.com \
--to=qby140326@gmail.com \
--cc=W_Armin@gmx.de \
--cc=foxido@foxido.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nika@nikableh.moe \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome