From: Val Packett <val@packett.cool>
To: Jingyuan Liang <jingyliang@chromium.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Mark Brown <broonie@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, devicetree@vger.kernel.org,
hbarnor@chromium.org, Dmitry Antipov <dmanti@microsoft.com>,
Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH 09/12] dt-bindings: input: Document hid-over-spi DT schema
Date: Sat, 7 Mar 2026 04:25:44 -0300 [thread overview]
Message-ID: <1cc6de61-8b56-492e-ab78-e3aa448f58ad@packett.cool> (raw)
In-Reply-To: <20260303-send-upstream-v1-9-1515ba218f3d@chromium.org>
On 3/3/26 3:13 AM, Jingyuan Liang wrote:
> Documentation describes the required and optional properties for
> implementing Device Tree for a Microsoft G6 Touch Digitizer that
> supports HID over SPI Protocol 1.0 specification.
> […]
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - microsoft,g6-touch-digitizer
> + - const: hid-over-spi
> + - description: Just "hid-over-spi" alone is allowed, but not recommended.
> […]
> +required:
> + - compatible
> + - interrupts
> + - reset-gpios
Why is reset required? Is it so implausible on some device implementing
the spec there wouldn't be a reset gpio?
> + - vdd-supply
Linux makes up a dummy regulator if DT doesn't provide one, so can
regulators even be required?
> […]
> + compatible = "hid-over-spi";
Not following your own recommendation from above :)
> + reg = <0x0>;
> + interrupts-extended = <&gpio 42 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&pm8350c_l3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_d6_reset_assert &ts_d6_int_bias>;
Heh, "reset_assert" is a name implying it would actually set the value
from the pinctrl properties, which is what had to be done before
reset-gpios were supported. But now reset-gpios are supported.
Thanks,
~val
P.S. happy to see work on this happen again!
next prev parent reply other threads:[~2026-03-07 7:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 6:12 [PATCH 00/12] Add spi-hid transport driver Jingyuan Liang
2026-03-03 6:12 ` [PATCH 01/12] Documentation: Correction in HID output_report callback description Jingyuan Liang
2026-03-11 5:10 ` Dmitry Torokhov
2026-03-03 6:12 ` [PATCH 02/12] HID: Add BUS_SPI support and define HID_SPI_DEVICE macro Jingyuan Liang
2026-03-11 5:11 ` Dmitry Torokhov
2026-03-03 6:12 ` [PATCH 03/12] HID: spi-hid: add transport driver skeleton for HID over SPI bus Jingyuan Liang
2026-03-03 6:12 ` [PATCH 04/12] HID: spi-hid: add spi-hid driver HID layer Jingyuan Liang
2026-03-03 6:12 ` [PATCH 05/12] HID: spi-hid: add HID SPI protocol implementation Jingyuan Liang
2026-03-03 6:12 ` [PATCH 06/12] HID: spi_hid: add spi_hid traces Jingyuan Liang
2026-03-03 6:12 ` [PATCH 07/12] HID: spi_hid: add ACPI support for SPI over HID Jingyuan Liang
2026-03-11 5:27 ` Dmitry Torokhov
2026-03-13 1:24 ` Jingyuan Liang
2026-03-03 6:13 ` [PATCH 08/12] HID: spi_hid: add device tree " Jingyuan Liang
2026-03-03 6:13 ` [PATCH 09/12] dt-bindings: input: Document hid-over-spi DT schema Jingyuan Liang
2026-03-03 7:24 ` Rob Herring (Arm)
2026-03-03 13:53 ` Rob Herring
[not found] ` <CAEe3GZHSqepvjjopLwrWX3_n4+RnCeVVQnAO=Swixgu2z3OpUw@mail.gmail.com>
2026-03-12 0:58 ` Fwd: " Jingyuan Liang
2026-03-13 1:14 ` Jingyuan Liang
2026-03-07 7:25 ` Val Packett [this message]
2026-03-09 5:44 ` Dmitry Torokhov
2026-03-13 1:00 ` Jingyuan Liang
2026-03-03 6:13 ` [PATCH 10/12] HID: spi-hid: add power management implementation Jingyuan Liang
2026-03-03 6:13 ` [PATCH 11/12] HID: spi-hid: add panel follower support Jingyuan Liang
2026-03-03 6:13 ` [PATCH 12/12] HID: spi-hid: add quirkis to support mode switch for Ilitek touch Jingyuan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc6de61-8b56-492e-ab78-e3aa448f58ad@packett.cool \
--to=val@packett.cool \
--cc=bentiss@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmanti@microsoft.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hbarnor@chromium.org \
--cc=jaschultz@microsoft.com \
--cc=jikos@kernel.org \
--cc=jingyliang@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®