From: Markus Elfring <Markus.Elfring@web.de>
To: "Navid Emamdoost" <navid.emamdoost@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Chunming Zhou <David1.Zhou@amd.com>, Rex Zhu <Rex.Zhu@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen A McCamant <smccaman@umn.edu>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks
Date: Fri, 27 Sep 2019 18:37:37 +0200 [thread overview]
Message-ID: <1cc7e3f9-69fb-e8dc-4bfc-dbb69de66ec7@web.de> (raw)
In-Reply-To: <20190918190529.17298-1-navid.emamdoost@gmail.com>
> v2: moved the released into goto error handlings
A better version comment should be moved below the triple dashes.
Will the tag “Fixes” be added?
> @@ -393,6 +395,16 @@ static int acp_hw_init(void *handle)
> val &= ~ACP_SOFT_RESET__SoftResetAud_MASK;
> cgs_write_register(adev->acp.cgs_device, mmACP_SOFT_RESET, val);
> return 0;
> +
> +out4:
> + kfree(i2s_pdata);
> +out3:
> + kfree(adev->acp.acp_res);
> +out2:
> + kfree(adev->acp.acp_cell);
> +out1:
> + kfree(adev->acp.acp_genpd);
> + return ret;
> }
>
> /**
I suggest to reconsider the label selection according to the Linux coding style.
Regards,
Markus
prev parent reply other threads:[~2019-09-27 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 16:09 [PATCH] " Navid Emamdoost
2019-09-18 17:31 ` Koenig, Christian
2019-09-18 19:05 ` [PATCH v2] " Navid Emamdoost
2019-09-18 19:45 ` Sven Van Asbroeck
2019-09-19 8:03 ` Koenig, Christian
2019-09-19 14:28 ` Sven Van Asbroeck
2019-09-19 16:48 ` Koenig, Christian
2019-09-30 21:26 ` [PATCH v3] drm/amdgpu: fix multiple memory leaks in acp_hw_init Navid Emamdoost
2019-10-01 11:24 ` Markus Elfring
2019-10-01 12:19 ` Koenig, Christian
2019-10-02 3:46 ` [PATCH v4] " Navid Emamdoost
2019-10-02 5:47 ` Markus Elfring
2019-10-02 6:58 ` Koenig, Christian
2019-10-02 3:47 ` [PATCH v3] " Navid Emamdoost
2019-09-30 21:31 ` [PATCH v2] drm/amdgpu: fix multiple memory leaks Navid Emamdoost
2019-09-27 16:37 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc7e3f9-69fb-e8dc-4bfc-dbb69de66ec7@web.de \
--to=markus.elfring@web.de \
--cc=David1.Zhou@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=sam@ravnborg.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome