From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEA3299948 for ; Mon, 23 Mar 2026 18:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290710; cv=none; b=U+XSmFLptEcNkrK3lL13wEZpIOQ0YT97lsQy2qam9pq2juBaz8HIEEHfnFDXAUEoQQuLg/GtDMzKzKPC9TfoEpsNX3AR9GpWxbVcfaXnCKZGr8sY5ScsIevc47lE/3ndvZJZFAW6FjwjJp+XqQy5hIp/PaA614Bdb99IsO8llE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774290710; c=relaxed/simple; bh=bqRgK+7gwbsy7T9nB1J0qJ8gPwKq1G1zEwOxmWI2uCA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=MQp6A//ge8xhqOtRreAMfS44WpIKtvDlOWCrgvI6Wwnq+3Ae4UNyZ3qyHnx0LAH+pDD3gwlk7RhNEXD4oYayNh+tO8IuUhhkvPeF+HVuUK8MbchxRRPyFOcce672mums9z18aDlXEzAhWBn+zyX2L0Oiol2g1X2We6vrBuzI7hM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qw5HNkPH; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qw5HNkPH" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7d7f09aa39fso3307528a34.0 for ; Mon, 23 Mar 2026 11:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774290707; x=1774895507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=QVBazjdvY7hpkM99+8EeEVTqO3Ui5pgYU+jZZ/olKb4=; b=Qw5HNkPH9WPlO56hmF/h2u7sS0cTXgs+t0KZjfk3ZjgthctLmE0Z4950uF4iUaSp/o tmWQo7ZSXP/4IAk7tBEkonoEdc8Cc1OvUFWHvZaPnMjZQlnX8QKuIEOOcIXPItlTqgPS 86SU9AGArRuvz9lLAjItVSTzYlklPU3Oi/J2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774290707; x=1774895507; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QVBazjdvY7hpkM99+8EeEVTqO3Ui5pgYU+jZZ/olKb4=; b=YIBptgsE6ANt6lPKZ46bJFrus1U5vbf78tZEeCMh8BUgZRSgYT9t0hM89SnihWpk6j YdsLD7vBkbgJvOdFIpGikJ5miC8a1cx7QCMj+4smNfg/XBkuIdkwwBFRmqgUvvVU/Z4s a4VZgU5OjSu0Auyjehg/WRSdfMKp6VXJpTmbXNHbjTkgkE1xc4HkH3iFk3NX5lRt/nmh RuFM86CNiFFSxk8Wu9wRRsQ8t5AhjBJ8/A34wh6wdi+weZCisGkA541hGS8z7mPFROA2 nUrxUrIc6KDzt4swMptZXmseor8UgIIWA2keJK1a23+c6emDzArmbgB11sXrX3C5mmVR eO9A== X-Forwarded-Encrypted: i=1; AJvYcCUrOW3NSF0EZdpdfPgpkFQLnRYVyVq8j4smjfC1DBC9w7gs3pIZ/TUcYnCMuQpc/Rc8isju13IDebQcL1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxlbTUQM4ywdIcSXRPcFUg7rY0TBCu4YFirpwBOqNZ4T21kKU1x Avz7J4XYfzJlTlZN4Npnn3QfBQDrGTbwnExAd98fF0vwElHwATSwf+qZMy/jNkHwtPE= X-Gm-Gg: ATEYQzwSWYLstXZW8bSnfNw7B1nVk/CG04ET3wTkNS2TMrjkbTDJ1byNAo2CkAAUale hwhosRgxDfyFYp4s+4Dlwz9F9tE4I8jmLV3QMnHiA9NiPWPbJDuOxwCJZp4yLn+fae0ZeC3fu0Y IOqL17VxkPZ1C6HDwcKrRV5qXgoZNNQmaGlqCFRapeFsSApopA2XbKehporCSebyb3fd1o3yTLh dl/H8ne3fMzCjptLTPukidwxUa6Y6lvzkCWMwSWf6I9Y3yRl3wo1OSt14TpEtZnC7uWvItGxs03 wfHY1l+pg2Dbtgmt7P2GD0icB4sHysdCM6P+VIkoX8SDXfC+9+dujFSzWR4nM+BGyYvlThwryWD evrtwVvPcdtO4osUicINd6N6AVAL53ixLkSGhFQjkpV6/JYciD4lcjM1hwcl87UTWRvcSH481yF +DCHYIm82a4ew6kRiSlIx7OfUy7+LrHkTcL0E= X-Received: by 2002:a05:6830:441f:b0:7d7:49f4:8fce with SMTP id 46e09a7af769-7d7eaf9a720mr9482164a34.19.1774290707230; Mon, 23 Mar 2026 11:31:47 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d7fbee2c6dsm7548239a34.1.2026.03.23.11.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 11:31:46 -0700 (PDT) Message-ID: <1cc868ad-aaf9-4da5-9b20-523ef2da2d1d@linuxfoundation.org> Date: Mon, 23 Mar 2026 12:31:44 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] cpupower-idle-info.1: fix short option names To: Roberto Ricci , Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260312102029.14980-1-io@r-ricci.it> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260312102029.14980-1-io@r-ricci.it> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/12/26 04:20, Roberto Ricci wrote: > The cpupower-idle-info(1) man page describes '-f' as the short form of > the '--silent' option and '-e' as the short form of the '--proc' option. > But they are not correct: > > $ cpupower idle-info -f > idle-info: invalid option -- 'f' > invalid or unknown argument > $ cpupower idle-info -e > idle-info: invalid option -- 'e' > invalid or unknown argument > > The short form of '--silent' is actually '-s' and the short form of > '--proc' is actually 'o': > > cpuidle-info.c: > {"silent", no_argument, NULL, 's'}, > {"proc", no_argument, NULL, 'o'}, > > Fixes e7d85a934182d5bde1eea865169fbf2e0637a3ed ("cpupower: Add cpupower-idle-info manpage") There is no need t for Fixes tag in any of these patches. Fixes tag is used when you fix a bug in code. Using Fixes for every single patch adds lot of churn for stable releases. Remove Fixes tag from all these 4 patches and run checkpatch before sending patches to me adding version information. Incorrect fixes style in all of these 4 patches. Running checkpatch helps you catch these error before I see them. ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit e7d85a934182 ("cpupower: Add cpupower-idle-info manpage")' #86: > > Signed-off-by: Roberto Ricci <io@r-ricci.it> > --- Adding changes in since patch v1 makes reviewers job easier. We can easily our comments are addressed or not. > tools/power/cpupower/man/cpupower-idle-info.1 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/power/cpupower/man/cpupower-idle-info.1 b/tools/power/cpupower/man/cpupower-idle-info.1 > index 20b6345c53ad..b2f92aba5f5b 100644 > --- a/tools/power/cpupower/man/cpupower-idle-info.1 > +++ b/tools/power/cpupower/man/cpupower-idle-info.1 > @@ -11,10 +11,10 @@ A tool which prints out per cpu idle information helpful to developers and inter > .SH "OPTIONS" > .LP > .TP > -\fB\-f\fR \fB\-\-silent\fR > +\fB\-s\fR \fB\-\-silent\fR > Only print a summary of all available C-states in the system. > .TP > -\fB\-e\fR \fB\-\-proc\fR > +\fB\-o\fR \fB\-\-proc\fR > deprecated. > Prints out idle information in old /proc/acpi/processor/*/power format. This > interface has been removed from the kernel for quite some time, do not let thanks, -- Shuah