From: Hans de Goede <hdegoede@redhat.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] platform/surface: aggregator_tabletsw: Add support for book mode
Date: Tue, 30 May 2023 11:25:19 +0200 [thread overview]
Message-ID: <1cd0a13e-1842-2e1c-524b-e9580ea48b52@redhat.com> (raw)
In-Reply-To: <20230525213218.2797480-1-luzmaximilian@gmail.com>
Hi,
On 5/25/23 23:32, Maximilian Luz wrote:
> Surface devices with a type-cover have an additional "book" mode. This
> mode is activated when the device is oriented in portrait mode and the
> type-cover is in an open position (including completely folded back;
> unlike in landscape orientation there are no special modes for any of
> the intermediate positions).
>
> Currently, this mode is unsupported by the tablet switch driver, leading
> to an error message (see individual commits for the exact messages).
> Since the keyboard and touchpad input gets deactivated in this mode, map
> it to tablet-mode.
>
> I've split this change into two patches, one for each of the subsystems
> (KIP and POS). This a) allows proper attribution via the "Fixes" tag and
> b) with that should allow them to be backported fairly easily.
Thank you for your patch series, I've applied this series
to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes
I will include this series in my next fixes pull-req to Linus
for the current kernel development cycle.
Regards,
Hans
> Maximilian Luz (2):
> platform/surface: aggregator_tabletsw: Add support for book mode in
> KIP subsystem
> platform/surface: aggregator_tabletsw: Add support for book mode in
> POS subsystem
>
> drivers/platform/surface/surface_aggregator_tabletsw.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
prev parent reply other threads:[~2023-05-30 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 21:32 Maximilian Luz
2023-05-25 21:32 ` [PATCH 1/2] platform/surface: aggregator_tabletsw: Add support for book mode in KIP subsystem Maximilian Luz
2023-05-25 21:32 ` [PATCH 2/2] platform/surface: aggregator_tabletsw: Add support for book mode in POS subsystem Maximilian Luz
2023-05-30 9:25 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd0a13e-1842-2e1c-524b-e9580ea48b52@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®