mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Falcon, Thomas" <thomas.falcon@intel.com>
To: "acme@kernel.org" <acme@kernel.org>
Cc: "alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
	"irogers@google.com" <irogers@google.com>,
	"dapeng1.mi@linux.intel.com" <dapeng1.mi@linux.intel.com>
Subject: Re: [Patch v3 0/2] perf record: ratio-to-prev event term for auto counter reload
Date: Mon, 6 Oct 2025 16:23:42 +0000	[thread overview]
Message-ID: <1cd532e63acc22a4c6632285195305972ae36122.camel@intel.com> (raw)
In-Reply-To: <aOAju-lDNHBFnYWx@x1>

On Fri, 2025-10-03 at 16:27 -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, Oct 02, 2025 at 06:43:04PM -0500,
> thomas.falcon@intel.com wrote:
> > The goal is to limit event sampling to cases when the branch miss
> > rate
> > exceeds 20%. If the branch instructions sample period is exceeded
> > first, both events are reloaded.  If branch misses exceed their
> > threshold first, only the second counter is reloaded, and a sample
> > is
> > taken.
>  
> > To simplify this, provide a new “ratio-to-prev” event term
> > that works alongside the period event option or -c option.
> > This would allow users to specify the desired relative rate
> > between events as a ratio, making configuration more intuitive.
>  
> > With this enhancement, the equivalent command would be:
> > 
> > perf record -e "{cpu_atom/branch-misses/ppu,\
> > cpu_atom/branch-instructions,period=1000000,ratio_to_prev=5/u}" \
> > -- ./mispredict
> > or
> > perf record -e "{cpu_atom/branch-misses/ppu,\
> > cpu_atom/branch-instructions,ratio-to-prev=5/u}" -c 1000000 \
> > -- ./mispredict
> > [1]
> > https://lore.kernel.org/lkml/20250327195217.2683619-1-kan.liang@linux.intel.com/
> > v3: rebase to current perf-tools-next
> 
> Thanks, applied to perf-tools-next,
> 
> - Arnaldo
>  

Thank you and thanks to Ian and everyone else that took their time to
review.

Thanks,
Tom

> > v2: (changes below suggested by Ian Rogers):
> 


      reply	other threads:[~2025-10-06 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 23:43 thomas.falcon
2025-10-02 23:43 ` [Patch v3 1/2] perf record: Add ratio-to-prev term thomas.falcon
2025-10-07  8:55   ` Namhyung Kim
2025-10-08 20:30     ` Falcon, Thomas
2025-10-02 23:43 ` [Patch v3 2/2] perf record: Add auto counter reload parse and regression tests thomas.falcon
2025-10-03 19:27 ` [Patch v3 0/2] perf record: ratio-to-prev event term for auto counter reload Arnaldo Carvalho de Melo
2025-10-06 16:23   ` Falcon, Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cd532e63acc22a4c6632285195305972ae36122.camel@intel.com \
    --to=thomas.falcon@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®