From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB75730EF7B for ; Thu, 7 May 2026 07:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778138463; cv=none; b=i+W/GzXmTk0vy1To1B13fm7/hth3fFrmKj4lzUOIWAQcHB9j1tRGozhEdcD1YoIAbvYqq3QfCx7x1VBirBbJ6whqrge0sUGmOZJj1Ucr6z+cJMcJ/NW+DCssNGDpVk1E2MVptsyXZ7gcIaYJbWji24ux5sVnEyS/1tQTjANlTh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778138463; c=relaxed/simple; bh=rUQoQZDzHnFIn5GHfRInxQalRbst+XXfqMKwdXuq1ac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TZJbdPKl0A7HN+E3VNNLUf+16zA3K4XuZXbTLs0g3kOH/RZ/xKFDSHlbdrEW3CsYG4PCRIAxgY9LGCXvck9yDPSJ8yJBwNQM4HNQIq+jcHuxuMxY7XgpVJ/lukJ487dio3RZl8BUm+kZoGwNkEXOx6EhMnYe0tTQkun9xaNgmLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y0ogMNla; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UTzZ60z1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y0ogMNla"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UTzZ60z1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778138460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iJCtbpDZBR/57aHfFYrXL9twLmQ3xZkrJJexPdNGgdM=; b=Y0ogMNlaPSMsXtc737umHP2Uwldqox5v6OTVSMg3Gg5nD/ZlDhrvo97WvoDM4bu05fGmDJ QTzOaBGRwGUAI4O5GTVtKPnZeiQKyDjq191AItaLGUhv0+SbzutBFlUcEngjiGtqYM8yqI pwmo9oYmjRGvnSWkS4j8JTBUYq+id14= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-BGupmkAuPJuxYIZpsQCmDg-1; Thu, 07 May 2026 03:20:57 -0400 X-MC-Unique: BGupmkAuPJuxYIZpsQCmDg-1 X-Mimecast-MFC-AGG-ID: BGupmkAuPJuxYIZpsQCmDg_1778138456 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d8deb75fso3975195e9.3 for ; Thu, 07 May 2026 00:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778138456; x=1778743256; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iJCtbpDZBR/57aHfFYrXL9twLmQ3xZkrJJexPdNGgdM=; b=UTzZ60z1sqYXa1/kaCd6LwlT7aNASqN7cEXAA0Ii1lcYv6twPgGojb+Fq/Xl565LDJ E3q8UoVBbehqL30v6ogJOmunVe4jIa6XtJcGq2ZryJaU+sx64evn3PbA6zu+BjnEndax My4vxEQqemzc1kiPBaW62QsrX8i59q14Twr0b++SKeSz7eUXpyiPuvD1Rvqhjm2OQ21m bD3RJ6Uq+OeJfxji2S7h8C5DGNPAWYFHVmOzmFBY2Ay2syaCc8mIirzZqxeyi03kiYTs vIfjA+05XkVHrQb9wJM8qn4oL6nzdVf6IIRxR7kreo4PI8LgEDiAGuxh3ipXlQFZHLgT Xbvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778138456; x=1778743256; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iJCtbpDZBR/57aHfFYrXL9twLmQ3xZkrJJexPdNGgdM=; b=qsrv/6zbf+feKr/SBiqjMwH/0BI6xVvQaEnAXpYHKREIDXCf239kVjqYUYbtps65BX Ca9sYuSyoODT419OvIYK1mdT9X6shpEI1Dh/MTghYAAFY6lcyBRII4BP0jGBDsdTL92a 0zN/IdvuxC+EyOv7Ny3T1pj3dPqvsKAQ9R87lnIR3lfiBg2yDoBY2TgHC15xrNSPy02p ZHfsgaRaForl1qFW5ZKPjo7q0nk6LiGZ6auPxTEnlpit9CyoSt9VuTSIbxcW37WY14rT kMHgJZvwtVuLzf+SEjN+v19z4wJfUIQoqaOLToqp5EeWSOZBP0uiNDIN+LTO2GAW1Mg4 05CQ== X-Forwarded-Encrypted: i=1; AFNElJ8wE0D0is95pSqUBAQmsuu5UkCAHcY5tZ8gajNMswBlrWElOXU8cNHP+x07kkN7KSvzuP3Tk+TAFkT8xks=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+vTywXsD4bLL9dF1xKjNO2++4gJTta0MPHZwJbSl14Wlj3EdL cNpDhGMd3F80O2R8nxBYGc/TFUB3ZfEln9uWQYmqX9f3TYVqHm7iD0uY/iSpljfJXe7QKMJ5ta2 4hEOvqTbnzW2L7eb6d2PAhHVScLglnMbbG9HuZNlGHbS7QEv9iJgS0Ta4aJrov/0UQA== X-Gm-Gg: AeBDiesthDkaelOp0F8VaRqoEdUrAV8hglCdUY/IWbb6iH2Q9RjxJVzUFCDAM+psh73 bGX5AVUZ2yddtgqVRH5LAfK9bStsx9/i6YhrBK4s3F6Yw9t2kMnPBDoGsTh6nkYpQUJjT8bkew9 CzTqxdDsHjn5TD8YN0KRKZ65+VLTOZStGBOhttIvYPQLoJP/dWyUxOzpD9I/fCl2DVZ9TDh2Zai rd69OteoMV2opPiOSpv72ALO76Dqe9oBHj29gRK3gy0Oo4nVA7FViIF9sjgPOqESUaKKN8cpfDA Tz3Cy4Mj2S2uxTIxl4NyfAP/58SAftsZdQJxHW1ffeMy12tbPZVjrNePZ0ys0uYV1Rxi1xzuF0h gwCCaHvFr8gFEvQmHYtIK4O4C92DArC7uKsvZ4DBxlZ32RpdO/v7cAkO67Tmea5dLKg== X-Received: by 2002:a05:600c:a305:b0:48d:361:4df6 with SMTP id 5b1f17b1804b1-48e51e19680mr76570845e9.9.1778138456118; Thu, 07 May 2026 00:20:56 -0700 (PDT) X-Received: by 2002:a05:600c:a305:b0:48d:361:4df6 with SMTP id 5b1f17b1804b1-48e51e19680mr76570405e9.9.1778138455654; Thu, 07 May 2026 00:20:55 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538bc9bdsm123490205e9.11.2026.05.07.00.20.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 00:20:55 -0700 (PDT) Message-ID: <1cd8256c-286a-4a73-b0a0-89233cb3c2d0@redhat.com> Date: Thu, 7 May 2026 09:20:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/4] net: eth: fbnic: Fix addr validation in pcs write To: Jakub Kicinski , mike.marciniszyn@gmail.com Cc: Alexander Duyck , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Heiner Kallweit , Russell King , Jacob Keller , Mohsin Bashir , Simon Horman , Lee Trager , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504135815.44226-1-mike.marciniszyn@gmail.com> <20260504135815.44226-2-mike.marciniszyn@gmail.com> <20260506185819.1c68a71b@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260506185819.1c68a71b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/7/26 3:58 AM, Jakub Kicinski wrote: > On Mon, 4 May 2026 09:58:12 -0400 mike.marciniszyn@gmail.com wrote: >> From: "Mike Marciniszyn (Meta)" >> >> The DW IP has two distinct PCS address ranges cooresponding >> to the C45 PCS registers. >> >> The shim translates the PCS addr/regno into specific CSR writes >> into one of those two zero-relative. >> >> This patch fixes a one off in the test that could allow an invalid >> CSR write if an addr == 2 was called. >> >> This patch contains a fix for addr validation in fbnic_mdio_write_pcs() >> to only return actual CSR reads for addr 0 and 1. >> >> There are as of yet, no real impact for the bug as no PCS writes are >> not yet present. > > Hi Paolo! Was there a reason / do you recall why this was not applied? > (I dropped it from patchwork now. If the omission was accidental it has > to be reposted) Darn, limited capacity here plus re-submission glitch: v3 had a slightly different cover title (due to typo) WRT v2 so PW did not mark v2 as superseded. I process patches via PW in sequence, when I reached v2 I considered the sashiko comment not blocking and I apply it. I was unable to reach v3 until now. TL;DR: @Mike: please re-submit 1/4 and double check there are not other differences between v2 and v3 - otherwise more patches needed. Also please ensure you keep the series title consistent among revision, or at least manually remove old revisions from PW upon resubmission. Thanks, Paolo