From: Sudeep Holla <sudeep.holla@arm.com>
To: Ilia Lin <ilialin@codeaurora.org>,
mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
mark.rutland@arm.com, andy.gross@linaro.org,
david.brown@linaro.org, will.deacon@arm.com
Cc: Sudeep Holla <sudeep.holla@arm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, vireshk@kernel.org,
linux-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 1/8] soc: qcom: Separate kryo l2 accessors from PMU driver
Date: Wed, 23 May 2018 14:51:29 +0100 [thread overview]
Message-ID: <1cd8b060-9dec-6dce-cb57-4a43bf441f12@arm.com> (raw)
In-Reply-To: <1527079981-11179-2-git-send-email-ilialin@codeaurora.org>
On 23/05/18 13:52, Ilia Lin wrote:
> The driver provides kernel level API for other drivers
> to access the MSM8996 L2 cache registers.
> Separating the L2 access code from the PMU driver and
> making it public to allow other drivers use it.
> The accesses must be separated with a single spinlock,
> maintained in this driver.
>
> Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
> ---
> drivers/perf/Kconfig | 1 +
> drivers/perf/qcom_l2_pmu.c | 90 ++++++++++--------------------------
> drivers/soc/qcom/Kconfig | 3 ++
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/kryo-l2-accessors.c | 56 ++++++++++++++++++++++
> include/soc/qcom/kryo-l2-accessors.h | 12 +++++
> 6 files changed, 97 insertions(+), 66 deletions(-)
> create mode 100644 drivers/soc/qcom/kryo-l2-accessors.c
> create mode 100644 include/soc/qcom/kryo-l2-accessors.h
>
[..
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 7093fe7..0567dff 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -39,6 +39,9 @@ config QCOM_GSBI
> functions for connecting the underlying serial UART, SPI, and I2C
> devices to the output pins.
>
> +config QCOM_KRYO_L2_ACCESSORS
> + bool
> +
I think kbuild bot complained about this and you haven't addressed it.
This can be enabled on ARM and build breaks due to missing sysreg.h
IIRC. Look at the kbuild report and fix it.
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-05-23 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 12:52 [PATCH v11 0/8] CPU scaling support for msm8996 Ilia Lin
2018-05-23 12:52 ` [PATCH v11 1/8] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin
2018-05-23 13:51 ` Sudeep Holla [this message]
2018-05-23 12:52 ` [PATCH v11 2/8] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin
2018-05-23 12:52 ` [PATCH v11 3/8] clk: Use devm_ in the register fixed factor clock Ilia Lin
2018-05-23 12:52 ` [PATCH v11 4/8] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin
2018-05-23 12:52 ` [PATCH v11 5/8] dt-bindings: clk: qcom: Add bindings for CPU clock " Ilia Lin
2018-05-23 12:52 ` [PATCH v11 6/8] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin
2018-05-23 12:53 ` [PATCH v11 7/8] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin
2018-05-23 12:53 ` [PATCH v11 8/8] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd8b060-9dec-6dce-cb57-4a43bf441f12@arm.com \
--to=sudeep.holla@arm.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilialin@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome