From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S . Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH] crypto: starfive - Add AES skcipher and aead support
Date: Mon, 17 Jul 2023 01:47:58 +0000 [thread overview]
Message-ID: <1cd932eb3234436394bf46cfebc1df39@EXMBX068.cuchost.com> (raw)
In-Reply-To: <ZLEK1AYMmj24rIph@gondor.apana.org.au>
> This doesn't compile:
>
> CC [M] drivers/crypto/starfive/jh7110-cryp.o
> CC [M] drivers/crypto/starfive/jh7110-hash.o
> CC [M] drivers/crypto/starfive/jh7110-rsa.o
> CC [M] drivers/crypto/starfive/jh7110-aes.o
> In file included from ../drivers/crypto/starfive/jh7110-aes.c:13:
> ../drivers/crypto/starfive/jh7110-cryp.h:184:49: error: field ‘aes_done’ has
> incomplete type
> 184 | struct tasklet_struct aes_done;
> | ^~~~~~~~
> ../drivers/crypto/starfive/jh7110-cryp.h:185:49: error: field ‘hash_done’ has
> incomplete type
> 185 | struct tasklet_struct hash_done;
> | ^~~~~~~~~
> make[6]: *** [../scripts/Makefile.build:243: drivers/crypto/starfive/jh7110-
> aes.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
>
Hi Herbert,
Thanks for reviewing the patch.
I found out that it's missing interrupt.h include.
It is weird that the compile error did not show in the original driver and on my local build.
I'll fix this in the next version.
Thanks,
Jia Jie
prev parent reply other threads:[~2023-07-17 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 3:27 Jia Jie Ho
2023-07-14 8:44 ` Herbert Xu
2023-07-17 1:47 ` JiaJie Ho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd932eb3234436394bf46cfebc1df39@EXMBX068.cuchost.com \
--to=jiajie.ho@starfivetech.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®