From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4FE3C43217 for ; Mon, 25 Apr 2022 09:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241569AbiDYJTY (ORCPT ); Mon, 25 Apr 2022 05:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241528AbiDYJSr (ORCPT ); Mon, 25 Apr 2022 05:18:47 -0400 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4E0DD5A; Mon, 25 Apr 2022 02:15:42 -0700 (PDT) Received: by ajax-webmail-mail-app4 (Coremail) ; Mon, 25 Apr 2022 17:09:34 +0800 (GMT+08:00) X-Originating-IP: [10.190.64.42] Date: Mon, 25 Apr 2022 17:09:34 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: duoming@zju.edu.cn To: "Krzysztof Kozlowski" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, broonie@kernel.org, akpm@linux-foundation.org, alexander.deucher@amd.com, gregkh@linuxfoundation.org, davem@davemloft.net, linma@zju.edu.cn Subject: Re: Re: [PATCH] drivers: nfc: nfcmrvl: reorder destructive operations in nfcmrvl_nci_unregister_dev to avoid bugs X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210104(ab8c30b6) Copyright (c) 2002-2022 www.mailtech.cn zju.edu.cn In-Reply-To: References: <20220425031002.56254-1-duoming@zju.edu.cn> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <1ce1ec63.1b911.1805ffbb915.Coremail.duoming@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: cS_KCgAXGfBOZWZi5gPCAQ--.61012W X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAgwLAVZdtZZGlAADs9 X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGVsbG8sCgpPbiBNb24sIDI1IEFwciAyMDIyIDA5OjU5OjMyICswMjAwIEtyenlzenRvZiB3cm90 ZToKCj4gPiBUaGVyZSBhcmUgZGVzdHJ1Y3RpdmUgb3BlcmF0aW9ucyBzdWNoIGFzIG5mY21ydmxf ZndfZG5sZF9hYm9ydCBhbmQKPiA+IGdwaW9fZnJlZSBpbiBuZmNtcnZsX25jaV91bnJlZ2lzdGVy X2Rldi4gVGhlIHJlc291cmNlcyBzdWNoIGFzIGZpcm13YXJlLAo+ID4gZ3BpbyBhbmQgc28gb24g Y291bGQgYmUgZGVzdHJ1Y3RlZCB3aGlsZSB0aGUgdXBwZXIgbGF5ZXIgZnVuY3Rpb25zIHN1Y2gg YXMKPiA+IG5mY21ydmxfZndfZG5sZF9zdGFydCBhbmQgbmZjbXJ2bF9uY2lfcmVjdl9mcmFtZSBp cyBleGVjdXRpbmcsIHdoaWNoIGxlYWRzCj4gPiB0byBkb3VibGUtZnJlZSwgdXNlLWFmdGVyLWZy ZWUgYW5kIG51bGwtcHRyLWRlcmVmIGJ1Z3MuCj4gCj4gWW91IG5lZWQgdG8gY29ycmVjdCB0aGUg c3ViamVjdCBwcmVmaXggYmVjYXVzZSBpdCBkb2VzIG5vdCBkZXNjcmliZSB0aGUKPiBzdWJzeXN0 ZW0gKGdpdCBsb2cgb25lbGluZSAtLSkuCgpJIHdpbGwgY2hhbmdlIHRoZSBzdWJqZWN0IHByZWZp eCB0byAibmZjOiBuZmNtcnZsOiB1YXJ0OiAiLgoKPiA+IAo+ID4gVGhlcmUgYXJlIHRocmVlIHNp dHVhdGlvbnMgdGhhdCBjb3VsZCBsZWFkIHRvIGRvdWJsZS1mcmVlIGJ1Z3MuCj4gPiAKPiA+IFRo ZSBmaXJzdCBzaXR1YXRpb24gaXMgc2hvd24gYmVsb3c6Cj4gPiAKPiA+ICAgIChUaHJlYWQgMSkg ICAgICAgICAgICAgICAgIHwgICAgICAoVGhyZWFkIDIpCj4gPiBuZmNtcnZsX2Z3X2RubGRfc3Rh cnQgICAgICAgICB8Cj4gPiAgLi4uICAgICAgICAgICAgICAgICAgICAgICAgICB8ICBuZmNtcnZs X25jaV91bnJlZ2lzdGVyX2Rldgo+ID4gIHJlbGVhc2VfZmlybXdhcmUoKSAgICAgICAgICAgfCAg IG5mY21ydmxfZndfZG5sZF9hYm9ydAo+ID4gICBrZnJlZShmdykgLy8oMSkgICAgICAgICAgICAg fCAgICBmd19kbmxkX292ZXIKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg IHJlbGVhc2VfZmlybXdhcmUKPiA+ICAgLi4uICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg ICBrZnJlZShmdykgLy8oMikKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg IC4uLgo+ID4gCj4gPiBUaGUgc2Vjb25kIHNpdHVhdGlvbiBpcyBzaG93biBiZWxvdzoKPiA+IAo+ ID4gICAgKFRocmVhZCAxKSAgICAgICAgICAgICAgICAgfCAgICAgIChUaHJlYWQgMikKPiA+IG5m Y21ydmxfZndfZG5sZF9zdGFydCAgICAgICAgIHwKPiA+ICAuLi4gICAgICAgICAgICAgICAgICAg ICAgICAgIHwKPiA+ICBtb2RfdGltZXIgICAgICAgICAgICAgICAgICAgIHwKPiA+ICAod2FpdCBh IHRpbWUpICAgICAgICAgICAgICAgIHwKPiA+ICBmd19kbmxkX3RpbWVvdXQgICAgICAgICAgICAg IHwgIG5mY21ydmxfbmNpX3VucmVnaXN0ZXJfZGV2Cj4gPiAgICBmd19kbmxkX292ZXIgICAgICAg ICAgICAgICB8ICAgbmZjbXJ2bF9md19kbmxkX2Fib3J0Cj4gPiAgICAgcmVsZWFzZV9maXJtd2Fy ZSAgICAgICAgICB8ICAgIGZ3X2RubGRfb3Zlcgo+ID4gICAgICBrZnJlZShmdykgLy8oMSkgICAg ICAgICAgfCAgICAgcmVsZWFzZV9maXJtd2FyZQo+ID4gICAgICAuLi4gICAgICAgICAgICAgICAg ICAgICAgfCAgICAgIGtmcmVlKGZ3KSAvLygyKQo+ID4gCj4gPiBUaGUgdGhpcmQgc2l0dWF0aW9u IGlzIHNob3duIGJlbG93Ogo+ID4gCj4gPiAgICAgICAgKFRocmVhZCAxKSAgICAgICAgICAgICAg IHwgICAgICAgKFRocmVhZCAyKQo+ID4gbmZjbXJ2bF9uY2lfcmVjdl9mcmFtZSAgICAgICAgICB8 Cj4gPiAgaWYoLi4tPmZ3X2Rvd25sb2FkX2luX3Byb2dyZXNzKXwKPiA+ICAgbmZjbXJ2bF9md19k bmxkX3JlY3ZfZnJhbWUgICAgfAo+ID4gICAgcXVldWVfd29yayAgICAgICAgICAgICAgICAgICB8 Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKPiA+IGZ3X2RubGRfcnhfd29y ayAgICAgICAgICAgICAgICAgfCBuZmNtcnZsX25jaV91bnJlZ2lzdGVyX2Rldgo+ID4gIGZ3X2Ru bGRfb3ZlciAgICAgICAgICAgICAgICAgICB8ICBuZmNtcnZsX2Z3X2RubGRfYWJvcnQKPiA+ICAg cmVsZWFzZV9maXJtd2FyZSAgICAgICAgICAgICAgfCAgIGZ3X2RubGRfb3Zlcgo+ID4gICAga2Zy ZWUoZncpIC8vKDEpICAgICAgICAgICAgICB8ICAgIHJlbGVhc2VfZmlybXdhcmUKPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAga2ZyZWUoZncpIC8vKDIpCj4gPiAKPiA+ IFRoZSBmaXJtd2FyZSBzdHJ1Y3QgaXMgZGVhbGxvY2F0ZWQgaW4gcG9zaXRpb24gKDEpIGFuZCBk ZWFsbG9jYXRlZAo+ID4gaW4gcG9zaXRpb24gKDIpIGFnYWluLgo+ID4gCj4gPiBUaGUgY3Jhc2gg dHJhY2UgdHJpZ2dlcmVkIGJ5IFBPQyBpcyBsaWtlIGJlbG93Ogo+ID4gCj4gPiBbICAxMjIuNjQw NDU3XSBCVUc6IEtBU0FOOiBkb3VibGUtZnJlZSBvciBpbnZhbGlkLWZyZWUgaW4gZndfZG5sZF9v dmVyKzB4MjgvMHhmMAo+ID4gWyAgMTIyLjY0MDQ1N10gQ2FsbCBUcmFjZToKPiA+IFsgIDEyMi42 NDA0NTddICA8VEFTSz4KPiA+IFsgIDEyMi42NDA0NTddICBrZnJlZSsweGIwLzB4MzMwCj4gPiBb ICAxMjIuNjQwNDU3XSAgZndfZG5sZF9vdmVyKzB4MjgvMHhmMAo+ID4gWyAgMTIyLjY0MDQ1N10g IG5mY21ydmxfbmNpX3VucmVnaXN0ZXJfZGV2KzB4NjEvMHg3MAo+ID4gWyAgMTIyLjY0MDQ1N10g IG5jaV91YXJ0X3R0eV9jbG9zZSsweDg3LzB4ZDAKPiA+IFsgIDEyMi42NDA0NTddICB0dHlfbGRp c2Nfa2lsbCsweDNlLzB4ODAKPiA+IFsgIDEyMi42NDA0NTddICB0dHlfbGRpc2NfaGFuZ3VwKzB4 MWIyLzB4MmMwCj4gPiBbICAxMjIuNjQwNDU3XSAgX190dHlfaGFuZ3VwLnBhcnQuMCsweDMxNi8w eDUyMAo+ID4gWyAgMTIyLjY0MDQ1N10gIHR0eV9yZWxlYXNlKzB4MjAwLzB4NjcwCj4gPiBbICAx MjIuNjQwNDU3XSAgX19mcHV0KzB4MTEwLzB4NDEwCj4gPiBbICAxMjIuNjQwNDU3XSAgdGFza193 b3JrX3J1bisweDg2LzB4ZDAKPiA+IFsgIDEyMi42NDA0NTddICBleGl0X3RvX3VzZXJfbW9kZV9w cmVwYXJlKzB4MWFhLzB4MWIwCj4gPiBbICAxMjIuNjQwNDU3XSAgc3lzY2FsbF9leGl0X3RvX3Vz ZXJfbW9kZSsweDE5LzB4NTAKPiA+IFsgIDEyMi42NDA0NTddICBkb19zeXNjYWxsXzY0KzB4NDgv MHg5MAo+ID4gWyAgMTIyLjY0MDQ1N10gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsw eDQ0LzB4YWUKPiA+IFsgIDEyMi42NDA0NTddIFJJUDogMDAzMzoweDdmNjg0MzNmNmJlYgo+ID4g Cj4gPiBXaGF0J3MgbW9yZSwgdGhlcmUgYXJlIGFsc28gdXNlLWFmdGVyLWZyZWUgYW5kIG51bGwt cHRyLWRlcmVmIGJ1Z3MKPiA+IGluIG5mY21ydmxfZndfZG5sZF9zdGFydC4gSWYgd2UgZGVhbGxv Y2F0ZSBmaXJtd2FyZSBzdHJ1Y3QsIGdwaW8gb3IKPiA+IHNldCBudWxsIHRvIHRoZSBtZW1iZXJz IG9mIHByaXYtPmZ3X2RubGQgaW4gbmZjbXJ2bF9uY2lfdW5yZWdpc3Rlcl9kZXYsCj4gPiB0aGVu LCB3ZSBkZXJlZmVyZW5jZSBmaXJtd2FyZSwgZ3BpbyBvciB0aGUgbWVtYmVycyBvZiBwcml2LT5m d19kbmxkIGluCj4gPiBuZmNtcnZsX2Z3X2RubGRfc3RhcnQsIHRoZSBVQUYgb3IgTlBEIGJ1Z3Mg d2lsbCBoYXBwZW4uCj4gPiAKPiA+IFRoaXMgcGF0Y2ggcmVvcmRlcnMgZGVzdHJ1Y3RpdmUgb3Bl cmF0aW9ucyBhZnRlciBuY2lfdW5yZWdpc3Rlcl9kZXZpY2UKPiA+IHRvIGF2b2lkIHRoZSBkb3Vi bGUtZnJlZSwgVUFGIGFuZCBOUEQgYnVncywgYXMgbmNpX3VucmVnaXN0ZXJfZGV2aWNlCj4gPiBp cyB3ZWxsIHN5bmNocm9uaXplZCBhbmQgd29uJ3QgcmV0dXJuIGlmIHRoZXJlIGlzIGEgcnVubmlu ZyByb3V0aW5lLgo+ID4gVGhpcyB3YXMgbWVudGlvbmVkIGluIGNvbW1pdCAzZTNiNWRmY2QxNmEg KCJORkM6IHJlb3JkZXIgdGhlIGxvZ2ljIGluCj4gPiBuZmNfe3VuLH1yZWdpc3Rlcl9kZXZpY2Ui KS4KPiA+IAo+ID4gRml4ZXM6IDMxOTRjNjg3MDE1OCAoIk5GQzogbmZjbXJ2bDogYWRkIGZpcm13 YXJlIGRvd25sb2FkIHN1cHBvcnQiKQo+ID4gU2lnbmVkLW9mZi1ieTogRHVvbWluZyBaaG91IDxk dW9taW5nQHpqdS5lZHUuY24+Cj4gPiBSZXZpZXdlZC1ieTogTGluIE1hIDxsaW5tYUB6anUuZWR1 LmNuPgo+IAo+IEl0J3MgdGhlIGZpcnN0IHN1Ym1pc3Npb24sIGhvdyB0aGlzIHJldmlldyBhcHBl YXJlZD8KCkkgd2lsbCByZW1vdmUgdGhlIHJldmlldyB0YWcuCgo+IE9uIHRoZSBvdGhlciBoYW5k LCB5b3UgYWxyZWFkeSBzZW50IHNvbWV0aGluZyBzaW1pbGFyLCBzbyBpcyBpdCBhIHYyPyBJCj4g YW0gc29ycnkgYnV0IHRoaXMgaXMgdmVyeSBjb25mdXNpbmcuIExvb2tzIGxpa2UKPiBodHRwczov L2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMjA0MjUwMDU3MTguMzM2MzktMS1kdW9taW5nQHpqdS5l ZHUuY24vCj4gYnV0IHRoZXJlIGlzIG5vIGNoYW5nZWxvZyBhbmQgY29tbWl0IGRlc2NyaXB0aW9u IGlzIGRpZmZlcmVudC4KCkkgYW0gc29ycnkgdGhlIGFib3ZlIGxpbmsgaXMganVzdCBhIHRlc3Qs IEkgZm9yZ2V0IHRvIHJlbW92ZSAiQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmciLgoKPiBQbGVh c2UgcmVhZDoKPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92NS4xOC1yYzQvc291 cmNlL0RvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0Cj4gCgpJIHdp bGwgc2VuZCAiW1BBVENIIG5ldCBWMl0gbmZjOiBuZmNtcnZsOiB1YXJ0OiByZW9yZGVyIGRlc3Ry dWN0aXZlIG9wZXJhdGlvbnMgaW4gbmZjbXJ2bF9uY2lfdW5yZWdpc3Rlcl9kZXYgdG8gYXZvaWQg YnVncyIuCgpCZXN0IHJlZ2FyZHMsCkR1b21pbmcgWmhvdQ==