From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andreas Oetken <andreas.oetken@siemens.com>
Cc: andreas@oetken.name, m-karicheri2@ti.com, a-kramer@ti.com,
Arvid Brodin <arvid.brodin@alten.se>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] hsr: fix don't prune the master node from the node_db
Date: Thu, 23 May 2019 12:02:00 +0300 [thread overview]
Message-ID: <1ce497cb-f121-7f73-e39f-a0474a33bc90@cogentembedded.com> (raw)
In-Reply-To: <20190523070238.17560-1-andreas.oetken@siemens.com>
Hello!
On 23.05.2019 10:02, Andreas Oetken wrote:
> Don't prune master node in the hsr_prune_nodes function.
> Neither time_in[HSR_PT_SLAVE_A], nor time_in[HSR_PT_SLAVE_B],
> will ever be updated by hsr_register_frame_in for the master port.
> Thus the master node will be repeatedly pruned leading to
> repeated packet loss.
> This bug never appeared because the hsr_prune_nodes function
> was only called once. Since commit 5150b45fd355
> ("net: hsr: Fix node prune function for forget time expiry") this issue
> is fixed unvealing the issue described above.
^^^^^^^^^
My spellchecker trips on this word. I think it should be either
"unveiling" or "revealing"...
> Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
> Tested-by: Murali Karicheri <m-karicheri2@ti.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2019-05-23 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:02 Andreas Oetken
2019-05-23 9:02 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce497cb-f121-7f73-e39f-a0474a33bc90@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=a-kramer@ti.com \
--cc=andreas.oetken@siemens.com \
--cc=andreas@oetken.name \
--cc=arvid.brodin@alten.se \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®