From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f100.google.com (mail-qv1-f100.google.com [209.85.219.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65631221FBD for ; Mon, 3 Nov 2025 23:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762210831; cv=none; b=svL/F01u+2wBSXTSTM6XcdvkjX5fr9SF3PEqt5xQSRsRIZSdFTi3Ri6xZvcDR3RHJpdsJikNXIj+tr07j8aQrmeiCZEuQWZG1FORTblg0GzQ2H9DU7v/ssxcn+TzE+UVU3uKm1euOPnig76ns7TYWV8SXa5Xg/InwxcSyIe2+Os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762210831; c=relaxed/simple; bh=/lW1HzddLQUZKeF4KgnyJzqj0WHWuf2zCzjsyTOf8II=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PBZxNhteCHlB8P171wvFRW8RuoBjHYG9PrrhbvSzMRRMmhvuXAYW9NqPT9xG+GBbvmTASEPd+8NCkOezkHEQtBdpQWpaiKGR3ZT7iuZm2KH5AaIRyT2IJHYnyE5YYFO82vOVdTzJYE5PX8Mr2OWtA1bzSrsfoVC27YOafE7QzVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VNu3ql3y; arc=none smtp.client-ip=209.85.219.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VNu3ql3y" Received: by mail-qv1-f100.google.com with SMTP id 6a1803df08f44-88033f09ffeso38466376d6.1 for ; Mon, 03 Nov 2025 15:00:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762210827; x=1762815627; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0id5Lo+9IJ6LPYuXiU1WqYasBQQKw7fISIlar/OOWY=; b=QlRWEF5dOZfyCdyCuQ63UG01mrhtkfbMwuwjObrw9hORD6U5ZBApWtAYtqBnoKQt8r XybnOUS90Kb7KoZUP2r0Sx01ZnRfPS/kGYEtqwgTOS8biggNOwZMHa+fR98SJQdxZPlT K5J422V0veCPgYOM3Hg+ndSNS/xgPb+gvOrzwjFl3YUoDPYdX/5V/EWx2qfghvsDLXWt CVSgsgVjgLV3/LU+HeMA+y3+u3gg8yYXtI4mz9m6a6kb/0sIX5v1KuxuLxY1ilUj/d9o 7LNuUvPVenM/gaucxOQfvOUYFQUEDENgUq2af3S1y/A3T2bq47Iav5OmOvaxai+48h8y 1oUQ== X-Forwarded-Encrypted: i=1; AJvYcCWI4eGsFWLSVdCbYOyuFnnwCmhG02lgab6H6VyltpF0wfD3ngO+77819fXN1mw89bi7yJM9feTwSJ76QSs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2hYQFJzhGLq36hrPici4PQ3/WoVtRV1fA3T783Bkb8yYeiHQh Zmenv7abCp0ffdneh/nAkxytoI0tUtDdpnzwymehFtzGKkqZub2kSNsSNudEC10o1moIefM5y7i kBiPbP4JqJk1fNSO+x3JzUAQunGmtTygVp11iv8GZbjAXx/4kjxTUMtdHwhJhtJdfV8OTNhv3AT WXTLKXL1/IRISTLT66K+swDaZIwrkjwv7w5pFhc0SLRikRInSNDPt5B5ih5LdNI3g/k4IFbh5Q9 /qOQzboBFwdMWfyY9E9EHII X-Gm-Gg: ASbGncvRjJVA9VzPpXiW7F34MLmGPI4bptfZzsE8+Rw+vqCN+KlKxn7TuemRZn7ZX0d 1iaWW8mEd18Y1wQi1wrjZ9hDPehFX42F3CKuaM4lI6xQEk7puEwiJeQlk8ErK4W12LQeSKrO2d6 IR9Ovbc9/rad33+woUk1Z/kj4QbS1Rup8BP+y3F14ed01My3sxeSpkB4f0LRWOi+Rrs8Cqt4p7K piVwXfntEHWTTB4DFwmfVovmyl0qtnfTejMQCYOFu6D1a6nHxr9pKWYJrP3N6e8Op/e3SF7vvT0 arqAmaH5oOqrBeUdoSoVYPnKnDgeF6EFb8xg53+cQ/CfOlmsd04piXpdg7yad9OdlfBowxg3926 JaaDGKQWlfmOOYU7wJHUkJ/JlorUipE3iiqoD8rVFIVZjNdOuqyygM0L1tRoib7EfGg42IPeXW/ +jHWQgVMuzNSBBJuP5j9Er8+f3gQJsfRtZuLZjJDI= X-Google-Smtp-Source: AGHT+IFHYomdQIuTaElNAbCKfdrwhP9xPFRmxpbzPhlRpUZo1BlQ8pCW2bTuQLlB0oIO78ON5rogPk7+5FTQ X-Received: by 2002:a05:6214:23cb:b0:87c:81f:6200 with SMTP id 6a1803df08f44-8802f2fc737mr199482866d6.28.1762210827069; Mon, 03 Nov 2025 15:00:27 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-12.dlp.protect.broadcom.com. [144.49.247.12]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-88060e6b603sm1152986d6.31.2025.11.03.15.00.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Nov 2025 15:00:27 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3408686190eso8164202a91.3 for ; Mon, 03 Nov 2025 15:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1762210826; x=1762815626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=K0id5Lo+9IJ6LPYuXiU1WqYasBQQKw7fISIlar/OOWY=; b=VNu3ql3yF8SSISfjeMpLYfivd5rcw9bI9vtjhG77AtnS/+0wl+5A0Bynp4+5SmDdH5 O/OD17FHe6LbNe9VjDnPl/3HC4cceSz5DeuplLSpAG5bgQ7Yo5SgNM4pb9AgLjZE8f08 mccfalVNK3wrKHPsQZxrBaqLj4RlKydsfIh/w= X-Forwarded-Encrypted: i=1; AJvYcCU18KwrbQVrMtvC33QgNNPyxxQK3ozW5TZ0PXKwZxVOnDy1QJXLluxkus4sbYLUS1hOsP6ifp5/ln9qHYg=@vger.kernel.org X-Received: by 2002:a17:90b:50c3:b0:33e:30b2:d20 with SMTP id 98e67ed59e1d1-3408309e698mr16646443a91.33.1762210825700; Mon, 03 Nov 2025 15:00:25 -0800 (PST) X-Received: by 2002:a17:90b:50c3:b0:33e:30b2:d20 with SMTP id 98e67ed59e1d1-3408309e698mr16646400a91.33.1762210825276; Mon, 03 Nov 2025 15:00:25 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3417bcb9faasm155726a91.1.2025.11.03.15.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Nov 2025 15:00:24 -0800 (PST) Message-ID: <1ce81ce5-1c09-4663-915b-16ee58e19035@broadcom.com> Date: Mon, 3 Nov 2025 15:00:21 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/2] net: bcmgenet: Support calling set_pauseparam from panic context To: Andrew Lunn , Florian Fainelli Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Doug Berger , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stanislav Fomichev , Antoine Tenart , Kuniyuki Iwashima , Yajun Deng , open list References: <20251103194631.3393020-1-florian.fainelli@broadcom.com> <20251103194631.3393020-3-florian.fainelli@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 11/3/25 14:19, Andrew Lunn wrote: >> @@ -139,7 +141,8 @@ void bcmgenet_phy_pause_set(struct net_device *dev, bool rx, bool tx) >> linkmode_mod_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydev->advertising, rx); >> linkmode_mod_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, phydev->advertising, >> rx | tx); >> - phy_start_aneg(phydev); >> + if (!panic_in_progress()) >> + phy_start_aneg(phydev); > > > That does not look correct. If pause autoneg is off, there is no need > to trigger an autoneg. > > This all looks pretty messy. That is pre-existing code, so it would be a separate path in order to fix, though point taken. > > Maybe rather than overload set_pauseparams, maybe add a new ethtool > call to force pause off? Yes, I like that idea, that way it is clear which drivers support disabling pause from a panic context. > > It looks like it would be something like: > > struct bcmgenet_priv *priv = netdev_priv(dev); > u32 reg; > > reg = bcmgenet_umac_readl(priv, UMAC_CMD); > reg &= ~(CMD_RX_PAUSE_IGNORE| CMD_TX_PAUSE_IGNORE); > bcmgenet_umac_writel(priv, reg, UMAC_CMD); Yes, that is essentially what needs to be done. Thanks! -- Florian