From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936255AbcISARn (ORCPT ); Sun, 18 Sep 2016 20:17:43 -0400 Received: from icp-osb-irony-out6.external.iinet.net.au ([203.59.1.106]:18791 "EHLO icp-osb-irony-out6.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbcISARg (ORCPT ); Sun, 18 Sep 2016 20:17:36 -0400 X-Greylist: delayed 556 seconds by postgrey-1.27 at vger.kernel.org; Sun, 18 Sep 2016 20:17:36 EDT X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DDAgBeK99X/zXSMGcNUBoBAQEBAgEBAQEIAQEBAYM6AQEBAQGBH1KjOAaTI4QShh4CggEBAgEBAQEBAoFGEgGEDgEBAQMnUhALDQsuVwYBDAYCAQG9PY0IAQEBAQEBAQMBAQEBAQEhhW2CRoJYiiABBJluAZlYhW5IkBeDUxuBYmCEaoJBAQEB X-IPAS-Result: A2DDAgBeK99X/zXSMGcNUBoBAQEBAgEBAQEIAQEBAYM6AQEBAQGBH1KjOAaTI4QShh4CggEBAgEBAQEBAoFGEgGEDgEBAQMnUhALDQsuVwYBDAYCAQG9PY0IAQEBAQEBAQMBAQEBAQEhhW2CRoJYiiABBJluAZlYhW5IkBeDUxuBYmCEaoJBAQEB X-IronPort-AV: E=Sophos;i="5.30,359,1470672000"; d="scan'208";a="268934012" Subject: Re: [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL To: Masahiro Yamada , linux-m68k@vger.kernel.org References: <1474221674-21625-1-git-send-email-yamada.masahiro@socionext.com> Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , Geert Uytterhoeven , linux-kernel@vger.kernel.org From: Greg Ungerer Message-ID: <1ce86362-df47-bbb4-3f44-1f65fb340aa3@linux-m68k.org> Date: Mon, 19 Sep 2016 10:08:17 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474221674-21625-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On 19/09/16 04:01, Masahiro Yamada wrote: > In many of clk_disable() implementations, it is a no-op for a NULL > pointer input, but this is one of the exceptions. > > Making it treewide consistent will allow clock consumers to call > clk_disable() without NULL pointer check. > > Signed-off-by: Masahiro Yamada > Acked-by: Greg Ungerer I will apply to my m68knommu git tree (for-next) branch. Thanks Greg > --- > > Changes in v4: > - Split into per-arch patches > > Changes in v3: > - Return only when clk is NULL. Do not take care of error pointer. > > Changes in v2: > - Rebase on Linux 4.6-rc1 > > arch/m68k/coldfire/clk.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c > index fddfdcc..1e3c7e9 100644 > --- a/arch/m68k/coldfire/clk.c > +++ b/arch/m68k/coldfire/clk.c > @@ -101,6 +101,10 @@ EXPORT_SYMBOL(clk_enable); > void clk_disable(struct clk *clk) > { > unsigned long flags; > + > + if (!clk) > + return; > + > spin_lock_irqsave(&clk_lock, flags); > if ((--clk->enabled == 0) && clk->clk_ops) > clk->clk_ops->disable(clk); >