From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753859AbcITJXI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Sep 2016 05:23:08 -0400
Received: from arroyo.ext.ti.com ([198.47.19.12]:46006 "EHLO arroyo.ext.ti.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752720AbcITJXH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Sep 2016 05:23:07 -0400
Subject: Re: [PATCH] drm/omap: fix return value check in dsi_bind()
To: Wei Yongjun <weiyj.lk@gmail.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>
References: <1474127634-14436-1-git-send-email-weiyj.lk@gmail.com>
CC: Wei Yongjun <weiyongjun1@huawei.com>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <1ce98e3e-3c56-9480-dc0b-66f8ca24f0ca@ti.com>
Date: Tue, 20 Sep 2016 12:22:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474127634-14436-1-git-send-email-weiyj.lk@gmail.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/17/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index e1be5e7..a567ebd 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -5342,7 +5342,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->phy_base) {
>  		DSSERR("can't ioremap DSI PHY\n");
>  		return -ENOMEM;
>  	}
> @@ -5362,7 +5362,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->pll_base) {
>  		DSSERR("can't ioremap DSI PLL\n");
>  		return -ENOMEM;
>  	}
> 
> 
> 


-- 
Péter