Re: [PATCH 0/6] Start of Upstream Support for TUXEDO NB02 devices

[Armin Wolf <W_Armin@gmx.de>]

Am 17.11.25 um 14:23 schrieb Werner Sembach:

> With the Uniwill driver from Armin now accepted I want to push the first
> big addon to it that I worked on in parallel.
>
> First this adds all current Tuxedo devices to use at least the input part
> of the new driver.
>
> Second it adds a new feature for cTGP control on Uniwill devices with
> NVIDIA GPUs and enables that on the TUXEDO devices.
>
> I have not yet enabled the other features in this driver for TUXEDO devices
> as they either don't apply (Uniwill did a line with Intel that behaves a
> little different to the rest of their ECs and that line is what the features
> Armin added are based on) or are, as of now, untested.
>
> There are plenty more features currently implemented in the out of tree
> tuxedo-drivers dkms package that I plan to port over one by one, but as
> always: No ETA given.

Very nice, i think that especially the cTGP control feature will be very popular with users.
I am also currently working to add fan table (aka "universal fan control"), PL1/PL2 power limit
and platform profile support to the driver, so you might be able to reuse some of that
functionality for your devices.

I think that we can merge the first two patches in the near future, but the remaining ones
dealing with the DMI table and cTGP support need some more work. What kind of control does
your software (Tuxedo control center) need over the cTGP values? I am asking because Intel
devices have fixed cTGP values for each platform profile. If your software does something
similar, then maybe we can integrate this into the platform profile mechanism.

Thanks,
Armin Wolf

>
> Werner Sembach (6):
>    platform/x86/uniwill: Add TUXEDO devices
>    platform/x86/uniwill: Handle more WMI events required for TUXEDO
>      devices
>    platform/x86/uniwill: Implement cTGP setting
>    platform/x86/uniwill: Make uniwill_dmi_table accessible in probe
>    platform/x86/uniwill: Run callbacks of uniwill_dmi_table
>    platform/x86/uniwill: Set cTGP support based on EC for TUXEDO IBP Gen7
>      MK1
>
>   drivers/platform/x86/uniwill/uniwill-acpi.c | 546 ++++++++++++++++++--
>   drivers/platform/x86/uniwill/uniwill-wmi.h  |   2 +
>   2 files changed, 502 insertions(+), 46 deletions(-)
>