From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A1C0CCA47E for ; Thu, 2 Jun 2022 06:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbiFBGHU (ORCPT ); Thu, 2 Jun 2022 02:07:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbiFBGHS (ORCPT ); Thu, 2 Jun 2022 02:07:18 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 423DC115A49; Wed, 1 Jun 2022 23:07:14 -0700 (PDT) X-UUID: 64c8e88d33264b52b7a459e9a3d61e39-20220602 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:e0c906d2-7aec-498a-8a7c-523da98f9ed9,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:e8cb910d-3a0d-4bbe-9d72-0e5d26d57423,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 64c8e88d33264b52b7a459e9a3d61e39-20220602 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1097358930; Thu, 02 Jun 2022 14:07:09 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 2 Jun 2022 14:07:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 2 Jun 2022 14:07:05 +0800 Message-ID: <1d07579c0a6b8853ab72e345a0bd0be73549de8c.camel@mediatek.com> Subject: Re: [RESEND v12 0/3] mmc: mediatek: add support for SDIO async IRQ From: Axe Yang To: Ulf Hansson , Rob Herring , Chaotian Jing , Matthias Brugger , Adrian Hunter CC: Yoshihiro Shimoda , Satya Tangirala , Andy Shevchenko , Wolfram Sang , Lucas Stach , Eric Biggers , Andrew Jeffery , Stephen Boyd , Kiwoong Kim , Yue Hu , Tian Tao , , , , , , , Date: Thu, 2 Jun 2022 14:07:04 +0800 In-Reply-To: <20220525015140.384-1-axe.yang@mediatek.com> References: <20220525015140.384-1-axe.yang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Gentle ping for this set. On Wed, 2022-05-25 at 09:51 +0800, Axe Yang wrote: > Changes in v12: > - assign NULL to pins_eint directly instead of using kfree() > > Changes in v11: > - remove '_irq' suffix in interrupts-names property > - fix yaml example build error > - refactor msdc_enable_sdio_irq(), free pins_eint if async irq is not > supported > > Changes in v10: > - add sample node for SDIO host which support wakeup interrupt in > yaml > - skip MMC_PM_WAKE_SDIO_IRQ check before enable SDIO async interrupt > - add MMC_PM_KEEP_POWER check before SDIO eint pinstate parsing > - use dev_pm_set_dedicated_wake_irq_reverse() to correct irq control > sequence > - set dedicated irq in msdc_enable_sdio_irq() rather than > msdc_drv_probe() > - remove unnecessary wake irq control, rpm/dpm system shall manage > that > - move wake irq/msdc irq control back to system suspend phase, use > rpm_suspend > and rpm_resume to ensure irq control sequence: > disable msdc irq -> enable wake irq -> disable wake irq -> > enable msdc irq > - simplify variables, check pins_eint to know whether wakeup settings > are managed > > Changes in v9: > - remove pinctrl "state_dat1" > > Changes in v8: > - remove maxItems property under pinctrl-names property > > Changes in v7: > - add device_init_wakeup() to register SDIO host as wakeup source > > Changes in v6: > - abandon cap-sdio-async-irq flag, use wakeup-source flag instead > - extend interrupts and pinctrls in mediatek mmc host controller DT > documents > - add mmc_card_enable_async_irq() to access enable_async_irq flag > - simplify wakeup irq implementation with dedicate wake up irq > related interface > > Changes in v5: > - resort variables to reversed xmas tree order > - restore old copyright year range and add current year back > > Changes in v4: > - add MMC_CAP2_SDIO_ASYNC_IRQ judge before lookup eint pinctrl > - replace spin_lock_irqsave() variant with spin_lock() in eint irq > handler > > Changes in v3: > - correct abbreviations with capital letters in commit message > - replace copyright year with 2022 in mtk-sd.c > - remove unnessary pointer casting > - adjust variable order to reversed xmas tree > - remove a redundant blank line > - refine if statement, following standard pattern > > Changes in v2: > - change flag name from 'cap-sdio-async-int' to 'cap-sdio-async-irq' > - change corresponding macro names from xxx_INT to xxx_IRQ > - resort new member in msdc_host structure > - refine function msdc_request_dat1_eint_irq() > - rename msdc_{suspend,resume} function names, add suffix '_noirq' > - add MMC_CAP2_NO_SDIO judgement before parse eint related pin > setting > > Axe Yang (3): > dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties > mmc: core: Add support for SDIO wakeup interrupt > mmc: mediatek: add support for SDIO eint wakup IRQ > > .../devicetree/bindings/mmc/mtk-sd.yaml | 50 +++++++++++- > drivers/mmc/core/sdio.c | 14 ++++ > drivers/mmc/host/mtk-sd.c | 80 > +++++++++++++++++-- > include/linux/mmc/card.h | 8 +- > include/linux/mmc/sdio.h | 5 ++ > 5 files changed, 149 insertions(+), 8 deletions(-) >