From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672B92BD00C for ; Wed, 8 Apr 2026 08:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775638405; cv=none; b=KwVN04PAVSd8ZfqmmoGRzWKwWWSYPoXKEI9HpJMdnzZuMm86E5Dqg5T3vV9xOlfNt4WhfmBYH+K3rUpqTL6k+eH6ymve+iBussJ/kr9wusKF6rMPBhnHhJnq+iRjxE3Z1DxLtyaaYEZNY1dyuy2w8e0aQ/F8ycVNCVAxST2Bq3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775638405; c=relaxed/simple; bh=V8rXhEyN76cQYM9BF6KVpbO+9KEPhf/L+9trOmefMsE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p2vap2z2BLWKupWGHZC0tRbdLr+EIWmvw4Ogs8OkpajVjHr9Ofhia0N9ewHXmDrVOQF8SYRt5RQSTpkQS8SRPD51zD3FBMz3RP+0Yh/Xm/b7+yp/BRsnNXHplex1OCELlLjxJCkH7UKjfcthfUxncPUHgub+CGrCIMkD6ZCVjtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UwKqe6w9; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UwKqe6w9" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c742b9b7727so286078a12.0 for ; Wed, 08 Apr 2026 01:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775638402; x=1776243202; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q0O2gUMwG94qjNO3Rau2fy1EWrjPL+RirtTuaeXZuXI=; b=UwKqe6w9SITF1q1HyeBG8Lcjn4qeWNBJ1bCJJ94YVYkPonBBOKhDJFEIA2vjbby8j3 Os1x0ia8xsP5+DHlmXMvuoCGuC4fSZ3reRK0Kt2I9WbZv7Ho/nngdbA2fFpQhE7AelJs KmPi+SS/dkJeQlpBiJ9X37/InkS5Yj7LmfsA9oLhfr29E9VbexSTj3LJFD2ou8Bd6EEs C3vEQIbowiXBb6nbggZ/z6IGzRXte0kiQonIKjZd2L9DMts4W/D+cGsZMHFizVywnPuq 8FMYqDTHzgUQi4Mo1T4Pc6Qzj6cF7uBQMccqtdoap5y4eWIirLdEwG6vQJ5PrlqoFqFQ 5rZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775638402; x=1776243202; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q0O2gUMwG94qjNO3Rau2fy1EWrjPL+RirtTuaeXZuXI=; b=GCQtFml8C/gUtIEO3+UwbL06Rnszlqm2wDKiW7YMSvum8YvMVd10wdoreDcFW6nrir Tmn8PhVDt4x8AcsBXADIgfYhk3+pSzK1IvLoiO4cL8GVbRQ/VTqHR6jOnQqmvutWN4+B mxOc01TcEnjeHA04FtVEZahD5OYmRkFdDZuFfUYzlvu3zw0UGzG7zN1RixghHa9lIOwr 9UP5Zto18AaSPCS6PRueCRTF+kvjFzjquSiqqLEd9wLFI/s+EbfhOTx+tktEknzA8t9R yW4maXVZHObGY1j9fO3dQ/brx+6IQEMu+b2xtsoWfScbXTjiKC+aTGFVUSStM12vq1MU ihKQ== X-Forwarded-Encrypted: i=1; AJvYcCXiZsP/zIRIsRLflcPo51WpxL5YmTZALUhwO7/tKuMmf7zoqXIXIXQ0QSePDeXiAycAmiblPVVxTPU43d4=@vger.kernel.org X-Gm-Message-State: AOJu0Yym1q2J+08w3I3IQqxHGhu6ZW5cdyZN0E0WD27Lzppi5i03VE5p dFhR2yFpkxhBasj0tu4sWfFK40C00O9FkTi48znOCpCZT8N0ZZjR+Idb X-Gm-Gg: AeBDieuYO0AHtaG4wxmDCmEMTZdnDstM8v/wpMK1zC4n+lSWxXBfHUoc+mVOFLujYg3 /tHpNB+1y9WJP8sKJH/xgSTfJ8TA1jtWHQxqcrc20XPFdhShYdKCbs5yRc4kyqJ9OhKdPdkDj69 NA7xyGisR1j+cl3zR8T4Kznq/igKLzZ8owH+B5jKJTDQ0ieQkpPQPexMRU8Egb8lvpgPoWJ6tpW cXWsWf6T1zdw64KfK/BSGWJaZk/g5CHzbn095AtC3YMBwChe/4bUctmMXu5AtTa3nJQQuCyuBGc 7KoRy6vj1YrW1OyXNrgVXOLklxQqBhTSHSgP77d6LusznhOT2Kt9CDpTLnjfEykaFJYbMlKwYk6 kcw8SaNcSAwoPvRcOvzkeUTT3gx0+XjXBO3qi5C9/4iaQGEN2wrGn++vHlOZQd8fX56FA3XjKt4 Ju9J7rRWd6ahyMyrzXMsMVJGt7NUF+4uB+KyLaBzQkLiYymwRs3+2QSczRC4Pg X-Received: by 2002:a05:6a20:12cb:b0:39c:212c:9088 with SMTP id adf61e73a8af0-39f170ded85mr3378151637.20.1775638401563; Wed, 08 Apr 2026 01:53:21 -0700 (PDT) Received: from [172.20.10.2] (42-77-205-177.emome-ip.hinet.net. [42.77.205.177]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c65995a9sm17556167a12.27.2026.04.08.01.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 01:53:20 -0700 (PDT) Message-ID: <1d0863b2-64f4-9f2f-94a3-3d730e9638f2@gmail.com> Date: Wed, 8 Apr 2026 16:51:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] ASoC: nau8325: Add software reset during probe Content-Language: en-US To: Cezary Rojewski , Neo Chang Cc: perex@perex.cz, tiwai@suse.com, krzysztof.kozlowski@oss.qualcomm.com, dan.carpenter@linaro.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kchsu0@nuvoton.com, broonie@kernel.org, lgirdwood@gmail.com, linux-sound@vger.kernel.org References: <20260408052639.187149-1-YLCHANG2@nuvoton.com> <08462a39-61e2-4125-957e-9454751b011e@intel.com> From: YLCHANG2 In-Reply-To: <08462a39-61e2-4125-957e-9454751b011e@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/8/26 16:07, Cezary Rojewski wrote: > On 2026-04-08 7:26 AM, Neo Chang wrote: >> Currently, the driver only performs a hardware reset during the I2C >> probe >> sequence. To ensure all internal states of the codec are properly >> cleared >> without affecting the configuration registers, a software reset is also >> required. >> >> According to the hardware specification, writing to the Software Reset >> register (R01) twice will reset all internal states safely. >> >> This patch adds the nau8325_software_reset() function, executes it right >> after the hardware reset in the probe function, and marks the R01 >> register >> as writeable in the regmap configuration. > > The first two paragraphs explain the situation, I'd say the third is > redundant. Not a reason for a resend though, only something to consider. > > Reviewed-by: Cezary Rojewski Thank you for the review and the advice on the commit message. I will keep it in mind for the next time.