From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD710274B32 for ; Mon, 24 Nov 2025 10:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980545; cv=none; b=cofLuEQEQfRioUhWeZ+uEGCMzXnzQy0PZIhs9K2ZYeAozM0PIRjnX9dBbvrdOUVJofFkmnjTWaqa4pUI1MJDLxJg9MJVcjqnIlKfNCnOwjhb/YgqSbXxF+pfjfA8IXbCOgjN0qLwQw/mxb6ZpCSClazijQicE21DWv0CKfZmalI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980545; c=relaxed/simple; bh=6OTESRwNLxScQU78nE0ggduh/VNF1NB1gn02JAFvRw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cl7ktHJz6PaxoWjNLZJBzwdSFtoXG95uA/omLOE88cITK+dFnu6+XTjBEzE8ttn8AK9pUm5qnwOhcBfsPQhyuvf2NVM1MCwp1FkSc44yJZr9rTQxSrknJlW/3oc3Rw6+LfzKXr6NAjH8BkWSqUJenDJHk1K2RdesLwFGPCBLPUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ev55sLRo; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ev55sLRo" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47755de027eso21552745e9.0 for ; Mon, 24 Nov 2025 02:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763980542; x=1764585342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=HAIKS+tQIq5G6QZu607XSH9VxwKXNkvRuOzR0ldY0uA=; b=ev55sLRoYF56iaaiQzkmZIxhxlMccVSU4h0wQ4Dw1z66tFRDX5ljPUIlu+ouV9pWKm ycP9hLl8y1h9deOAdQgFDVpNhjhWRyfdCYBdGEHwCe74ZQO4S2VvDuMiIc5n6EsPZvO8 0HuPdrXJlnt9mkDcWQsMiy+tZzXM/x3OUEWyfTbSwSqCvCMxyeAIXwODDFL9WB0ae9OH 9FTMFgQCZrYoA6+Y1Z4rBcCeXkV/UnD//YFBFfXQUZmxCzgSZ+QJXMXv1SHFiQt6wxYO 2Z0LvH3IC7usDlq7KjkBX7Ky2wYHLbBdGU7ILRepIKJQ4KbSPb7cAkl6iLDa2/Ym+zLM F3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980542; x=1764585342; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HAIKS+tQIq5G6QZu607XSH9VxwKXNkvRuOzR0ldY0uA=; b=a38l6UUfPW4njEuc1Z0plp3ilnlBa2KbD1DHfEO+LMZOKpb0tFzwScGDxHQaWZvKOO AK8VUEXsxYfdzdutRcaZSLWlhiTZOEV5Uxld0PTrkyZlX4BSJa8VBytscuS/N9ZzvgDD A6KGYKxXGFEzO7ZHam3mfbkoc8DsLjQiqdxzR171BjazwpiFYpAeOHzpfvGYHFmaa3Wd YVmrBE+XCypEVShb1mW/m9VjXbS8j4ijutoKXcCKkqBfytHajcA2IBGozukgyEovd49A VW9mLVS5UZ1EPi04BouNrrO4ndFx3BqnYjOxPzaVgMX9QaorKj1w0g+ggw/8fj1uSAzp Piiw== X-Forwarded-Encrypted: i=1; AJvYcCX0SZaCaQE+4bW8TT37AYj2uaOvA9fv0SNcsM6tIOwJ1Znf1cv+iq3ijER98zVGCfgxLWrDA1c5w3dSH5U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7aksskscypV0oIK+Z5qR4+DYG3XfFoqvomWdpwDw0l8gSKVMG bSwHntOizacG/w2d2Nbshd+2Nwl/ZMGja+HjrGJd9zVsBXkVPHfwjTQD3bnotQgMmNk= X-Gm-Gg: ASbGncsvFUoyXxAsxYEXjyw9ncd1gUTfxwB7kjZP7EF8drBMH9mpvC/E+wSKkWG5qOR liXhKPl99ZJqucp1z4ijRi8jReDirXure51dN7ZPhcak691coGGk4TE2Qsh1uAYhePlHHObd2oR KlRpRFRxfbIDX+sLEfZgFeanR1gTngMIg0FrqRqbZfNW1Ay7yTSjYCuG4kSR9x30vtpKU5kMlqe WQHeWKRFcpf3j8RFtwXt07uwnvdag1PfPf7b/QRsgqELilfs5xw06O9BGJDo+90iK794ZHRAFHB bfn68LBHxL3PfnqbQh+dF7KTK/7Whqh5QxQe1mZKPRyANuTbfdA3bEFUZnDSI2u8YhtVkVPbZV1 YchBa5c9WD79Zucd8vzqMKt3HMdGyXShRI7pieN/iO8+a4CmYlG1MIZSVlzB+7O4QcysCRZrAYu +rZPlOF7AbA/QHVqSNJPczRHIHxOOAGE1jEnybYifykmnzG1utcvtKmUMCy8lWfhyg8/g7OzrS8 Q== X-Google-Smtp-Source: AGHT+IHGv4bbS+3bVyw0pYcsA3BeS6dNhxGlltqoLwAE51qnNbKpUpuxJhUkaEhMz5T/wEJo8trcPQ== X-Received: by 2002:a05:600c:a01:b0:477:7f4a:44b0 with SMTP id 5b1f17b1804b1-477c01f5980mr97488605e9.33.1763980542060; Mon, 24 Nov 2025 02:35:42 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:ab13:96f5:1459:8396? ([2a01:e0a:3d9:2080:ab13:96f5:1459:8396]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9dbec2bsm150012445e9.5.2025.11.24.02.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 02:35:41 -0800 (PST) Message-ID: <1d0ccc76-bc19-4446-926f-a12a16a3f88e@linaro.org> Date: Mon, 24 Nov 2025 11:35:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v1] phy: fsl-imx8mq-usb: fix typec orientation switch when built as module To: Franz Schnyder , Vinod Koul , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Franz Schnyder , linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Francesco Dolcini , stable@vger.kernel.org References: <20251124095006.588735-1-fra.schnyder@gmail.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251124095006.588735-1-fra.schnyder@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/24/25 10:50, Franz Schnyder wrote: > From: Franz Schnyder > > Currently, the PHY only registers the typec orientation switch when it > is built in. If the typec driver is built as a module, the switch > registration is skipped due to the preprocessor condition, causing > orientation detection to fail. > > This patch replaces the preprocessor condition so that the orientation > switch is correctly registered for both built-in and module builds. > > Fixes: b58f0f86fd61 ("phy: fsl-imx8mq-usb: add tca function driver for imx95") > Cc: stable@vger.kernel.org > Signed-off-by: Franz Schnyder > --- > drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > index b94f242420fc..d498a6b7234b 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > @@ -124,7 +124,7 @@ struct imx8mq_usb_phy { > static void tca_blk_orientation_set(struct tca_blk *tca, > enum typec_orientation orientation); > > -#ifdef CONFIG_TYPEC > +#if IS_ENABLED(CONFIG_TYPEC) > > static int tca_blk_typec_switch_set(struct typec_switch_dev *sw, > enum typec_orientation orientation) Reviewed-by: Neil Armstrong