From: Antonio Quartulli <antonio@mandelbit.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Alice Mikityanska <alice.kernel@fastmail.im>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] udp_tunnel: don't treat IPv4 sockets bound to an address as wildcard
Date: Thu, 12 Nov 2026 10:05:51 +0100 [thread overview]
Message-ID: <1d0d447f-f458-4eec-8b63-80119fee618b@mandelbit.com> (raw)
In-Reply-To: <avVVzxL3pVZc6yQ5@google.com>
On 12/11/2026 07:02, Kuniyuki Iwashima wrote:
>> diff --git a/net/ipv4/udp_tunnel_core.c b/net/ipv4/udp_tunnel_core.c
>> index a128fe85620d..29581c94fdcf 100644
>> --- a/net/ipv4/udp_tunnel_core.c
>> +++ b/net/ipv4/udp_tunnel_core.c
>> @@ -62,10 +62,10 @@ EXPORT_SYMBOL(udp_sock_create4);
>> static bool sk_saddr_any(struct sock *sk)
>> {
>> #if IS_ENABLED(CONFIG_IPV6)
>> - return ipv6_addr_any(&sk->sk_v6_rcv_saddr);
>> -#else
>> - return !sk->sk_rcv_saddr;
>> + if (sk->sk_family == AF_INET6)
>> + return ipv6_addr_any(&sk->sk_v6_rcv_saddr);
>> #endif
>> + return !sk->sk_rcv_saddr;
>
> This is identical with inet_rcv_saddr_any(). As a follow-up
> in net-next, please move sk_saddr_any() to include/net/sock.h
> and use it everywhere.
Yes, indeed.
Ok, I'll add it to my todo list.
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Thanks!
--
Antonio Quartulli
CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com
prev parent reply other threads:[~2026-11-12 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:33 Antonio Quartulli
2026-11-10 11:36 ` netdev-bot+sinfo
2026-11-10 13:11 ` Antonio Quartulli
2026-11-12 6:02 ` Kuniyuki Iwashima
2026-11-12 9:05 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0d447f-f458-4eec-8b63-80119fee618b@mandelbit.com \
--to=antonio@mandelbit.com \
--cc=alice.kernel@fastmail.im \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®