From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE982C7EE22 for ; Wed, 3 May 2023 08:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjECIHf (ORCPT ); Wed, 3 May 2023 04:07:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbjECIHU (ORCPT ); Wed, 3 May 2023 04:07:20 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B0034ECF for ; Wed, 3 May 2023 01:06:53 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-50bc1612940so7508559a12.2 for ; Wed, 03 May 2023 01:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683101175; x=1685693175; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+G17ZsMzCzeBMf7ULMEUmCtH+I4A/5ex+N+NoPJ79/w=; b=nFsPDw8lMir0ASfgMqpvhF8EIj0opp4WEaIn9hbUCfmENKvoRlw7FGbkVWMBENO2zg v6/V/0s+MAsz4UsyXPRf/h6ManZrOUZf+uLgeQWYMB8M2C5TIN0lJ444LFKqRnbDQ4wZ b3elsmByE2hI3D4jNdnztDLnk+g1b72HYn3QkFHDA6ZA3flrRJy0Nv/PsBBIudxYHL9X iqxBBqdw7hwojN+w9BWVP2H7ez4WlOOV88NLNSCNR7ucDjD9vqfg+T++iGhHZ9ixkbIu Ge6T7m3Aot4q8AS0bdKLAUtet9SCvufQ3goRNAF+i5qOyN8pRzZ7/e3yffED/1qcAT1T z1ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683101175; x=1685693175; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+G17ZsMzCzeBMf7ULMEUmCtH+I4A/5ex+N+NoPJ79/w=; b=jFeFv+8Oi4NWflZsHxSm9UQtN+gXcrSdVHvcelp4ofHkyBEp9IiBI04+wZmSjHvYcW /Vpj8fJ6L/KOXiXFC/ivYVhAL1vOMCv5g2E8QccA4+S+7SxWLS9ClkxPfgG+TQTY94c9 1iz4zc1zeQB6YmSuyfEqVvS6Vl/smTgN4jOuiEd/IFT/NX8Rpr0HWNgjlX6E3eQ3oYzQ VFPm4rMZDn6hrrdEbr6TXGQQ2ODb9tixYXfjiSvha7odT5qqNTl1TkGYzq0rpU7v6x+e g+SqjqNFw5GnswHeRDmplHLmnflmmLVtQBIzBWp+PTi1jZ7ElGr6/PZkZDJ6VVoZuuax dFFA== X-Gm-Message-State: AC+VfDw1NYhTixebSJ3nlt0CCbxhzE8lDOVe6FNjByD7m5pH+akTYJBy 2R8I7r5evXxAmXHiOSbS17VnFQ== X-Google-Smtp-Source: ACHHUZ6h60JRSNlVpv4EILvZzP54b1DdbOEWlsvNUVwPODCG38P7s4mE7/sDCi+z44gOt/u1fRYunA== X-Received: by 2002:a17:906:fd87:b0:933:4d37:82b2 with SMTP id xa7-20020a170906fd8700b009334d3782b2mr2045098ejb.57.1683101175017; Wed, 03 May 2023 01:06:15 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a40b:9d8:1fa0:ecc5? ([2a02:810d:15c0:828:a40b:9d8:1fa0:ecc5]) by smtp.gmail.com with ESMTPSA id e1-20020a17090681c100b0094f67ea6598sm16942997ejx.193.2023.05.03.01.06.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 May 2023 01:06:14 -0700 (PDT) Message-ID: <1d11d36b-9cfa-4d39-c521-aab2153e49a9@linaro.org> Date: Wed, 3 May 2023 10:06:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] ARM: zynq: dts: Setting default i2c clock frequency to 400kHz Content-Language: en-US To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com Cc: Varalaxmi Bingi , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <4dde5d1eb8e4572dae4295a19a4c83002a58e5da.1683035611.git.michal.simek@amd.com> <958f4336-8c38-4cc1-4313-06a54e397d42@amd.com> <89276de5-ded8-2f38-bcea-708fdd35ca6d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2023 10:02, Michal Simek wrote: > > > On 5/3/23 09:40, Krzysztof Kozlowski wrote: >> On 03/05/2023 09:27, Michal Simek wrote: >>> >>> >>> On 5/2/23 22:13, Krzysztof Kozlowski wrote: >>>> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. >>>> >>>> >>>> On 02/05/2023 15:53, Michal Simek wrote: >>>>> From: Varalaxmi Bingi >>>>> >>>>> Setting default i2c clock frequency for Zynq to maximum rate of 400kHz. >>>>> Current default value is 100kHz. >>>>> >>>>> Signed-off-by: Varalaxmi Bingi >>>>> Signed-off-by: Michal Simek >>>>> --- >>>>> >>>>> arch/arm/boot/dts/zynq-7000.dtsi | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi >>>>> index cd9931f6bcbd..a7db3f3009f2 100644 >>>>> --- a/arch/arm/boot/dts/zynq-7000.dtsi >>>>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi >>>>> @@ -149,6 +149,7 @@ i2c0: i2c@e0004000 { >>>>> clocks = <&clkc 38>; >>>>> interrupt-parent = <&intc>; >>>>> interrupts = <0 25 4>; >>>>> + clock-frequency = <400000>; >>>> >>>> I think this should be rather property of the board, because it depends >>>> on I2C devices, right? >>> >>> We have 15+ boards with i2c connected and from this count I am aware about only >>> one configuration which is not working on 400k. >>> It is a question if make sense to update all boards (except for 1 and not all in >>> kernel yet) to 400k or just say 400k is default and if there is any issue use >>> lower frequency. >>> Obviously this patch is setting up 400k as default and let "problematic" boards >>> to setup lower freq. >>> The same approach was used for modepin description. >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/xilinx/zynqmp.dtsi?h=v6.3&id=53ba1b2bdaf7f481fdd878e9c18cd0e54081fac9 >>> >>> The next point is that 100k is default in Linux but doesn't mean it is default >>> in other projects. >>> >>> But if you think that it must be board property I think we should setup 100k as >>> default in this file too to make it clear. >> >> No, if it is conscious choice, it's fine. > > Is it Ack then or you want me to extend commit message? Ack, although you don't need my acks for your platform :) FWIW: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof