From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D2CC7EE22 for ; Mon, 1 May 2023 07:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232179AbjEAHVa (ORCPT ); Mon, 1 May 2023 03:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjEAHV1 (ORCPT ); Mon, 1 May 2023 03:21:27 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4EE0E62 for ; Mon, 1 May 2023 00:21:25 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9505214c47fso455747866b.1 for ; Mon, 01 May 2023 00:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682925684; x=1685517684; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dVepgCs67QhYF+S64LwI1sds6PcYZ4iqkhDG4bO/TQk=; b=Lt4G/nF6/vWSm70/OJY9L8lReXHWAXuoU2nTlVM5M0iX7otJ/oUOLEbFE3NHeQEu9k 5McUSTNOiR4Q/p7p9Yjagk7HpBL1xpEINFyHozBz8ZwVlMuRPH9v1s1oWpQGVdb2vEV6 +IdDb2u1+WQco+ELwRCF/8eO9+4NJ3Kwc5uhxtsobLYJPTPcl71eeMsaD6BoTkyu1AEf GLtNdHfQgWX3xS7rB8KQMkyqoYdNtQp96Ea49guBF8fmtvXxGC6ps5qdknpybWRRVHD6 oLuO0UQ1tFI9uTKHXU6lftF0gLaXY4rapOx/VrNY5LjvPTJffHRR1meq+lKzFW9a/dP5 4oSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682925684; x=1685517684; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dVepgCs67QhYF+S64LwI1sds6PcYZ4iqkhDG4bO/TQk=; b=av2uo9woHTJXeAG8ab3F41ia8K192KOkEJ+E51nUYUB1IO/3Ovwt6rPMWDnoA6CQKg q7pEQ4KOMcIFR8cZEe/JlHOru80agACgiWqMiQgJRE4mCFbzc1de2+l4QViyK/8oSjTj i2QWh072jdRgtVInbNkLgw22/4fqL6MfYfnr8z9C65gtoi4qEQ9YAcr6CILE1kPFX2YK kLgfFKJH+DDbOoVOwDgX+xa/M0pzmamiqf8z1a4u2kgUgk46X8k/Y+LsYGa628P0c4oq e98iZ0W16JNhNDNs/KENPkcrMQI86GXLiAg8IuP7ETU3l4deRLz4aOgf9khXoRKnbzoZ oN4w== X-Gm-Message-State: AC+VfDzYmxdi+7TauFHNvyhZZ5CRuv66z9o/jhqiV/9lucF4YtdutK3A aLRJdvd/SHU25/EYSm0GcTwkow== X-Google-Smtp-Source: ACHHUZ4+mJdUdaGf/klmpEAOu8cRfGyWI064D3ANXCd+js1/C+fb9SATKA4qJcXoaajnxZfbb2zbug== X-Received: by 2002:a17:907:970d:b0:90b:53f6:fd8b with SMTP id jg13-20020a170907970d00b0090b53f6fd8bmr13404942ejc.31.1682925684312; Mon, 01 May 2023 00:21:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:637a:fd0c:58fd:9f00? ([2a02:810d:15c0:828:637a:fd0c:58fd:9f00]) by smtp.gmail.com with ESMTPSA id gn2-20020a1709070d0200b009545230e682sm14276029ejc.91.2023.05.01.00.21.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 May 2023 00:21:23 -0700 (PDT) Message-ID: <1d187f41-ad9a-4e82-8557-20694a8294d0@linaro.org> Date: Mon, 1 May 2023 09:21:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 8/8] dt-bindings: Add rt5033 mfd, regulator and charger Content-Language: en-US To: Jakob Hauser , Sebastian Reichel , Lee Jones , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski Cc: Beomho Seo , Chanwoo Choi , Stephan Gerhold , Raymond Hackley , Pavel Machek , Axel Lin , ChiYuan Huang , Linus Walleij , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <5bd8b90713a61129acf292a941eb7fb5ccaa3db4.1682636929.git.jahau@rocketmail.com> From: Krzysztof Kozlowski In-Reply-To: <5bd8b90713a61129acf292a941eb7fb5ccaa3db4.1682636929.git.jahau@rocketmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2023 01:30, Jakob Hauser wrote: > Add device tree binding documentation for rt5033 multifunction device, voltage > regulator and battery charger. > > Cc: Beomho Seo > Cc: Chanwoo Choi > Signed-off-by: Jakob Hauser (...) > + > +required: > + - monitored-battery > + > +additionalProperties: false > + > +examples: > + - | > + charger { > + compatible = "richtek,rt5033-charger"; > + monitored-battery = <&battery>; > + extcon = <&muic>; Everything up to here looked ok, but extcon is not a hardware property. Please do not mix adding missing bindings for existing device with adding new properties. You should use connector for the USB port. Best regards, Krzysztof