From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5091E37719; Thu, 18 Apr 2024 07:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713426188; cv=none; b=SRS5nTr6FtLuzjxJCYhPaBMfUsIbMbuhCC11WKfv5VRHL7jkW31Io0bxM7c4gwfEcdQeBRe3uU+65mY8Zwx/jvE8yuiTUYlDjpLvC+WTF0uXUrN62lrZMqsRD3Pq/28HLg6FQ3UIlDs5wiq0lOIrp3lHun95nzvuTmL4/70aNy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713426188; c=relaxed/simple; bh=GLk8JMqo54bnpRu/mKNE88XqR0W0E3kJNx1Nb5NE5RM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qT2vu9otVgj+aRPzh3O61/Z7HL0isRJLT7/DhBRPzF84u5KVN0cF3pgrXcG66RkYNDVZnHiV6d/LTgpEFXaw3C0yBuOvsgTE4yo49rQIVtKRTfDENovkn2XjoO3ubMz/U3YO892scTXJSkeX6ki+SdKolxhy63AwUt7QAJsjNl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jSSlcDUl; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jSSlcDUl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713426184; bh=GLk8JMqo54bnpRu/mKNE88XqR0W0E3kJNx1Nb5NE5RM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jSSlcDUl3KojtgCcYK8Ve68K6Fol4vEzSfIwhqzZ0S3sxYT6M7ntIf2vYp0aPpkA2 qtdihonwioKZJatjD9D2NK2OoBJ4eWfCa3IY1meOdZiROPt6AXYHfuY4EPH/iIRy2O HocyCBOLmfAjEc4hCpzyZe1HBk7cw4bDfoOhzFZ9FEEWZTv3q3JxFQk6fdBtxO9UOe aGTIbKFlhITcuRduoEAtMm9JiyLXNNM7xbA0Dq36HhcKeSj45pR+5M3dzOAhkujIDp L1h6mZkE5q1kVrskXUEBjka5+6X4u5cIdo90ulfjSHMQmc3KDeP4iVMAhO4U9FZ2PI paqmRCslQCsDg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7EDB33781104; Thu, 18 Apr 2024 07:43:03 +0000 (UTC) Message-ID: <1d1bbc68-b484-4dc5-92f2-9454e8e2d6fb@collabora.com> Date: Thu, 18 Apr 2024 09:43:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings To: Rob Herring Cc: djakov@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com References: <20240417091442.170505-1-angelogioacchino.delregno@collabora.com> <20240417091442.170505-3-angelogioacchino.delregno@collabora.com> <20240417145402.GA2355631-robh@kernel.org> <207eb8d7-1a40-4114-a84b-26616dc39fcc@collabora.com> <20240417191445.GB3101736-robh@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240417191445.GB3101736-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 17/04/24 21:14, Rob Herring ha scritto: > On Wed, Apr 17, 2024 at 05:32:54PM +0200, AngeloGioacchino Del Regno wrote: >> Il 17/04/24 16:54, Rob Herring ha scritto: >>> On Wed, Apr 17, 2024 at 11:14:37AM +0200, AngeloGioacchino Del Regno wrote: >>>> Add bindings for the MediaTek External Memory Interface Interconnect, >>>> which providers support system bandwidth requirements through Dynamic >>>> Voltage Frequency Scaling Resource Collector (DVFSRC) hardware. >>>> >>>> This adds bindings for MediaTek MT8183 and MT8195 SoCs. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> --- >>>> .../interconnect/mediatek,mt8183-emi.yaml | 76 +++++++++++++++++++ >>>> .../interconnect/mediatek,mt8183.h | 23 ++++++ >>>> .../interconnect/mediatek,mt8195.h | 44 +++++++++++ >>>> 3 files changed, 143 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >>>> create mode 100644 include/dt-bindings/interconnect/mediatek,mt8183.h >>>> create mode 100644 include/dt-bindings/interconnect/mediatek,mt8195.h >>>> >>>> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >>>> new file mode 100644 >>>> index 000000000000..3ad60fd21f83 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >>>> @@ -0,0 +1,76 @@ >>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/interconnect/mediatek,mt8183-emi.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: MediaTek External Memory Interface (EMI) Interconnect >>>> + >>>> +maintainers: >>>> + - AngeloGioacchino Del Regno >>>> + >>>> +description: | >>>> + EMI interconnect providers support system bandwidth requirements through >>>> + Dynamic Voltage Frequency Scaling Resource Collector (DVFSRC) hardware. >>>> + The provider is able to communicate with the DVFSRC through Secure Monitor >>>> + Call (SMC). >>>> + >>>> + ICC provider ICC Nodes >>>> + ---- ---- >>>> + _________ |CPU | |--- |VPU | >>>> + _____ | |----- ---- | ---- >>>> + | |->| DRAM | ---- | ---- >>>> + |DRAM |->|scheduler|----- |GPU | |--- |DISP| >>>> + | |->| (EMI) | ---- | ---- >>>> + |_____|->|_________|---. ----- | ---- >>>> + /|\ `-|MMSYS|--|--- |VDEC| >>>> + | ----- | ---- >>>> + | | ---- >>>> + | change DRAM freq |--- |VENC| >>>> + -------- | ---- >>>> + SMC --> | DVFSRC | | ---- >>>> + -------- |--- |IMG | >>>> + | ---- >>>> + | ---- >>>> + |--- |CAM | >>>> + ---- >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - mediatek,mt8183-emi >>>> + - mediatek,mt8195-emi >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + '#interconnect-cells': >>>> + const: 1 >>>> + >>>> +required: >>>> + - compatible >>>> + - '#interconnect-cells' >>>> + >>>> +unevaluatedProperties: false >>>> + >>>> +examples: >>>> + - | >>>> + #include >>>> + >>>> + soc { >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + >>>> + system-controller@10012000 { >>>> + compatible = "mediatek,mt8195-dvfsrc"; >>>> + reg = <0 0x10012000 0 0x1000>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + emi_icc: interconnect@1 { >>>> + compatible = "mediatek,mt8195-emi"; >>>> + reg = <1>; >>>> + #interconnect-cells = <1>; >>> >>> >>> There's not really any need for this node. Just put #interconnect-cells >>> in the parent. >>> >> >> Actually, I modeled it to be a subnode of the DVFSRC for multiple reasons: >> >> 1. Some SoCs have more than one interconnect on the DVFSRC (two different kinds >> of EMI interconnect, and then also a SMI interconnect); and >> >> 2. Some boards will want to not enable the interconnect driver because some of >> those are not battery powered (so they just keep the knobs at full thrust >> from the bootloader and never care scaling busses); and >> >> 3. Some DVFSRC interconnect features may depend on firmware (but I'm not >> sure which ones and which SoCs, as there are lots of SMI/EMI ICC things that >> are not implemented yet with this series). >> >> The alternative would've been to add a property to enable, or disable, the SMI ICC >> (not present in this series), and/or one, or the other kind of EMI ICC (this series >> implements only the simpler EMI ICC, and I keep saying "the other" because I >> currently don't remember the name).... which is really ugly. >> >> Ideas? :-) > > Just provide that reasoning in the commit msg. > Okay, that's sensible - should've done that in v1 even. My bad. Cheers Angelo > Rob