From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: Sidong Yang <sidong.yang@furiosa.ai>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: Oded Gabbay <ogabbay@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v2 2/3] accel/rocket: Use an unsigned index to copy the job's tasks
Date: Fri, 9 Oct 2026 10:46:39 -0600 [thread overview]
Message-ID: <1d263f18-c99b-411c-84eb-0ee5c7b76d36@oss.qualcomm.com> (raw)
In-Reply-To: <20261004164727.466164-3-sidong.yang@furiosa.ai>
On 10/4/2026 10:47 AM, Sidong Yang wrote:
> task_count is a u32 from userspace, but rocket_copy_tasks() walks it
> with an int index, which would overflow for counts above INT_MAX. That
> is not reachable today, since kvmalloc_objs() rejects any count above
> INT_MAX / 16, but use an unsigned index to match the type.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/all/20260711063638.61B411F000E9@smtp.kernel.org/
> Signed-off-by: Sidong Yang <sidong.yang@furiosa.ai>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
next prev parent reply other threads:[~2026-10-09 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 16:47 [PATCH v2 0/3] accel/rocket: Validate task regcmd fields Sidong Yang
2026-10-04 16:47 ` [PATCH v2 1/3] accel/rocket: Don't tear down the scheduler when drm_sched_init() fails Sidong Yang
2026-10-09 16:45 ` Jeff Hugo
2026-10-04 16:47 ` [PATCH v2 2/3] accel/rocket: Use an unsigned index to copy the job's tasks Sidong Yang
2026-10-09 16:46 ` Jeff Hugo [this message]
2026-10-04 16:47 ` [PATCH v2 3/3] accel/rocket: Validate task regcmd address and count on submission Sidong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d263f18-c99b-411c-84eb-0ee5c7b76d36@oss.qualcomm.com \
--to=jeff.hugo@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sidong.yang@furiosa.ai \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®