mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Chris Lew <clew@codeaurora.org>,
	bjorn.andersson@linaro.org, robh+dt@kernel.org,
	andy.gross@linaro.org, david.brown@linaro.org
Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink
Date: Mon, 18 Dec 2017 14:48:28 -0800	[thread overview]
Message-ID: <1d29f603-b113-9931-d7b6-980c959b8b6b@codeaurora.org> (raw)
In-Reply-To: <1513634534-22861-5-git-send-email-clew@codeaurora.org>

On 12/18/2017 02:02 PM, Chris Lew wrote:
> Expose the name field as an attr so clients listening to uevents for
> rpmsg can identify the edge the events correspond to.
>
> Signed-off-by: Chris Lew <clew@codeaurora.org>
> ---
>  drivers/rpmsg/qcom_glink_native.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index 786f2eca01f1..a897ccea3098 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -1558,6 +1558,22 @@ static void qcom_glink_work(struct work_struct *work)
>  	}
>  }
>  
> +static ssize_t rpmsg_name_show(struct device *dev,
> +			       struct device_attribute *attr, char *buf)
> +{
> +	struct rpmsg_device *rpdev = to_rpmsg_device(dev);
> +	struct qcom_glink_device *gdev = to_glink_device(rpdev);
> +
> +	return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", gdev->glink->name);
> +}
> +static DEVICE_ATTR_RO(rpmsg_name);
> +
> +static struct attribute *qcom_glink_attrs[] = {

const?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-12-18 22:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 22:02 [PATCH 0/6] Add chrdev and name query support for GLINK Chris Lew
2017-12-18 22:02 ` [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings Chris Lew
2017-12-20 18:30   ` Rob Herring
2017-12-21  1:35     ` Bjorn Andersson
2017-12-21 19:36       ` Stephen Boyd
2018-01-09 19:11         ` Chris Lew
2017-12-21 22:39       ` Rob Herring
2017-12-22 22:28     ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 2/6] rpmsg: glink: Store edge name for glink device Chris Lew
2017-12-19 17:52   ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 3/6] rpmsg: glink: Add support for rpmsg glink chrdev Chris Lew
2018-02-15 18:28   ` Bjorn Andersson
2017-12-18 22:02 ` [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink Chris Lew
2017-12-18 22:48   ` Stephen Boyd [this message]
2018-01-09 18:44     ` Chris Lew
2017-12-18 22:02 ` [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name Chris Lew
2017-12-19 17:52   ` Bjorn Andersson
2018-01-09 19:08     ` Chris Lew
2017-12-18 22:02 ` [PATCH 6/6] rpmsg: glink: Add get_rproc_name device op Chris Lew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d29f603-b113-9931-d7b6-980c959b8b6b@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=aneela@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=clew@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®