From: Damien Le Moal <dlemoal@kernel.org>
To: Li Lingfeng <lilingfeng@huaweicloud.com>,
axboe@kernel.dk, min15.li@samsung.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@lst.de, yangerkun@huawei.com, yukuai1@huaweicloud.com,
houtao1@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH] block: move capacity validation to blkpg_do_ioctl()
Date: Tue, 5 Mar 2024 16:06:47 +0900 [thread overview]
Message-ID: <1d3dbc08-654c-46f6-a53d-43deeda5c14f@kernel.org> (raw)
In-Reply-To: <20240305032132.548958-1-lilingfeng@huaweicloud.com>
On 3/5/24 12:21, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@huawei.com>
>
> Commit 6d4e80db4ebe ("block: add capacity validation in
> bdev_add_partition()") add check of partition's start and end sectors to
> prevent exceeding the size of the disk when adding partitions. However,
> there is still no check for resizing partitions now.
> Move the check to blkpg_do_ioctl() to cover resizing partitions.
>
> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
But I wonder if this needs a Fixes: 6d4e80db4ebe ("block: add capacity
validation in bdev_add_partition()") tag and Cc-stable...
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-03-05 7:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 3:21 Li Lingfeng
2024-03-05 4:30 ` Damien Le Moal
2024-03-05 6:24 ` Li Lingfeng
2024-03-05 7:00 ` Damien Le Moal
2024-03-05 7:06 ` Damien Le Moal [this message]
2024-03-05 13:55 ` Christoph Hellwig
2024-03-06 15:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3dbc08-654c-46f6-a53d-43deeda5c14f@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min15.li@samsung.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome