From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751067AbdEPDvo (ORCPT ); Mon, 15 May 2017 23:51:44 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:8514 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbdEPDvn (ORCPT ); Mon, 15 May 2017 23:51:43 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9DbcbksQaH7u1c2CsGfEY= X-RZG-CLASS-ID: mo00 Subject: Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function To: Marc Kleine-Budde , Quentin Schulz , wg@grandegger.com, mario.huettel@gmx.net References: <20170505135033.8349-1-quentin.schulz@free-electrons.com> <90788d6d-24f3-64ba-43f3-16301b777536@free-electrons.com> <4676456c-823c-d7db-2139-35c8229109f0@pengutronix.de> Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com From: Oliver Hartkopp Message-ID: <1d41efe1-d24f-4700-8986-0d5dc848ea23@hartkopp.net> Date: Mon, 15 May 2017 20:51:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <4676456c-823c-d7db-2139-35c8229109f0@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote: > On 05/12/2017 08:37 AM, Quentin Schulz wrote: >> Hi all, >> >> On 05/05/2017 15:50, Quentin Schulz wrote: >>> To avoid possible ECC/parity checksum errors when reading an >>> uninitialized buffer, the entire Message RAM is initialized when probing >>> the driver. This initialization is done in the same function reading the >>> Device Tree properties. >>> >>> This patch moves the RAM initialization to a separate function so it can >>> be called separately from device initialization from Device Tree. >>> >>> Signed-off-by: Quentin Schulz >> >> It's been a week since I sent this patch series. Any comments? > > Looks good, added to linux-can-next. Isn't this a fix for linux-can instead? At least it would make no sense to me to have the upgraded M_CAN driver in Linux 4.12 without this fix. Regards, Oliver