mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
	platform-driver-x86@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Zhang Rui" <rui.zhang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
Date: Fri, 17 May 2024 16:18:06 +0200	[thread overview]
Message-ID: <1d470a85-dd92-44d6-9900-db4c581b68c4@web.de> (raw)
In-Reply-To: <20240514092656.3462832-1-harshit.m.mogalapalli@oracle.com>

> In tpmi_sst_dev_remove(), tpmi_sst is dereferenced after being freed. Fix this by reordering the kfree() post the dereference.

I suggest to take preferred line lengths better into account
also for such a change description.
Thus the second sentence should be put into a subsequent line.
How do you think about the following wording approach?

   Move a kfree() call behind an assignment statement in the affected if branch.

Regards,
Markus

  parent reply	other threads:[~2024-05-17 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14  9:26 Harshit Mogalapalli
2024-05-17 13:56 ` Hans de Goede
2024-05-17 14:18 ` Markus Elfring [this message]
2024-05-17 14:31 ` srinivas pandruvada
2024-05-17 14:33   ` srinivas pandruvada
2024-05-17 14:44     ` Harshit Mogalapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d470a85-dd92-44d6-9900-db4c581b68c4@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@linaro.org \
    --cc=error27@gmail.com \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®