From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286B3C433E9 for ; Tue, 2 Feb 2021 12:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E3664F45 for ; Tue, 2 Feb 2021 12:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbhBBMwk (ORCPT ); Tue, 2 Feb 2021 07:52:40 -0500 Received: from smtprelay0102.hostedemail.com ([216.40.44.102]:43484 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231424AbhBBMwf (ORCPT ); Tue, 2 Feb 2021 07:52:35 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 6EFE5182CED28; Tue, 2 Feb 2021 12:51:52 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pear45_5b049fa275cb X-Filterd-Recvd-Size: 2431 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Tue, 2 Feb 2021 12:51:51 +0000 (UTC) Message-ID: <1d4f5de1deebda31d9b1d185810b352ea0af21a3.camel@perches.com> Subject: Re: [PATCH 2/3] printk: hard-code CONSOLE_LOGLEVEL_MIN in printk.c From: Joe Perches To: Sergey Senozhatsky , Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Petr Mladek , Steven Rostedt , John Ogness Date: Tue, 02 Feb 2021 04:51:50 -0800 In-Reply-To: References: <20210202070218.856847-1-masahiroy@kernel.org> <20210202070218.856847-2-masahiroy@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-02-02 at 19:06 +0900, Sergey Senozhatsky wrote: > On (21/02/02 16:02), Masahiro Yamada wrote: > >  include/linux/printk.h | 1 - > >  kernel/printk/printk.c | 2 +- > >  2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h > > index fd34b3aa2f90..ceaf0486c01c 100644 > > --- a/include/linux/printk.h > > +++ b/include/linux/printk.h > > @@ -48,7 +48,6 @@ static inline const char *printk_skip_headers(const char *buffer) > >   > > > >  /* We show everything that is MORE important than this.. */ > >  #define CONSOLE_LOGLEVEL_SILENT 0 /* Mum's the word */ > > -#define CONSOLE_LOGLEVEL_MIN 1 /* Minimum loglevel we let people use */ > >  #define CONSOLE_LOGLEVEL_DEBUG 10 /* issue debug messages */ > >  #define CONSOLE_LOGLEVEL_MOTORMOUTH 15 /* You can't shut this one up */ > >   > > > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c [] > > @@ -63,7 +63,7 @@ > >  int console_printk[4] = { > >   CONFIG_CONSOLE_LOGLEVEL_DEFAULT, /* console_loglevel */ > >   CONFIG_MESSAGE_LOGLEVEL_DEFAULT, /* default_message_loglevel */ > > - CONSOLE_LOGLEVEL_MIN, /* minimum_console_loglevel */ > > + 1, /* minimum_console_loglevel */ > >   CONFIG_CONSOLE_LOGLEVEL_DEFAULT, /* default_console_loglevel */ > > I personally don't think that this improves code readability. Nor maintainability.