From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631512E7635 for ; Mon, 30 Mar 2026 18:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894540; cv=none; b=Wq1hQwS3tUKa3Cn2JJW1T4DQfxbpxB1ozicZhXwLMjgwgNSlI7uRstx0M3FDA91hLAR/RJfU0GPZ0slqFjnmyQElbEqanv3JSJ/6rNgTDhrwXNX18U131n/XDtrawiriuKEDhcRI3kb4N5mZr51Cs8leHWK/D5hHmpMF0Hj9buI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894540; c=relaxed/simple; bh=2Wmykm9TEFQ6qJqutwx5G/WM3MIPHdk0eyShmReCWl0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aAQIN0KAxsUrcXIhwuzcREfiixjOARh1zyPzyOTThCQPsZe/caj//gYqbxezL9dvz2QYvOQ1Zd/hHrJFszEF5azx4awa8JzvftIy8uchLIT6oKDdyGXNBfcVwPZcmj+vyQ+123xwYgVETVyLEzEBrTKV+HA9OkmltZjtEhawqpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o3VGP6PA; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o3VGP6PA" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2c156c4a9efso4597211eec.1 for ; Mon, 30 Mar 2026 11:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894538; x=1775499338; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B3FCFfolEnP72cZRGyyoWzCdd0oZhy94NWlfVfZ54PQ=; b=o3VGP6PAtkMFocHSb0NQ9Vz3JEJ4Um3CZPorVo2enIDFF6JnS7UEPbHM424gXx/Hbw u7jgpdf1aFlk08kJ13SByjUe9khZXlsyutYOPiGHj2QqpzZXfTYDMqJiEHp2L4r/ECht D2OQMqJ+y+XD+tHen1EXLD5JttWWxN4FWOGoggEVd+nzPwQmysbofKq8Rm/Hv7rBuFDT myVjG7mwwCTvkuiLiONvdJRPuyo4aMJrSekL21RK9jRf5CChcnIMafJKqpx9RN3J9KfD 5OkeRxOrDQ2ByLCGi0ykcdJhYCk2wOrJajH24n68m6DSUH+y7aBxCVLlWbi5mLhDimbS ChtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894538; x=1775499338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B3FCFfolEnP72cZRGyyoWzCdd0oZhy94NWlfVfZ54PQ=; b=Fanpfv6t6BYuS/Ae5dUpd3oLJ0WV8r3IhMw7WSkplZpZ9rB81pEJWYBBGYXoilH9+z Kfjn+gcDAueI8fssjX4Z/vMwBR4CIaf7NTaNlx/j9jFQFDKVtfQCUWp4SRTKw7BXGRRO 0frAKKpMK404iHqa5X/9UjyeXP4bQxjoYIGcXkVQMIdkSEyynVPXant8g0vVgxTaTi4E 0SgHKvOX1Y+dBF9XaUYmbmqxKYCldG5xU5+vzV+56wiJ6MbakQdZhrtT/3de8vF7MsDi uCgnnnhlFrpYD6Hd+bjQJJNTHqFKDG2Sb39VvsTmfHDGitlnoC1rW55vLJNXcaUjkxnt gMtg== X-Forwarded-Encrypted: i=1; AJvYcCWKwZiLZipEniFSsLdoA3o3Ufru0k4RGzYcJle0Jl80xVsQ2cvrq6gpVDPC/aG97virh7ohSMypEGd0dso=@vger.kernel.org X-Gm-Message-State: AOJu0YxEpDat3NnQzwMbdnoazkap9qc+y90pHRZPsKz6kAdDKjUZYB4i bKE2s8KMpsDDoq45QExuNdEyROUhC2PUpzqcwuuIETbtvoSy/3zZiMwh X-Gm-Gg: ATEYQzzjc3VL6WazD2qlJm9C0OHf3G+gxfPH5aThTa0MC94suiDZysCi/e2/UXAT/LD JjEOcvmITc/5MdY8WfqevrOxwiuDcZV3coB6XDjW8liuL6UkIirv51HYSGsqv2SjZ10zh2gW1QB FM5F73kvjvNG2LOvyjc9EtfG/Ra69uZikh2C2mOcqTbRy5aofnstoGVuYVHGYmr68V53LwkrCQW s6Ab9NCyqjI6HlWv5h/T99L7qe8WbUfOskzXUVR/dSy2CYRn1h/8Q0sRXx3ElCAQ82L3vCTbVyB YeuX8TkSz9ETF1w5siJ+QMCixehHj7MSeaRoas/EN7j+ycsbX3H9BPSfDZ3GCSzBDcy2S8q3U5t 76VnFtkVXYwbW81CORs21q/Vsr6lmkPEB6+LS6S5dMMIONVuEx73xcwj25RDJR3pyC8pE8PRfH+ o4kQim8dcXpEliDb2ZTr14WGhH4sDEpy6rV8zEVi7DP6XTzgxwn6EfIn7nNjFRQbGjygr9qZfGI 59mJzKyca3p X-Received: by 2002:a05:693c:3005:b0:2c0:ba91:48b6 with SMTP id 5a478bee46e88-2c185f3295emr7416238eec.26.1774894538329; Mon, 30 Mar 2026 11:15:38 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1151:15:c56:221b:35d5:85f? ([2620:10d:c090:500::1:79e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c3bd9894sm7758362eec.4.2026.03.30.11.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 11:15:38 -0700 (PDT) Message-ID: <1d551008-3c42-4b7b-9507-03072740a54a@gmail.com> Date: Mon, 30 Mar 2026 11:15:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 3/6] net: bcmgenet: add basic XDP support (PASS/DROP) To: Nicolai Buchwitz , netdev@vger.kernel.org Cc: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20260319115402.353509-1-nb@tipi-net.de> <20260319115402.353509-4-nb@tipi-net.de> Content-Language: en-US From: Mohsin Bashir In-Reply-To: <20260319115402.353509-4-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > +static int bcmgenet_xdp_setup(struct net_device *dev, > + struct netdev_bpf *xdp) > +{ > + struct bcmgenet_priv *priv = netdev_priv(dev); > + struct bpf_prog *old_prog; > + struct bpf_prog *prog = xdp->prog; > + > + if (prog && dev->mtu > PAGE_SIZE - GENET_RX_HEADROOM - > + SKB_DATA_ALIGN(sizeof(struct skb_shared_info))) { > + NL_SET_ERR_MSG_MOD(xdp->extack, > + "MTU too large for single-page XDP buffer"); > + return -EOPNOTSUPP; > + } The MTU check here is great. But I do not see support for .ndo_change_mtu. This would allow users to change MTU size AFTER the program is attached.