From: Hans de Goede <hdegoede@redhat.com>
To: Mario Limonciello <mario.limonciello@amd.com>, Shyam-sundar.S-k@amd.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] AMD PMF Smart PC error handling cleanups
Date: Mon, 19 Feb 2024 13:38:16 +0100 [thread overview]
Message-ID: <1d5dd3de-5561-4231-94bd-65ac05f1fc50@redhat.com> (raw)
In-Reply-To: <20240217014107.113749-1-mario.limonciello@amd.com>
Hi,
On 2/17/24 02:41, Mario Limonciello wrote:
> While debugging the suspend issue for amd-pmf the initial bisect result
> pointed at red herrings of cleanup flow problems for
> amd_pmf_init_smart_pc(). The actual issue wasn't in this code, but still
> a lot of memory is allocated and not immediately released if any of the
> error branches are taken.
>
> This series cleans that up so that every step is cleaned up. I believe
> this actually fixes driver bugs that "could" occur if a BIOS advertisd
> Smart PC as well as ITS auto or CNQF but didn't include a policy in the
> BIOS.
>
> Mario Limonciello (2):
> platform/x86/amd/pmf: Add debugging message for missing policy data
> platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc()
Thank you for your patch-series, I've applied this series
to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.
Regards,
Hans
prev parent reply other threads:[~2024-02-19 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 1:41 Mario Limonciello
2024-02-17 1:41 ` [PATCH v2 1/2] platform/x86/amd/pmf: Add debugging message for missing policy data Mario Limonciello
2024-02-17 1:41 ` [PATCH v2 2/2] platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc() Mario Limonciello
2024-02-18 14:58 ` Hans de Goede
2024-02-19 12:38 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5dd3de-5561-4231-94bd-65ac05f1fc50@redhat.com \
--to=hdegoede@redhat.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®