From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4542B361656 for ; Wed, 5 Aug 2026 00:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785889615; cv=none; b=VvfCrUexCJtsPCxIV/tkp5OwhSDTEZlDpRhctp/dKXSLLOtoURpNVFkFoYDmGvP1bh7B4zpAb4jbQqn+hswkInnwdqfVz6/780JyNagA6j84r0SaZ6zkoUZrtn+Pe2PxQqNq6mdFk0S9gwDFGnodStWXHl1yYuQaZp4sBIb3bHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785889615; c=relaxed/simple; bh=8Ib/qaTGa1PbwNGkWBKQxFQsk2D4CT9qe0pTurwwlvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X/CYZzUWECLa/sAwygdRYwj2gz39MNfeewoQww9Mc5p8H8IzWLWK/juOp44+ESukjr+rbD+aIX0zGQses3XQO6qQjN9BmRkvSC/cm1qXs4O96HlWnoOPo8ds2pBjlM9ssXSDhTPObHmHPQaViWmyp53YRy2Ybdga2uogabjC+Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tv1ImsfN; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tv1ImsfN" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-51c08df8513so2369551cf.3 for ; Tue, 04 Aug 2026 17:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785889613; x=1786494413; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3IZ+EqBseqdBQygIlQeWXwAUEvO6/PiuHwN+sYz3VZo=; b=Tv1ImsfNYP68CARZDZt4Z3kS9JB4j5nd3x13MFJzSvS27+WQA7AvaJKVEG06uPr3ia UaMghgktJrgrYLrqS+C8aILOXkHBAGFIm9+KaqTgNWS8AKlZz1Ho83s+O6jR/rroOwRz syKVf+oii+o7iIwVEB454ejcyNatgr0V/+roKeee6cN1whn10q9Rf/xj5MLaFt89q8dn xyu7gV23MICJ6es2iP6k1QVI1ubTDXPz6jnqKKgV1Sex8vDy8zcz4KGEdT+sKS+TBbEW x6WVlvbSte4pM0srFlNxiJko3HFuiFXzVQXOG8mOpeTnE/UNbFHbbUidZHraciUoMDfn EYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785889613; x=1786494413; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3IZ+EqBseqdBQygIlQeWXwAUEvO6/PiuHwN+sYz3VZo=; b=pVROhb0EpZi4Nk20KeLk738D1CqUyvXVy21Uj8mo6PhbHWlXbxJEhfT5m4ZfbNk9D3 FIUZ3OVyHcAx8v19AqZ4Zdh9B/JjxkMO+yqSdTWcwLhQuVrl+2qawuaE6pu9I0fHQ9v8 pQFOsrKfkEVT1ptVYbrgexNnUI1exiq88d/Uu7oSWCIZ9uFW2+qnzT1j4OWQWdKVwJG9 cpkLGCWfv0TBbZQdTpqqXpADqvVfAwTs5rMaNtAnz1rzg6IZMa+CrZcI/fIFuZcVaHYz bn4FGvjKOKakRXOr5x3ooxUuWnbTql8teOhIcBPhC3Qsk56C3oaZmNxbI8VQwoQCNd8J A3vw== X-Forwarded-Encrypted: i=1; AHgh+Rrj51yRcJx/pxsvaJGF6t5mZsGVNrn6216k5IPntUrFi45t9yxf6AiD/e4Eor7dQGIhlkIGcjriE8e0I1M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/E2WZhZgl4QY8uvXM8/keozoLgv8IE4zdx9yvCm18RtdrkBSo 7lYXytb66qWIuH94HcwZKHuUL4aA7FWK2CHs63ACLdVVAelMlc+adq35 X-Gm-Gg: AR+sD12pRcDHC3G9/FL7fJqU/WZ+EmThmH8fQVEKEswhSOA2DvTtU4D6591Vg4hiu/6 KQvhKlxtTp0mMn93bB88Y43e25aDkvhELiODawezc+2V5MQyHGRmF1OOUYd82r7zDsZK94GxqYG lQ6EBy7u1Rr9WSz3mMmtRbFGt/Uy8F/kD3Mc9csSYjS3Pu+Fbyb4BdvizLUtZEvLLjLhW6TGvEo mkGX0UyY2mLs3l6BbzPi6pFKWCp7yscoPHih9jJ5OtVVKPTiOvDLrQkNwYbSuBF4flygOq66Uxs j0W9erD22nITMwJeAXR/+PQX1Aom5e59rcGW2T1W8GX//GVH7a7mA6+Crj8/m1+AWRj9GU0vvh4 45ADrArgvod2RRDXWszXE+BgR5PenN3F12+kFVV+lmxXuRi3G4fXishsVuiaD/YJghMTGYHz4M0 63hX7OWjgC2mbsPiswpP/xZ0aIRj2Z95HGKfyEjC7xX0zBqogOTOXmYhCVENxRo88IjSzF+f7Lh 59Sw6ZFgRPvMg== X-Received: by 2002:a05:622a:230b:b0:51c:22c5:daf4 with SMTP id d75a77b69052e-52ce60c18eemr34720641cf.28.1785889613088; Tue, 04 Aug 2026 17:26:53 -0700 (PDT) Received: from [10.0.0.128] ([66.31.161.230]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52ce8972e90sm5650541cf.27.2026.08.04.17.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 17:26:51 -0700 (PDT) Message-ID: <1d62c563-4ee3-4693-8f68-d464e5da57f4@gmail.com> Date: Tue, 4 Aug 2026 20:26:50 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Linux) Subject: Re: [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support To: Jiri Kosina , Sriman Achanta Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Bastien Nocera , Simon Wood , Christian Mayer References: <20260803191553.66368-1-srimanachanta@gmail.com> Content-Language: en-US From: Benjamin Wheeler In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I'm glad to hear this is getting merged! I have studied and tested older revisions of Sriman's patchset on my Arctis 7 Gen2 and would love to contribute a patch that adds support for it as well. I see you have a branch called for-7.3/steelseries in the hid kernel fork. Should I base my patchset off that? And should I aim to have this ready before the 7.3 merge window, or would 7.4 be more realistic? Thanks for the direction. Sincerely, Benjamin Wheeler P.S. And thanks for working on this, Sriman! On 8/3/26 3:32 PM, Jiri Kosina wrote: > On Mon, 3 Aug 2026, Sriman Achanta wrote: > >> This series moves the SteelSeries Arctis headset support out of >> hid-steelseries.c into its own module, reworks it around a per-model >> device_info table, hardens the battery power-supply lifetime, adds an >> asynchronous status interface, and finally adds support for the Arctis >> Nova 5X and Nova 7 families. After the split, hid-steelseries.c is left >> handling the SRW-S1 racing wheel and the MSI RGB LED devices. >> >> Changes since v6: >> - Rebased onto hid.git#for-7.3/steelseries. >> - The split now leaves the MSI RGB code in hid-steelseries.c >> alongside SRW-S1, and strips only the headset members from >> struct steelseries_device. The MSI RGB quirk bit is renumbered >> to BIT(1) since the two Arctis bits are gone. >> - The Arctis hardening that came with the MSI commit moves into >> hid-steelseries-arctis.c with the rest of the headset code: the >> hdev->rsize < 3 guard in steelseries_is_vendor_usage_page(), the >> battery_registered store/load-acquire pair, the !sd checks, and >> the hid_hw_stop() on the hid_hw_open() error path. The >> steelseries_is_headset() dispatch is dropped, as the new module >> only binds headsets. The battery_registered flag then goes away >> in patch 3, where the device_info rework guards every >> power_supply_changed() on sd->battery instead. >> - The v6 patch "HID: steelseries: Inline and simplify SRWS1 wheel >> driver" is dropped. Its premise was that hid-steelseries.c only >> handles the SRW-S1 after the split, which is no longer true. >> - No other changes. The resulting hid-steelseries-arctis.c is >> byte-identical to v6. > Thanks a lot for such a brisk rebase. Now queued. >