From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933359AbcHYO6k (ORCPT ); Thu, 25 Aug 2016 10:58:40 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45719 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758934AbcHYO5m (ORCPT ); Thu, 25 Aug 2016 10:57:42 -0400 Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open To: Jiri Kosina References: <20160818135932.219369981@linuxfoundation.org> <20160818135938.484441980@linuxfoundation.org> <0df64efc-85fe-1de7-f15f-233f1e5fdad8@compro.net> <20160824201701.GB2133@kroah.com> <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> CC: , Greg Kroah-Hartman , , , Wim Osterholt From: Jens Axboe Message-ID: <1d640422-6647-0889-7ac3-501bede1a756@fb.com> Date: Thu, 25 Aug 2016 08:57:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY1PR0201CA0034.namprd02.prod.outlook.com (10.163.30.172) To BN6PR15MB1186.namprd15.prod.outlook.com (10.172.205.140) X-MS-Office365-Filtering-Correlation-Id: e3c36924-d20a-4d81-31db-08d3ccf81bf4 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;2:65urBuQODhxr+HgmtJUk6ntbOPw5m8uzep0Dh3w0jTxnGLHNgMc25KIMJpcoj1FlUZi+vzArnDZ3vLyMjlUftLWe1lFTWJxHGc1W/u9Itkux78QUhwRZx8eaIs6pozMa17NkxpYrwdf51NXPI0GVKfLt5eICvgKWAeBvfRtbQGhzygTGULkc+selCd1o21Yu;3:WY/TuUiXv3DyHQQZ33FbL/rVvNkRV4Nt1EQaEX9/IoPcndbZP1StRtpjraabqFWvgNtWKCJz+kfQ8rKnkfCK7sQDHdBMLFv4MMijDrb7TUxjqAcKeUhfkaoMc7lScsE6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;25:ckGcjwOybQrTRF6L6GMHMhzgyPSX2DUBIyn6vBq5Qi+pkOu8fiEOkHLSu5m+Q324jWaTAqImDsjpmbcW1jfiaopQprheqO1XrF7dtdE/QteARFg5a9xMoaq/5SZLmiMepm5EiSPqkk2VtEKwyycvTatah6aVxO7TV5NJu3dgsSUdCKHJP/ANK34cgqSo4ZhS+ToLyvDccU574+Lj1qip5aaAf1XtlI3EYGTCLroxEXy5YA8u72L1PsvOq88Dgb04UYY8FvWb9X9BUaqtd13pr4I++24HmC4csqIK44rzn9StG/2tdf/VKUhK6DRWecus1MUTd76hObZb6+aq6fcyjZAjX2gLFCnuWX4Ir57Sakd5yF1CjQnM3v5sutDAdr6jZuKt4NjVN68nWoG5IDZ71OwwiuPwqVpVrSAAIt6ApxyAMzTHN6s6TRUsN3gCQSj9AJcvPM9Cf+ifTu2rURjoYxGL5rYZBagiy0aQxSXl3oaw6/vm07yCiPwcGluzz46wEOGY5TQnCaYGGyqCw8G8Mjz9PZXgm5lJNWTE1Bikys78aEWr0dSIp9a0kIrNOBPhSV2bn1SfidwhffK1nXSpxHBHbK/pZVI4Jr6KAd70ACT63Hhdmu4hN01FWtKvC+ns0tjlZwdVWnxevGYEYqSZ6xNU78nDY4F5xQ3L6p1bTMvlBna3wxWHz/2STv6gLkNf;31:RRDeSyFciExpZX5DotCghG5Srqj46FnSaguZ3ih1L0WLsYQrNmbwFXAr11uoFI9CdVqqAoADNqNz+39N+CCJcxAPoq4MV7dvOYLF9nY2OP/kxVOGbzs2d0Epb+Eif4UsRTFtqoNUP6KxJSkqR3rBwbolwn6pfpTuZOrojf3/E9kcTA8vx2XMyBVpwA1st8YpUhUzm6HPizuKO6W1E1K/g2ldkIOWInRqeaVmYuhvVSo= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;20:czUMHka0SvynqMgpJMUBLP0VDXWql06RsyimwRW3umiUlFbJJtegBoENOFH4LOkWozoEJnOzv5NgksOLm3jnySwq9uPGERPcXRq8eow+GwVpjzMm4YXmZ1w9v9m8Zf5vIuaezXH4h2XALCQ3+Mo5iku7oKyWNrVT0gOPeGpBbss=;4:2PcDfh2xXkpP2ooxFCwH2B/QgLx8Mtl5nlLAgXCFpMVtr2OvNLxNLb/iDyNQmLfi4Xj1CJjJayS4mn4WHxdb6B/s3QCEs2/SSEHQna41Q76pSUNzQXDcfc1ZqEEGamu7JnI97n1EAcQiesToaac1Xnf6znUWbTi+vzW3U7RX0IlP/sPXy85CLkBWQMVnOkk3EB5r8chFp2PdaIPuO1Gyfp/deLo1DVjtziCftJGKPiH0dPIZTm5iiGBQijDGH5UAFf87SBuEDbbOCuqf1B2NrEHI4QrPldSMCw7Yx5eMW2khunYk375QASnf+hPmUjeILcoF40jc2BqGhc+xDWpdhEwtI6fOi4IvZpbCn7xmCP96naskp1qxGBNxzeGY8Y1P3UnOzXa+ETgd0/vKzQVvNA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN6PR15MB1186;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(199003)(377454003)(50466002)(23746002)(230700001)(101416001)(5660300001)(92566002)(86362001)(106356001)(97736004)(36756003)(50986999)(54356999)(110136002)(31696002)(189998001)(33646002)(76176999)(4001350100001)(575784001)(3846002)(93886004)(7846002)(305945005)(2950100001)(117156001)(7736002)(6116002)(8676002)(81156014)(81166006)(586003)(68736007)(64126003)(105586002)(2906002)(77096005)(66066001)(42186005)(65806001)(31686004)(47776003)(4326007)(83506001)(65956001)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1186;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1186;23:NHfwyTQb6yFXd00+PqgOdKL+U5SAD4Oq95S+5?= =?Windows-1252?Q?LYxG5hq51fxWxOdur5+/SeaHQ7NYHZ37uTT05lKEc89CFPw0ZMenCXwY?= =?Windows-1252?Q?HRjmSVhB+y7aL/hlRWxd4KEbTERrmPkISVQIjUtflev+lRxuBBZPv+fK?= =?Windows-1252?Q?pA+breaeXKnzIKsPRvFgsTJLsKpYs/3nHJGjybo/aqkO387uOLlvXKV6?= =?Windows-1252?Q?JrNcOSfeyBfzXRpXagW27zKQ7ga0adtoMqXNjyT9HhdtnChkZhaYPSnM?= =?Windows-1252?Q?N6NsH9dmOxQz3mbGN1tHCzBndCw0hOaf0D03W/Cay2imuFZicfryhwB4?= =?Windows-1252?Q?h5Z//miEco12S2TGf0T5XIt+F7OIn7ps94g5cQhCH+NS6LxkIy4X3S3t?= =?Windows-1252?Q?R72OkZ0M6p4yj/XO0e+cqR2o9iCd3b01q2Ap3f6G9koxXoyyoYxM3bvz?= =?Windows-1252?Q?8/xz6kpC7a+LP/WBDsST84480D1iWdQBDzR1x2Ueukv9zirSI/oOsj4n?= =?Windows-1252?Q?Y5L2ZjG09DyawdbjcoLnl9NqdmXh+BK0UJU6Kc/HdAVPjb/DS3i7TwNk?= =?Windows-1252?Q?gHSMl5T+OWHNxnQ7Va+dVAMjx5PgTSm5ZtbHvTMZu5IFJ3Waji9rivLx?= =?Windows-1252?Q?PQhu/R6SbwhULGfqvWOiMqpe1tVHlfuZDf9iyJsaj+u0UjIxGeE2h/Q3?= =?Windows-1252?Q?LMs4T0MzebcqaTpSPtIthoJaujl6LSvRjkyzZrpw6UVQiYRsCFm85MJ1?= =?Windows-1252?Q?YyZ2SYpLVyKfz+cr2kFMWstyNqacVbv/iz7aPCNzRrKCsnJ31/ZKi5s7?= =?Windows-1252?Q?/eVmwG/E7LYrXeqKGbdJddhJM0UfcCyZ9PuUpJoP2MrNbyDWKpdujMXS?= =?Windows-1252?Q?3UttQv/liuNh1VdRmCt4VW9jpjr9IOE6aHEyhye6ElspsjokRfg248jy?= =?Windows-1252?Q?y9EAFN3qSh34RZj3p7IIl2Hbc7yXUJujGHg9Kg7SKNPShTTCxGujcrJG?= =?Windows-1252?Q?10uoFfH+IQ1HwAiDUO+46dgrrpq1L9f1DiTU+SqX0T05eZ9M5qz+dfbg?= =?Windows-1252?Q?SMeqAGjKoENTSjZLuDlTwnCC1tK041k5Lr4bXllfmr13HPso52DZXDT0?= =?Windows-1252?Q?nTdQn/+ACEbDi/7c3x0plfAHZRDIOrRXLubfBJvP1vCjz3LKYPHOdhPF?= =?Windows-1252?Q?aS/beTAeX5/iZvs/eh8gIOG97iGHtSBwFN6hHu64qysnB06PP40q1G7Z?= =?Windows-1252?Q?GAsFatFrzRU5pJ7KFJt2Jv1HB1tRCVtZGI/Qo4mC61vfZu7/y1GKtkLL?= =?Windows-1252?Q?ldS6utSlJbgpkhgTBBcRODa6nPdJ0VsGBfbnENhS7StBLZ7dR/bWtBEF?= =?Windows-1252?Q?eK/IdV/8Wxe9CvkAC/xJ/bYx4ZqomLgFbq9U7L6F+BB5ImGIv43H5U?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;6:F5HbTaHPt8+Fs617z6S+u2DrVSiktrSZI6PrR6dmG5lGya4XCcNE+ywTwc6ZmPgUXboyK2WTXGN6ouKklKXw+XoMNLAeFCFzycJQTK1p+Rj1ehNYNcXb3Zap4Y6f9n+hTG9lJrVlwD/kq1ZmIkDU9xPajwFIdwtHjTAC4/sCYiXVJPuL/zMEuTWGS2ojU6TXxjWwqB1yuFPrSgIdyfNAnDeYYVL7b/iI5nkJHxvYung34jZIEqvulVNnPsbwCkxuzVvYWyNtjO97BLq9cvBMNMGMeOH2SGRutMb7r5zdDYM=;5:idf7vfM1klEe8X4TZC7+64+PLrYYlQJyrue1XxiLARC/yrInibq3qqD9BhZsfoK9K+zV8ODcsA3nMr0xbqFELEukKSMKZeL81YSYGHenm+Rt9qcroUlJ/XRyoZWi8D6qA1aqMMlRojkzgF7vdatEDw==;24:7zpxoOcOnY3yCNl6ltOVD5AdVUKnsl9doMaiHu6iAlrmn8Ddz1V1LjeF1gNYy9rTf2edbVQMS+hf8q8Y5nz4yIim4Qnta6mkbQGeOjaPh+4=;7:b/KTJdXNtToFyfU24MR0oo5iBokF2IEiKXcRN3uZONbkSumdemp4pzTMbfUV+RSK9o9WBwm+NDzJDYGJiBjdE1KZdJiwayTtJWiOx4raqEPirumonfUgx/3Mh7CdmJnB2hyXphpGaEqArnkQqdiUncux0C4TybdaY8qOYSEvoPtewGncWsaXvrCw4m7Yq7oZCcw2U9Kn7w4PxfHTgP2MvuTs2KxMbcTAMi+oQn7hQooyQCgHVaCo8VB+44+6Wpya SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;20:DNU0VXyMOpLwitfoyqxXYOMCdIEQzCfvONo2oiYHjJIrKLePnd8/AiEi4VZHLJqx27NcabkzHyvtwvjF27YcUMIFtqOKqfID2pIRvmOg5G6Sm/6mPUWr6qsR6JbrBSltTNnbGzXS1t4zODLpQnf/0ZFSHE2FyNj0YGXcp7ey3R0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 14:57:17.6641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1186 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-25_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 08:53 AM, Jiri Kosina wrote: > On Thu, 25 Aug 2016, Jens Axboe wrote: > >> Which patch is this? If that is truly the case, it should be reverted >> asap. > > I've been looking into this for the past few days, and unfortunately I am > not able to come up with a simple fix, so revert seems like the way to go. > > Unfortunately, by reverting the patch, we'll get back into the original > situation, where the bug found by syzkaller would be present. > > If going down the revert path, we'd have to bring the driver to the state > it was before, i.e. reverting it and the followup fix, i.e. > > ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e > 09954bad448791ef01202351d437abdd9497a804 > > And then go back to the drawing board to fix the corruption reported by > syzkaller. I'll revert these two. -- Jens Axboe