From: Krzysztof Kozlowski <krzk@kernel.org>
To: Monish Chunara <monish.chunara@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
Sachin Rathore <sachin.rathore@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sachin <ssachin@qti.qualcomm.com>
Subject: Re: [PATCH V3 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
Date: Tue, 28 Jul 2026 14:29:08 +0200 [thread overview]
Message-ID: <1d648ff6-1936-4002-bd2a-f521e99bc71c@kernel.org> (raw)
In-Reply-To: <147593cd-fc4e-41b9-83cf-2e42988c5e74@oss.qualcomm.com>
On 28/07/2026 14:25, Monish Chunara wrote:
>
>
> On 7/28/2026 5:52 PM, Krzysztof Kozlowski wrote:
>> On 21/07/2026 16:30, Monish Chunara wrote:
>>>
>>>
>>> On 7/8/2026 12:18 PM, Krzysztof Kozlowski wrote:
>>>> On Mon, Jul 06, 2026 at 07:43:44PM +0530, Monish Chunara wrote:
>>>>> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
>>>>>
>>>>> Glymur integrates the MSM SDHCI v5 controller. Document the SoC-specific
>>>>> 'qcom,glymur-sdhci' compatible as required by binding convention to
>>>>> identify the hardware and reserve the namespace for future SoC-specific
>>>>> quirks, with 'qcom,sdhci-msm-v5' as the fallback.
>>>>
>>>> Drop half of above sentence.
>>>>
>>>> "Document the SDHCI controller on Qualcomm Glymur soC, fully compatible
>>>> with existing MSM SDHCI v5."
>>>>
>>>> You do not need to say anything about some conventions or reserving
>>>> namespaces. We do not reserve namespaces...
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> Sure, thanks. will update in v4.
>>>
>>> Just for my understanding, though: how does the suggested wording capture the
>>> why behind the change? Per previous comments and understanding, the rationale
>>> for introducing the SoC-specific compatible is the reason we are making this
>>> change. For future submissions, this would help to avoid similar back-and-forth.
>>>
>>
>> Why do you think you need to document the "why" if it is 100% obvious
>> (and I did state it many times)?
>>
>> Best regards,
>> Krzysztof
>
> This was asked because it was suggested on first-post to add a why.
>
> "Same questions as always... why? Don't explain what you did. Explain why
> ou did that way."
>
> https://lore.kernel.org/all/9bb28a60-2c01-449d-9456-bcf2d780b68c@kernel.org/
>
> Pardon, if this was a misunderstanding.
Yes, so you need to explain why you did that way. Not why you are
sending this patch. We all know why you are sending this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-28 12:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 14:13 [PATCH V3 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
2026-07-06 14:13 ` [PATCH V3 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card Monish Chunara
2026-07-06 14:13 ` [PATCH V3 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
2026-07-08 6:48 ` Krzysztof Kozlowski
2026-07-21 14:30 ` Monish Chunara
2026-07-28 12:22 ` Krzysztof Kozlowski
2026-07-28 12:25 ` Monish Chunara
2026-07-28 12:29 ` Krzysztof Kozlowski [this message]
2026-07-28 12:35 ` Monish Chunara
2026-07-06 14:13 ` [PATCH V3 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC Monish Chunara
2026-07-06 14:13 ` [PATCH V3 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD Monish Chunara
2026-07-15 10:14 ` Konrad Dybcio
2026-07-21 13:54 ` Monish Chunara
2026-07-21 14:04 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d648ff6-1936-4002-bd2a-f521e99bc71c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monish.chunara@oss.qualcomm.com \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sachin.rathore@oss.qualcomm.com \
--cc=ssachin@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®