From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Roman Smirnov <r.smirnov@omp.ru>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Karina Yankevich <k.yankevich@omp.ru>,
<lvc-project@linuxtesting.org>
Subject: Re: [PATCH] netfilter: nfnetlink_log: remove unnecessary check in __build_packet_message()
Date: Fri, 9 Aug 2024 23:20:46 +0300 [thread overview]
Message-ID: <1d68bf3e-9d71-25fd-826b-250bf9160bda@omp.ru> (raw)
In-Reply-To: <20240809074035.11078-1-r.smirnov@omp.ru>
On 8/9/24 10:40 AM, Roman Smirnov wrote:
> skb->dev is always non-NULL, the check is unnecessary.
>
> Remove it.
Mhm, I don't think we need that in a separate paragraph...
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-08-09 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 7:40 Roman Smirnov
2024-08-09 20:20 ` Sergey Shtylyov [this message]
2024-08-20 11:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d68bf3e-9d71-25fd-826b-250bf9160bda@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=k.yankevich@omp.ru \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=r.smirnov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®