From: Joe Perches <joe@perches.com>
To: Henry Sloan <henryksloan@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] KVM: fix checkpatch warnings
Date: Sat, 05 Mar 2022 12:34:53 -0800 [thread overview]
Message-ID: <1d6d9aada7bba49b10e0abb0b1bc75bc43643d24.camel@perches.com> (raw)
In-Reply-To: <20220305202637.457103-1-henryksloan@gmail.com>
On Sat, 2022-03-05 at 15:26 -0500, Henry Sloan wrote:
> Fix "SPDX comment style" warnings
Hi.
You've given all these patches the same email subject line.
That would mean the commit subject line would also be the same
for each of these 6 patches.
That's bad.
More proper would be to use the first line of each commit
message as part of the subject line
i.e.: This subject line would become:
Subject: [PATCH 1/6] KVM: Fix "SPDX comment style" warnings
or perhaps better:
Subject: [PATCH 1/6] KVM: Use typical SPDX comment style
etc...
>
> This patchset fixes many checkpatch warnings in the virt/kvm directory.
And this bit doesn't belong in the first patch of 6, but in a 0/6
patch cover letter.
cheers, Joe
prev parent reply other threads:[~2022-03-05 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 20:26 Henry Sloan
2022-03-05 20:26 ` [PATCH 2/6] " Henry Sloan
2022-03-05 20:26 ` [PATCH 3/6] " Henry Sloan
2022-03-05 20:26 ` [PATCH 4/6] " Henry Sloan
2022-03-05 20:26 ` [PATCH 5/6] " Henry Sloan
2022-03-05 20:26 ` [PATCH 6/6] " Henry Sloan
2022-03-05 20:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d6d9aada7bba49b10e0abb0b1bc75bc43643d24.camel@perches.com \
--to=joe@perches.com \
--cc=henryksloan@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®