From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D43223570C8 for ; Fri, 8 May 2026 06:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778221491; cv=none; b=elCsh7aQ/LU6PpNqxj74Yojvz9rUSYZGFd7H3SlEOlBbEYeUTv7N2kbGs+Sj6UcSuM4Ijq1+5xC5JNmIDsvEdZnSXOArPkZ8X52ynwqdbaLsUf/+Zp/Xsq2HUkTgWSASrsIWaJDYhEyKoYsT9+WSywvoqzqE7iOEibdAPkt1ke4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778221491; c=relaxed/simple; bh=AYucIGE/XxHjtr30OpowBjVhJAyxN7nxsd80Fvb+b0U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RJu+1XmhfqPR6KghHiLRlvSBwgpYg5YRBy4jHW7uNtUUND1zZX0+jPGAGSQA4ZCtuBM5Hn1TcoQuNwgy7BXaGtD2gzlpBWbwEbJnChGDv8kuJZoisFskagbokAL7i+JqNkCPDrcNLokkFR60i0H3jH0fOD1ODX8eyF3EDv+C0xg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QssvYCmm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HtIsVye+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QssvYCmm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HtIsVye+" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6483tqIR2771025 for ; Fri, 8 May 2026 06:24:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ObJL9sENHeTc1JXRa+Fb6potoCEo6WZOsrJoz9aAaYE=; b=QssvYCmmJW20hBJv fhGHJM6VU7h1I5BJwrPVZnHXt9udku3Ume7w2zFsCVcdwjBF9u5bB39LX/SL+4Xb 7dyqqzHL9avf5OfOSO5WcVNJeKCa65vX3hxh0iKDEp1Y6ZE6PojzqBc1huMHpn0Y 2MEwZ8lMKUaXKNt4eSRC4gJQ2uLfEC5mwvVtiAWA9tw8OwKBo0NMTDkFON+3e5Z0 KZzZWsjNTwdsXl8QOVvSKQT1WZ2dLi6rcTa2DXtxuf7Lf+Jqybh8Znd0N2hpeQCe g7z2ZFukfT3keloBYocKHTq5CyqHIdQV0HQ9xaPRd0cnXQ5objNa2Ra1UNWrx8RW +ghGPw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0yt5j9ud-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 06:24:44 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-835444b6ce1so1257498b3a.1 for ; Thu, 07 May 2026 23:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778221484; x=1778826284; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ObJL9sENHeTc1JXRa+Fb6potoCEo6WZOsrJoz9aAaYE=; b=HtIsVye++qH3Bd+AIUGKPBAu75RYF9hphjzWxQ++2mar6nke7XC9unr56ml8VMzNx4 dLR2UJuBUI4wea2lj6Wobj6zDCHEcS7Yn/LLA9jjZuhhcbA/VzKb0+0sWlzSKG/c5eIn ST+XU+4hYV3z0Yf1QFHgjHVQbiC4IMob3N0B711XOhxgIYb2vb4eYKXco1f0AXbkQPyz xWIWBYIRoy5QbzSHzYAj1XUZ1oHcgJS0eqf0G4wWnRjPHzdws2uRcRVExwzU+CPQ+x/8 dieBZM2vC40Pubpv5YAlN+wT5YKcvJ1qBo6tI7gW72A9O+ScvQm1mVCbcLP2sBz66P73 2tFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778221484; x=1778826284; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ObJL9sENHeTc1JXRa+Fb6potoCEo6WZOsrJoz9aAaYE=; b=Sno1cOkDiM71cRtj7dkDJdWQlZqSrBL6qFNo+qnwtnNDYOGAzlk/qFcDj0PzFxTKre MnLRJpQQmd+sYK0ZGkaK/BUsu2T5BIIwX3VXVeZT1IiWVfe+WFkAZLwK8T5PUBPgZDqs 9jCvyCKt4grrwEIeI7fdEY/+39bFlYyyr7A71xpP1CpgJjeetcVIMRsiFrTYqSkRzgUj IvFUnjOnSzpvLdkrF5Kvx3YGur0TlbTjNYxyMfF1HPos6vr9+7NbYDwpS+omwntGq4GM sfkS5t72DQUpg7c2085QQzFhAj25GdQVQaAE/oJWF8cWpCGlsFepKRlXyVeDlYcblbe9 tPPQ== X-Forwarded-Encrypted: i=1; AFNElJ8ZwBR7xlS/NkfV1tRhvNLYFTKmdjZJMaxB78bvHvN8EtC+SnWlrAJNXBYEpJbs2pYYW1c1dkQ84r0tmAY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh+3N00UT7itLAh4OdHIZEHAjZssLy7jWUGL6vBFar824fqy7g hMKDZeY1jTJ5lWAxI6+lmxwE1lRIxabMMqL6akfSGTollL4OGATT//Bi0NrugaXdGM0rLhWS6ty ICr75cEq/cb0Tg8EqRJAq5eV1lC4PSJGBgH5/hH1Yt3Y7YKqtCZLSU8qz5MNOh3KujDo= X-Gm-Gg: AeBDieuuvBhd/LJRcr9khwEkF0q2P5j5uUacYLKhFLMLYiOOcTOGUXsNRLzdeobseWQ MtSZ3NulwTM7G3+FPFK27U56ZvqSlhsR2O1IXmaZewnQdT0hy6gKi3BTlK5Auw/wpwKMpz+B7oz B10qoreC+dgmN1gy3oZqubEvt1o7y044WeOSFulaQr1PeIRk82g6gf0n+obIS+u0kR9bh4Nh6UQ zIe8uHwCOXxzPIdsWCy0waKAck1KY/pSq2wF8Bx0Kk1DljKBw5lDVF+6h/hc21CxjVkK3xVZYm6 xK0ADeOl00oSkpM0bcY4PXwF/TRO+T0O+B37UIt8Y7pW5u6pOGwRSQQmO259FKmPmrmWkgfb1EL iPukqFYzUe6+fpcvSluKs0rdee31GGmdv+d9Trd3xLycpamZU X-Received: by 2002:a05:6a00:9096:b0:81d:dd3a:b8f5 with SMTP id d2e1a72fcca58-83a5dc5ed7dmr11395753b3a.38.1778221483224; Thu, 07 May 2026 23:24:43 -0700 (PDT) X-Received: by 2002:a05:6a00:9096:b0:81d:dd3a:b8f5 with SMTP id d2e1a72fcca58-83a5dc5ed7dmr11395720b3a.38.1778221482631; Thu, 07 May 2026 23:24:42 -0700 (PDT) Received: from [10.219.57.29] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839682abd39sm10888950b3a.52.2026.05.07.23.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 23:24:41 -0700 (PDT) Message-ID: <1d7141d7-3440-4360-bed2-d690fb30a116@oss.qualcomm.com> Date: Fri, 8 May 2026 11:54:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260501-shikra-scm-binding-v1-1-93d7faf1b784@oss.qualcomm.com> <20260504-utopian-civet-of-symmetry-ed48a1@quoll> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20260504-utopian-civet-of-symmetry-ed48a1@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Dc0nbPtW c=1 sm=1 tr=0 ts=69fd81ac cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=212fnMXnYh6t1oBpmLEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: uNtXQy1K34_cRvwWCywPC6Dp83ogA80V X-Proofpoint-ORIG-GUID: uNtXQy1K34_cRvwWCywPC6Dp83ogA80V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDA2MCBTYWx0ZWRfX1tZblMRAD4DA xfCBk4tI0733AaIcoZLR9ZSTSGSkQ5cTQ85RqQ3XcYSCNfk8WXZTzOf2sflWjni3WC8IyVDY0ZN OoHgU9unx6xrOb+5w93Rbq4jMiC6j4xrThcywHALHEx7DWhz0es8yvVylppW3PvydLPfwZoGF89 jCt1WA5/qIvjjoiKkvlf3HIyudV80NBXXDuyrYlAiLzk7XQNPQK8xy0Bacrt8dZT2Jr75mRUfLt 79LHJWmOPMK6bc036aSmfvVZLW7/ZHNVoo6M648tSWy13IgLSzYnDHUcupHKeK+fSa76fiat8Mj fuegygFBWhLTD+Y8jAa6XCnPsL48/bOIOZZJAv6UH593nXGNYWu3HrObfZbHrBSjMu6oUWmH+ya Pn1FGRcsDbhWfBoNZosFSyeub4GLCdmMqQUvaWFOiPGK5RIxqEc9oeJ1OJ8Rys9Va9r/grpmm/R DnuEx/KfK9hf10N6MBQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080060 On 5/4/2026 4:33 PM, Krzysztof Kozlowski wrote: > On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote: >> Document the SCM compatible for the Shikra SoC. >> >> Signed-off-by: Komal Bajaj >> --- >> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index 7918d31f58b4..bb1e0a0d1d3c 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -65,6 +65,7 @@ properties: >> - qcom,scm-sdx55 >> - qcom,scm-sdx65 >> - qcom,scm-sdx75 >> + - qcom,scm-shikra >> - qcom,scm-sm6115 >> - qcom,scm-sm6125 >> - qcom,scm-sm6350 >> @@ -146,6 +147,7 @@ allOf: >> - qcom,scm-msm8974 >> - qcom,scm-msm8976 >> - qcom,scm-qcm2290 >> + - qcom,scm-shikra >> - qcom,scm-sm6375 >> then: >> required: >> @@ -165,6 +167,7 @@ allOf: >> - qcom,scm-msm8660 >> - qcom,scm-msm8960 >> - qcom,scm-qcm2290 >> + - qcom,scm-shikra >> - qcom,scm-sm6375 > This looks wrong or the diff hunks are confusing. Aren't you changing > one if:then: block for clocks and then second different one which > disallows clocks? > > dtbs_check on your DTS would tell you... The two hunks touch two separate allOf blocks: - Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all - Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one clock named core Both hunks are intentional. Verified with dtbs_check — no complaints. Thanks Komal > > Best regards, > Krzysztof >