From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754707AbdKARYB (ORCPT ); Wed, 1 Nov 2017 13:24:01 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:48316 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdKARX6 (ORCPT ); Wed, 1 Nov 2017 13:23:58 -0400 Subject: Re: [PATCH 2/2] samples/bpf: add a test for bpf_override_return To: Josef Bacik , , , , , , , References: <1509555643-2899-1-git-send-email-josef@toxicpanda.com> <1509555643-2899-3-git-send-email-josef@toxicpanda.com> CC: Josef Bacik From: Alexei Starovoitov Message-ID: <1d75b0ed-4a0d-cdfa-5f74-1401f1b99ae8@fb.com> Date: Wed, 1 Nov 2017 10:23:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1509555643-2899-3-git-send-email-josef@toxicpanda.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:39bd] X-ClientProxiedBy: SN4PR0201CA0023.namprd02.prod.outlook.com (2603:10b6:803:2b::33) To CO1PR15MB0966.namprd15.prod.outlook.com (2a01:111:e400:7b64::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0c2512d-ba4d-4aa1-07d6-08d5214d4d58 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:CO1PR15MB0966; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0966;3:9ruBMoAH2BRzKMxlDXiACtm6PXs0EXloMxRq8J0O+zoPKVsbsDoQmo0VqludOxJW+YkWKZIFWKGqE3FAzgofIhO5uuVzX5UqcmvhsdhWIIJ970YYgZq1RRssx2qfhhMvQsO8RbMqEjse0ZXjWfYz/PU282ql9qivz1aFzl6i0u/wIAR6bwvG07h4ZAMQaWHggDIwD5VFz12DM8tTTeBFf0Jmfdy4LtbXcojVTiJXMhLUPIGrQnRw4mQJsaYL5KuT;25:ylhMvl403hveKmk13yc+opHiIFs+i/KSLqrXteqyON8o5wEHoXawIs88Sibf+DbyTtrykMpp944sM7xxsOTjqQLkSLtuT2SkgB0dh2QKczCVYuZRRWZIx5bnSYxoW689+rabfQoWwssXblgjrzPfwd5/apUUm77DOWNZXEw7oL7qg5ug+MfR/QPRIOmwLplsrESF3rYJLoXx71G7DtF/R5WM9zcM+MSDXa2kMFpc63MZY/8pjdd4HX8nZ9zEHZKKyc2Q+w0ZUALDVwGm2RStaDsMX/yZ97vmrhAlquABAE+YGnCwVN53Qzgmu1gZei+fNTnXy5fqfcViC9FuJNi7Jg==;31:wKZoZCxrVCR3PB8bQWlC7THpea0aXnwvgQsktTVEK2QxXXHBARFWosa79+0v7Ps/lquc+jFAqvFBq+GHO/fai9/I1cUB+0tThRgGEaZIEEQ82Zxa1KEkNRAF6m77aCIGOj5viEBCk4Mc12Fs2f3ibbvFN8dUfzEL8Ps8IepkmNZigOp2dcTHhYzunJrkuxfLTi4k4J3HS/i7R86EF/5zyVVUCaYtw9Z75mHIWX6vIcM= X-MS-TrafficTypeDiagnostic: CO1PR15MB0966: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0966;20:JKKBTDK9Hdn5pOUY0NfOacls6MXUyxcKVpxPTchMKssYJXdDFvasWh7D692kDXfeRnsmFro9m6CF/lBl5nWj/0PxSluWMsOqKhYOgvpeH2GcDy5QBtxSRyq0NlPjhaUfx1kXUHcJDr9DXxLqWsF8ACB25EPa93hGe05MHOIO5+LWrMPrOg46s+cQBxaGpRcR1HAuxOtKxO56uatZeOJYKCtM6CgaB35IZ2CX4Xycxs4umRsJXhyG+e5afo21rpJw7Zv9NplsTPdPv2WJ2DUcBxwFQ2lxJar6txIBsqVbtInNXqRxEOHxuPgcDlYs+maqp/1lxzcyOgz0QnocA7KT/qquqaZBIdKGofGYlcQtPIouB3Q1w8B+Ip/JT2XpLVa/3k5EYDJZ73JMyU6f9nkK8sX115c8J1mYdTS+KqX+O2vSY/AmxkcSjwRuDsmARugueu9SzUYV2Wvrni/GBk3im4MgBhKLU3xsiIxSwQO2SVC3627qtyqV3ats7XIrQSyE;4:rv7wD7/ao7DhtMHcaEy9st0z7d3HW3BEO4IwGMA63L+zvWDZ/adLdw6FqEmDd3yZGUYM6oEDRg95fGJ2FC5NGaKEMDGmEDWCgNtEg2o3yDHXF8+jqxoyxDDkGk8kfUqTsm6YKkCd09KFq18knz5qXFBd7DkY4DR4joCbQ0wa6FzSk9O0czXxq/C6d2FxsjakqBscL9amYcaw3rVbYyrdZFxWLadjljWeEOR3rJU9tWFZhDwv51Ayin+6sDNVTpp28eKqZJIgpK21P6sgLHEajpT/QPfAIsUgc661GKwIGEgOCwt/6cGsM93z92hXr3yq X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(3231020)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO1PR15MB0966;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO1PR15MB0966; X-Forefront-PRVS: 0478C23FE0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(24454002)(199003)(189002)(6666003)(86362001)(575784001)(2950100002)(6636002)(65826007)(101416001)(5660300001)(478600001)(6246003)(31686004)(97736004)(76176999)(50986999)(53936002)(54356999)(6486002)(50466002)(229853002)(64126003)(36756003)(105586002)(33646002)(189998001)(106356001)(53546010)(8936002)(1706002)(6116002)(8676002)(230700001)(65956001)(7736002)(2906002)(305945005)(83506002)(47776003)(65806001)(81156014)(31696002)(81166006)(316002)(68736007)(58126008)(23746002)(25786009)(67846002)(4326008)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB0966;H:[IPv6:2620:10d:c081:1131::112d];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CO1PR15MB0966;23:PR1B38ygIPeiC+kiHzLBeP7Jn53j8rvVs8IiM?= =?Windows-1252?Q?I20VyzvvilPNUqNqy3UQ5eu4uJmEDypxA/eMhOnCFlHHAC0f1/z4bejx?= =?Windows-1252?Q?9Sy4eiDVCdzVLHJoQaP5FzSzWX/C5/7VK6cLUCc6bQKurlHj0ErgeJm6?= =?Windows-1252?Q?jZ9ZOEfpHW9eZYgASHOiWzeNeGKP3PfE+JCgNTe7jVdlQz2Ln0XtGRGu?= =?Windows-1252?Q?AX+wFXADbXQdX2qqOmyhHgeiyJxgzeR17yyX7WGs7nhEiJnRru9tnOar?= =?Windows-1252?Q?QK+zSBgkb2LsJ0h1tS0AXe8f8bWnj7FksLVL5Xs0/TAmtU1ECd+uzh20?= =?Windows-1252?Q?67WxVLs+mRFLBJylQ/e06TK0Y2UcrhkUVlcQ0OdXeG9qJzFUQUKBhskZ?= =?Windows-1252?Q?nqaGcguD9Nb0ynIqnYCR3R5eBI+zfkWl4+ZQNGYu6EGOgcW8VIE58QId?= =?Windows-1252?Q?as9JTSme5UHgT2/MS3AUJ5wCOrW6LH3Q0zBaBjr+6svj0CXAVAq/gEPe?= =?Windows-1252?Q?BpGJGtwscqGc6Z5KmsrFah7+dD6ni8NOJeiClaRQj1hzy4qabJavJUwy?= =?Windows-1252?Q?rMxPePOCVB3OfvWNcap6OQQy/uksfm556KqSdAG16KCNkrRQcfchlgfC?= =?Windows-1252?Q?jLuV9CiN51skj/dP+5jydthZHCGG4IIuliNHV8iPPH5WUgmik7wLvvTB?= =?Windows-1252?Q?KPiszcyjWrX80lUDqcUxto6WrClO0BXfewgemQHW66IwBe+sopeyCDav?= =?Windows-1252?Q?kysvyk09GII5+rDncjr8H6MjYBB7l/tV0XN9Nrh9FFqKqnvsMZaHa8eg?= =?Windows-1252?Q?ggIuAiVa8ebTVpHRXuc6n0fbA7JjVvhjTFV5TQSVxLSLD1S2sCgEGU8Z?= =?Windows-1252?Q?8mDZERBoUtzmydcVk5AOCUgaewwUAnX1gZLKT95JGYIjttz+w3s7AEnB?= =?Windows-1252?Q?s5SIP+d73fdDgSHf2IwiaO9nXq0lqnVVoBiVYS+srOZekiiWnDxTS/u0?= =?Windows-1252?Q?zpGPjDIvBFg4RFW+AobuUiIaYcUAqU67uud+WXDKDaL/b4Wb8D+5Zylo?= =?Windows-1252?Q?kpftu/FV20m/xe1blvOjZ9s0tQpcRvWT8zf7TN6AYzgqA3W6qhzzg9vH?= =?Windows-1252?Q?qkDWFCxL2VSwXq3OZGuaQX1nPGJaC3EsLGvtVNTY3B/01IESj5SRqRCD?= =?Windows-1252?Q?oyvjDjLkPQ1e2jkvot8b9YGJHzrdwwzVr6PPLST5QjeCrfkgujAyS79d?= =?Windows-1252?Q?DLr6SbQDOXx+bFREFoNxjoljHYySMOEoOr3cSHjZL2y+R1KJoRNTm3f9?= =?Windows-1252?Q?eSWFy2nNCorwCYjcc1oBNHdwv5MqaUEZO6ys+CtkOGZFalUmWjsDtu7O?= =?Windows-1252?Q?LQzTBe1UgIG?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0966;6:4mcr8tuiwdRloC8z0wSb5JbbS2q8Le9iTiY8t/rqSNBPgRrBwUXg1HQ11fSkJkQQQRXR87O/lcGN6ZLF4bDlhJDWisswrCTKmpwEN/pL2DvSckLBDPF4zF+H1hcMI4CUkOpUG4Wi2pj4HOBTZMaStTPN8S+xDf+g1ONGkJ17jfVjWa3W44n8ax/WyYbecNGjJkGyNKhtaw2v9kj76LNcyRkUnQlAkUV4BPOAPG/QY8HBkseg6xbHr5oxZLlfobBaAWxzURKB3XT9wKjUa2i0r0PMvhwmVZPhpz8d6bTxNCJpx5US/2KD7BPPRpqtNy1sNy8nON0X9Plq5mu/JJJFowt3+Ad2Ymk0voK0XA+GBCU=;5:GMwvxdEirMQzMCM7DUaXmJBYgrPRaeTp/ay9/f9o2hV+YCuc6eWXl5LO2PzKatoJT/hsgsSTtOPXFmSNK1AGXKEXOlKJlEw2WnCiLFF3PaASev4rckOF1vGTNb+5GMdYIL4NiwRQw0U/x055crTSkkdOmsUJa3DJ5o2JZQA8aJY=;24:v9FEVxoOJZjs4fLFYtlvgIFPEu2X+sfCYqhlyTGlcSk0LNtlFE6Lg6oc1pDzYAiMARyWkQ0vPj1wUWwmmzf3mYD1ZWigqAY5vIj7dPB5ioU=;7:ryxjdtZsuIw6Cw7S3qAdkQOSHInf9qhQOYtxQRjVYpsfR7FC3ZTXM3UFHA33+gs3okT8Vadjc/7RV2Xt5NCh5pFyLHPWOBONkNO3hMtLoFZKmp41TvXzyXLU8NQh7RubO1lLqg3OTNy3i4N1PRZQo1u5aHM2Phi7RZKnHvAuX3pxlPdSzcUP92HmQWuLSZVPXLIYTtunP8kZM6yJMnaUnNxNPBBCDWB3jekSfJfPBVQ5Qp5Bcazcro/bLYPFd/18 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0966;20:2ccQJPBxdKo1CbevY4r9Zc3CehV3qSWVTQi9givaxNZMNSuerUIea6bTcB0JuTmuR/M8Pjo3BMJNq/Cg/e6eoceIkEi68qsWdVwkxiRiB2Cou95cwIDJRnTErU3IS8GgzRTVJFDjhW2+kzEzUctCE1Ou/Jkw0o4SuTiYAWokTVY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2017 17:23:42.0199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0c2512d-ba4d-4aa1-07d6-08d5214d4d58 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB0966 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-01_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/17 10:00 AM, Josef Bacik wrote: > From: Josef Bacik > > This adds a basic test for bpf_override_return to verify it works. We > override the main function for mounting a btrfs fs so it'll return > -ENOMEM and then make sure that trying to mount a btrfs fs will fail. > > Signed-off-by: Josef Bacik Acked-by: Alexei Starovoitov > +++ b/samples/bpf/test_override_return.sh > @@ -0,0 +1,15 @@ > +#!/bin/bash > + > +rm -f testfile.img > +dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 > +DEVICE=$(losetup --show -f testfile.img) > +mkfs.btrfs -f $DEVICE > +mkdir tmpmnt > +./tracex7 $DEVICE > +if [ $? -eq 0 ] > +then > + echo "SUCCESS!" > +else > + echo "FAILED!" > +fi > +losetup -d $DEVICE > diff --git a/samples/bpf/tracex7_kern.c b/samples/bpf/tracex7_kern.c > new file mode 100644 > index 000000000000..1ab308a43e0f > --- /dev/null > +++ b/samples/bpf/tracex7_kern.c > @@ -0,0 +1,16 @@ > +#include > +#include > +#include > +#include "bpf_helpers.h" > + > +SEC("kprobe/open_ctree") > +int bpf_prog1(struct pt_regs *ctx) > +{ > + unsigned long rc = -12; > + > + bpf_override_return(ctx, rc); > + return 0; > +} great stuff. I wonder in how many kernel test frameworks it will appear in the near future. We can even stress test bpf with bpf.